added condition for distributed logic #3877

ashutosji · 2024-06-18T12:23:28Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix
/kind release

What this PR does / Why we need it:

Which issue(s) this PR fixes:#3862

Closes #3862

Special notes for your reviewer:

agones-bot · 2024-06-18T13:27:36Z

Build Succeeded 👏

Build Id: 947d2e56-46aa-40d9-83fa-163e6c714757

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://ade2cc5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3877/head:pr_3877 && git checkout pr_3877
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-ade2cc5-amd64

igooch

Looks good, just one nit.

igooch · 2024-06-21T05:58:50Z

pkg/gameserverallocations/find.go

@@ -40,6 +40,9 @@ func findGameServerForAllocation(gsa *allocationv1.GameServerAllocation, list []

 	var loop func(list []*agonesv1.GameServer, f func(i int, gs *agonesv1.GameServer))

+	// Determine if Priorities are set in the Fleet spec
+	prioritiesSet := len(gsa.Spec.Priorities) > 0


This can be moved to inside the case apis.Distributed:

agones-bot · 2024-06-24T08:48:31Z

Build Succeeded 👏

Build Id: fcfb7f98-4492-40cf-89f2-1c8379cd2163

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://fe78c66-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3877/head:pr_3877 && git checkout pr_3877
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-fe78c66-amd64

markmandel · 2024-06-26T00:20:39Z

pkg/gameserverallocations/find.go

 		// randomised looping - make a list of indices, and then randomise them
 		// as we don't want to change the order of the gameserver slice
-		if !runtime.FeatureEnabled(runtime.FeatureCountsAndLists) {
+		if !runtime.FeatureEnabled(runtime.FeatureCountsAndLists) || !prioritiesSet {


Suggested change

if !runtime.FeatureEnabled(runtime.FeatureCountsAndLists) || !prioritiesSet {

if !runtime.FeatureEnabled(runtime.FeatureCountsAndLists) || len(gsa.Spec.Priorities) == 0 {

Small thing, but probably doesn't need a variable? WDYT @igooch ?

No strong feelings either way. It's probably not needed.

@ashutosji bump on removing this variable, and just moving the check inline, and then I think this is good to merge.

@ashutosji bump on removing this variable, and just moving the check inline, and then I think this is good to merge.

Thanks! Moved the check inline.

agones-bot · 2024-07-14T09:41:23Z

Build Succeeded 👏

Build Id: 31b18c3b-b930-4217-8064-5da499ad5879

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://38093a1-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3877/head:pr_3877 && git checkout pr_3877
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-38093a1-amd64

igooch

LGTM

agones-bot · 2024-07-15T20:04:25Z

Build Succeeded 👏

Build Id: bad00577-2428-40f1-8ecd-e12f8b3188b4

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://0ab6227-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3877/head:pr_3877 && git checkout pr_3877
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-0ab6227-amd64

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [agones](https://agones.dev) ([source](https://github.com/googleforgames/agones)) | minor | `1.41.0` -> `1.42.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleforgames/agones (agones)</summary> ### [`v1.42.0`](https://github.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1420-2024-07-16) [Compare Source](https://github.com/googleforgames/agones/compare/v1.41.0...v1.42.0) [Full Changelog](https://github.com/googleforgames/agones/compare/v1.41.0...v1.42.0) **Breaking changes:** - Update csharp.md to indicate ConnectAsync is deprecated by [@aallbrig](https://github.com/aallbrig) in [googleforgames/agones#3866 **Implemented enhancements:** - Add security context to Agones containers by [@peterzhongyi](https://github.com/peterzhongyi) in [googleforgames/agones#3856 - Add Security Context to game server sidecar by [@peterzhongyi](https://github.com/peterzhongyi) in [googleforgames/agones#3869 - Drop CountsAndLists Data from the Fleet and Game Server Set When the Flag is False by [@igooch](https://github.com/igooch) in [googleforgames/agones#3881 - Adds tests to confirm that Fleet, Fleet Autoscaler, and Fleet Allocation apply defaults code is idempotent by [@igooch](https://github.com/igooch) in [googleforgames/agones#3888 - feat: Add CRD Changes and Feature Flag for chain policy by [@indexjoseph](https://github.com/indexjoseph) in [googleforgames/agones#3880 **Fixed bugs:** - sdk-server expects SDK_LOG_LEVEL by [@KAllan357](https://github.com/KAllan357) in [googleforgames/agones#3858 - this will resolve From/layer extraction issue on ltsc2019 in examples by [@ashutosji](https://github.com/ashutosji) in [googleforgames/agones#3873 - featuregate: adds validation if PortPolicyNone is not enabled by [@daniellee](https://github.com/daniellee) in [googleforgames/agones#3871 - added local as default for registry when registry is not specified by [@kamaljeeti](https://github.com/kamaljeeti) in [googleforgames/agones#3876 - Buffer Unity SDK ReceiveData when watching for configuration changes by [@ZeroParticle](https://github.com/ZeroParticle) in [googleforgames/agones#3872 - agones-{extensions,allocator}: Make servers context aware by [@zmerlynn](https://github.com/zmerlynn) in [googleforgames/agones#3845 - added condition for distributed logic by [@ashutosji](https://github.com/ashutosji) in [googleforgames/agones#3877 **Security fixes:** - Bump [@grpc/grpc-js](https://github.com/grpc/grpc-js) from 1.10.7 to 1.10.9 in /sdks/nodejs by [@dependabot](https://github.com/dependabot) in [googleforgames/agones#3863 **Other:** - Preparation for Release v1.42.0 by [@ashutosji](https://github.com/ashutosji) in [googleforgames/agones#3854 - Add helpful note to edit-first-gameserver-go by [@peterzhongyi](https://github.com/peterzhongyi) in [googleforgames/agones#3846 - Moved Passthrough feature description to the correct section in Feature Stages by [@vicentefb](https://github.com/vicentefb) in [googleforgames/agones#3861 - Updated Node.js Page to Reflect that Counters and Lists is Implemented by [@ashutosji](https://github.com/ashutosji) in [googleforgames/agones#3865 - Change Slack channel description from #developers to #development by [@branhoff](https://github.com/branhoff) in [googleforgames/agones#3868 - updated UpdateList documentation for local sdk server and sdk server by [@ashutosji](https://github.com/ashutosji) in [googleforgames/agones#3878 - Add zio-agones to the list of third party client SDKs by [@ghostdogpr](https://github.com/ghostdogpr) in [googleforgames/agones#3875 - refactor simple game server by [@ashutosji](https://github.com/ashutosji) in [googleforgames/agones#3817 - Update Slack invite link by [@markmandel](https://github.com/markmandel) in [googleforgames/agones#3896 - Added cleanup for app-engine services in cloudbuild script by [@kamaljeeti](https://github.com/kamaljeeti) in [googleforgames/agones#3890 - Adds a command to generate the zz_generated.deepcopy.go files for the apis by [@igooch](https://github.com/igooch) in [googleforgames/agones#3900 - update go version to 1.21.12 by [@ashutosji](https://github.com/ashutosji) in [googleforgames/agones#3894 **New Contributors:** - [@KAllan357](https://github.com/KAllan357) made their first contribution in [googleforgames/agones#3858 - [@branhoff](https://github.com/branhoff) made their first contribution in [googleforgames/agones#3868 - [@aallbrig](https://github.com/aallbrig) made their first contribution in [googleforgames/agones#3866 - [@ZeroParticle](https://github.com/ZeroParticle) made their first contribution in [googleforgames/agones#3872 - [@ghostdogpr](https://github.com/ghostdogpr) made their first contribution in [googleforgames/agones#3875 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

ashutosji requested a review from igooch June 18, 2024 12:23

github-actions bot added kind/bug These are bugs. size/XS labels Jun 18, 2024

ashutosji requested a review from markmandel June 18, 2024 12:24

igooch reviewed Jun 21, 2024

View reviewed changes

ashutosji force-pushed the distributed-default branch from ade2cc5 to fe78c66 Compare June 24, 2024 07:30

markmandel reviewed Jun 26, 2024

View reviewed changes

ashutosji added 3 commits July 14, 2024 07:20

added condition for distributed logic

8101b2e

moved inside distributed

decda1d

added the inline suggestion

38093a1

ashutosji force-pushed the distributed-default branch from fe78c66 to 38093a1 Compare July 14, 2024 07:22

igooch approved these changes Jul 15, 2024

View reviewed changes

Merge branch 'main' into distributed-default

0ab6227

igooch enabled auto-merge (squash) July 15, 2024 18:36

igooch merged commit a4576c6 into googleforgames:main Jul 15, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added condition for distributed logic #3877

added condition for distributed logic #3877

ashutosji commented Jun 18, 2024

agones-bot commented Jun 18, 2024

igooch left a comment

igooch Jun 21, 2024

agones-bot commented Jun 24, 2024

markmandel Jun 26, 2024

igooch Jul 2, 2024

markmandel Jul 11, 2024

ashutosji Jul 14, 2024

agones-bot commented Jul 14, 2024

igooch left a comment

agones-bot commented Jul 15, 2024

	if !runtime.FeatureEnabled(runtime.FeatureCountsAndLists) \|\| !prioritiesSet {
	if !runtime.FeatureEnabled(runtime.FeatureCountsAndLists) \|\| len(gsa.Spec.Priorities) == 0 {

added condition for distributed logic #3877

added condition for distributed logic #3877

Conversation

ashutosji commented Jun 18, 2024

agones-bot commented Jun 18, 2024

igooch left a comment

Choose a reason for hiding this comment

igooch Jun 21, 2024

Choose a reason for hiding this comment

agones-bot commented Jun 24, 2024

markmandel Jun 26, 2024

Choose a reason for hiding this comment

igooch Jul 2, 2024

Choose a reason for hiding this comment

markmandel Jul 11, 2024

Choose a reason for hiding this comment

ashutosji Jul 14, 2024

Choose a reason for hiding this comment

agones-bot commented Jul 14, 2024

igooch left a comment

Choose a reason for hiding this comment

agones-bot commented Jul 15, 2024