Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tests to confirm that Fleet, Fleet Autoscaler, and Fleet Allocation apply defaults code is idempotent #3888

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Jul 1, 2024

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Adds tests to confirm that calling Fleet, Fleet Autoscaler, and Fleet Allocation ApplyDefaults more than one time does not change the original result.

Which issue(s) this PR fixes:

Working on #3771

Special notes for your reviewer:

This does not change the Game Server ApplyDefaults code, or expect the Game Server ApplyDefaults code to be idempotent.

@github-actions github-actions bot added kind/feature New features for Agones size/S labels Jul 1, 2024
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e29dbe0f-1863-4b12-a92a-17c623a65797

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/3888/head:pr_3888 && git checkout pr_3888
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.42.0-dev-7cdc9a2-amd64

@zmerlynn zmerlynn merged commit f8f8b23 into googleforgames:main Jul 1, 2024
4 checks passed
spiceratops added a commit to spiceratops/k8s-gitops that referenced this pull request Jul 23, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [agones](https://agones.dev)
([source](https://github.com/googleforgames/agones)) | minor |
`1.41.0` -> `1.42.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>googleforgames/agones (agones)</summary>

###
[`v1.42.0`](https://github.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1420-2024-07-16)

[Compare
Source](https://github.com/googleforgames/agones/compare/v1.41.0...v1.42.0)

[Full
Changelog](https://github.com/googleforgames/agones/compare/v1.41.0...v1.42.0)

**Breaking changes:**

- Update csharp.md to indicate ConnectAsync is deprecated by
[@&#8203;aallbrig](https://github.com/aallbrig) in
[googleforgames/agones#3866

**Implemented enhancements:**

- Add security context to Agones containers by
[@&#8203;peterzhongyi](https://github.com/peterzhongyi) in
[googleforgames/agones#3856
- Add Security Context to game server sidecar by
[@&#8203;peterzhongyi](https://github.com/peterzhongyi) in
[googleforgames/agones#3869
- Drop CountsAndLists Data from the Fleet and Game Server Set When the
Flag is False by [@&#8203;igooch](https://github.com/igooch) in
[googleforgames/agones#3881
- Adds tests to confirm that Fleet, Fleet Autoscaler, and Fleet
Allocation apply defaults code is idempotent by
[@&#8203;igooch](https://github.com/igooch) in
[googleforgames/agones#3888
- feat: Add CRD Changes and Feature Flag for chain policy by
[@&#8203;indexjoseph](https://github.com/indexjoseph) in
[googleforgames/agones#3880

**Fixed bugs:**

- sdk-server expects SDK_LOG_LEVEL by
[@&#8203;KAllan357](https://github.com/KAllan357) in
[googleforgames/agones#3858
- this will resolve From/layer extraction issue on ltsc2019 in examples
by [@&#8203;ashutosji](https://github.com/ashutosji) in
[googleforgames/agones#3873
- featuregate: adds validation if PortPolicyNone is not enabled by
[@&#8203;daniellee](https://github.com/daniellee) in
[googleforgames/agones#3871
- added local as default for registry when registry is not specified by
[@&#8203;kamaljeeti](https://github.com/kamaljeeti) in
[googleforgames/agones#3876
- Buffer Unity SDK ReceiveData when watching for configuration changes
by [@&#8203;ZeroParticle](https://github.com/ZeroParticle) in
[googleforgames/agones#3872
- agones-{extensions,allocator}: Make servers context aware by
[@&#8203;zmerlynn](https://github.com/zmerlynn) in
[googleforgames/agones#3845
- added condition for distributed logic by
[@&#8203;ashutosji](https://github.com/ashutosji) in
[googleforgames/agones#3877

**Security fixes:**

- Bump [@&#8203;grpc/grpc-js](https://github.com/grpc/grpc-js) from
1.10.7 to 1.10.9 in /sdks/nodejs by
[@&#8203;dependabot](https://github.com/dependabot) in
[googleforgames/agones#3863

**Other:**

- Preparation for Release v1.42.0 by
[@&#8203;ashutosji](https://github.com/ashutosji) in
[googleforgames/agones#3854
- Add helpful note to edit-first-gameserver-go by
[@&#8203;peterzhongyi](https://github.com/peterzhongyi) in
[googleforgames/agones#3846
- Moved Passthrough feature description to the correct section in
Feature Stages by [@&#8203;vicentefb](https://github.com/vicentefb) in
[googleforgames/agones#3861
- Updated Node.js Page to Reflect that Counters and Lists is Implemented
by [@&#8203;ashutosji](https://github.com/ashutosji) in
[googleforgames/agones#3865
- Change Slack channel description from #developers to #development by
[@&#8203;branhoff](https://github.com/branhoff) in
[googleforgames/agones#3868
- updated UpdateList documentation for local sdk server and sdk server
by [@&#8203;ashutosji](https://github.com/ashutosji) in
[googleforgames/agones#3878
- Add zio-agones to the list of third party client SDKs by
[@&#8203;ghostdogpr](https://github.com/ghostdogpr) in
[googleforgames/agones#3875
- refactor simple game server by
[@&#8203;ashutosji](https://github.com/ashutosji) in
[googleforgames/agones#3817
- Update Slack invite link by
[@&#8203;markmandel](https://github.com/markmandel) in
[googleforgames/agones#3896
- Added cleanup for app-engine services in cloudbuild script by
[@&#8203;kamaljeeti](https://github.com/kamaljeeti) in
[googleforgames/agones#3890
- Adds a command to generate the zz_generated.deepcopy.go files for the
apis by [@&#8203;igooch](https://github.com/igooch) in
[googleforgames/agones#3900
- update go version to 1.21.12 by
[@&#8203;ashutosji](https://github.com/ashutosji) in
[googleforgames/agones#3894

**New Contributors:**

- [@&#8203;KAllan357](https://github.com/KAllan357) made their first
contribution in
[googleforgames/agones#3858
- [@&#8203;branhoff](https://github.com/branhoff) made their first
contribution in
[googleforgames/agones#3868
- [@&#8203;aallbrig](https://github.com/aallbrig) made their first
contribution in
[googleforgames/agones#3866
- [@&#8203;ZeroParticle](https://github.com/ZeroParticle) made their
first contribution in
[googleforgames/agones#3872
- [@&#8203;ghostdogpr](https://github.com/ghostdogpr) made their first
contribution in
[googleforgames/agones#3875

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants