Update SIDECAR_IMAGE tag in Helm chart variable #4020
Conversation
github-actions
bot
added
kind/cleanup
|
Build Failed 😭 Build Id: 28ed4343-6ce7-417f-b808-5499ac931a10 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Issue #3979 mentioned the specific use case for adding a separate variable to specify the sidecar image is "useful in situations where the sidecar image needs to be pulled from a private registry". Can a image from a private registry be simply specified by a tag, or does it need some sort of repository url with a tag? In other words, how would pulling from a sidecar image a private registry be done with the tag? |
|
@kangjk1017 Since you opened this issue, I thought it might be helpful to mention you here - do you think adding a variable to accept other Agones SDK tags will help fix the issue? |
| @@ -123,7 +123,7 @@ spec: | |||
| value: {{ .Values.gameservers.additionalPortRanges | toJson | quote }} | |||
| {{- end }} | |||
| - name: SIDECAR_IMAGE # overwrite the GameServer sidecar image that is used | |||
| value: "{{ .Values.agones.image.registry }}/{{ .Values.agones.image.sdk.name}}:{{ default .Values.agones.image.tag .Values.agones.image.sdk.tag }}" | |||
There was a problem hiding this comment.
I think what was asking for is expose a variable to set the registry for SIDECAR_IMAGE separately rather than using agones.image.registry
There was a problem hiding this comment.
user has provided a comment regarding the same queries. (#3979 (comment))
There was a problem hiding this comment.
Yes, and what user asked "This is why I proposed the option to modify the registry for the SDK image." aligns with what I proposed above.
…gleforgames#4016) * Allowing list based fleet autoscaler to scale up from 0 replicas * Omiting discarded 2nd value from range * Fixing unit tests * Moving the list initialization logic from fleet controller to gsset controller * Addressing PR comments * Update pkg/fleetautoscalers/fleetautoscalers.go --------- Co-authored-by: igooch <igooch@google.com>
…d install Agones (googleforgames#4023) * add oke terraform and docs * modify all Copyrights 2020 to 2024 --------- Co-authored-by: Mark Mandel <markmandel@google.com>
* Update Supported to 1.29, 1.30, 1.31 * nit * regenerate crd docs * revert ID * using 1.30.4 patch version --------- Co-authored-by: Mengye (Max) Gong <8364575+gongmax@users.noreply.github.com>
* added dashboard for agones gameserver state duration * lint * updated json * lint * changed the UID and reimporting works * nit * reverted UID change --------- Co-authored-by: Mengye (Max) Gong <8364575+gongmax@users.noreply.github.com>
…oogleforgames#3940) * Add a CI check to fail on change to an example without a new version If any files change within an example - outside of a simple denylist - and the version in its Makefile is not updated, this new tool will fail the CI pipeline. * Make prefix check for version stricter
…he firewall rules from the upgrade terraform as they already exists as part of the e2e terraform, and will conflict. (googleforgames#4036)
…4021) * Add metric for agones_fleets_active_gameserverset_percentage calculation * lint fixed --------- Co-authored-by: Mengye (Max) Gong <8364575+gongmax@users.noreply.github.com> Co-authored-by: Vicente Ferrara <47219931+vicentefb@users.noreply.github.com>
* Introducing Agones Guru on Gurubase.io Signed-off-by: Kursat Aktas <kursat.ce@gmail.com> * agones guru moved from readme to 3rd part tools page on doc --------- Signed-off-by: Kursat Aktas <kursat.ce@gmail.com>
* Release version 1.45.0 - New features and bug fixes * changelog.md date update * data-proofer-ignore in previous release
This fixes a bug within the CI check for unversioned changes to examples, involving an exclude pattern not matching relevant file paths that contain separators.
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Special notes for your reviewer: