Skip to content

Commit

Permalink
Fix CI failures on main (#757)
Browse files Browse the repository at this point in the history
Fixes the following CI failures on `main`:
1. Lint failures on the newly released Rust 1.75 (see #756)
    (plus pre-emptively fixes another for Rust 1.76 beta).
2. Integration test failures due to the Ruby example having
    picked up newer bundler, which is not compatible with
    the Ruby 2.7 it uses.

I've opted to delete the Ruby example entirely, since:
1. This is currently blocking libcnb.rs PRs/development.
2. It has multiple issues that really require a complete rewrite:
  - #398
  - #479
  - #746
  - #755
3. IMO including a full language CNB example in this repo is
  not something we should do, since it's both never going to
  fully support the language in a best practice way, and also
  will be too complicated to demonstrate libcnb concepts in
  the simplified way that we should be using in an example.
  Instead, we should stick to simple examples of concepts,
  and then link out to our real-world CNB repos for users
  who want to do further reading.

As an added bonus, the removal will speed up CI a fair amount, since
the Ruby integration test was very slow (due to it bundler plus the test
using a different builder image, so another docker pull).

Fixes #756.
Fixes #755.
Closes #398.
Closes #479.
Closes #746.
GUS-W-14739082.
GUS-W-14739086.
  • Loading branch information
edmorley committed Jan 3, 2024
1 parent 24a10fd commit 958a85f
Show file tree
Hide file tree
Showing 14 changed files with 7 additions and 506 deletions.
1 change: 0 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ resolver = "2"
members = [
"examples/basics",
"examples/execd",
"examples/ruby-sample",
"libcnb",
"libcnb-cargo",
"libcnb-common",
Expand Down
21 changes: 0 additions & 21 deletions examples/ruby-sample/Cargo.toml

This file was deleted.

12 changes: 0 additions & 12 deletions examples/ruby-sample/buildpack.toml

This file was deleted.

125 changes: 0 additions & 125 deletions examples/ruby-sample/src/layers/bundler.rs

This file was deleted.

5 changes: 0 additions & 5 deletions examples/ruby-sample/src/layers/mod.rs

This file was deleted.

61 changes: 0 additions & 61 deletions examples/ruby-sample/src/layers/ruby.rs

This file was deleted.

87 changes: 0 additions & 87 deletions examples/ruby-sample/src/main.rs

This file was deleted.

Loading

0 comments on commit 958a85f

Please sign in to comment.