Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration tests failing on main due to example Ruby CNB bundler error #755

Closed
edmorley opened this issue Jan 2, 2024 · 0 comments · Fixed by #757
Closed

Integration tests failing on main due to example Ruby CNB bundler error #755

edmorley opened this issue Jan 2, 2024 · 0 comments · Fixed by #757
Assignees
@edmorley
Labels
bug Something isn't working examples

Comments

@edmorley
Copy link
Member

edmorley commented Jan 2, 2024 •
edited
Loading

The integration tests in CI on main are failing with:

---- basic stdout ----
thread 'basic' panicked at /home/runner/work/libcnb.rs/libcnb.rs/libcnb-test/src/test_runner.rs:163:17:
Error performing pack build:

pack command failed with exit code 1!
error: test failed, to rerun pass `-p examples-ruby-sample --test integration_test`

## stderr:

[DEPRECATED] The `--path` flag is deprecated because it relies on being remembered across bundler invocations, which bundler will no longer do in future versions. Instead please use `bundle config set path '/layers/libcnb-examples_ruby/bundler'`, and stop using this flag
[DEPRECATED] The --binstubs option will be removed in favor of `bundle binstubs --all`
bundler-2.5.3 requires ruby version >= 3.0.0, which is incompatible with the
current version, 2.7.4
Unhandled error:
> BuildpackError(BundleInstallUnexpectedExitStatus(ExitStatus(unix_wait_status(1280))))
Buildpack will exit!
ERROR: failed to build: executing lifecycle: failed with status code: 51

(from https://github.com/heroku/libcnb.rs/actions/runs/7374728375/job/20065448224?pr=754#step:8:536)

IMO this is yet another reason to just delete the example Ruby CNB from this repo for now (see #398 for more reasons).

GUS-W-14739082.
@edmorley edmorley added bug Something isn't working examples labels Jan 2, 2024
This was referenced Jan 2, 2024
Closed
Merged
@edmorley edmorley self-assigned this Jan 2, 2024
edmorley added a commit that referenced this issue Jan 3, 2024
@edmorley
Fix CI failures on main (#757)
958a85f 
Fixes the following CI failures on `main`:
1. Lint failures on the newly released Rust 1.75 (see #756)
    (plus pre-emptively fixes another for Rust 1.76 beta).
2. Integration test failures due to the Ruby example having
    picked up newer bundler, which is not compatible with
    the Ruby 2.7 it uses.

I've opted to delete the Ruby example entirely, since:
1. This is currently blocking libcnb.rs PRs/development.
2. It has multiple issues that really require a complete rewrite:
  - #398
  - #479
  - #746
  - #755
3. IMO including a full language CNB example in this repo is
  not something we should do, since it's both never going to
  fully support the language in a best practice way, and also
  will be too complicated to demonstrate libcnb concepts in
  the simplified way that we should be using in an example.
  Instead, we should stick to simple examples of concepts,
  and then link out to our real-world CNB repos for users
  who want to do further reading.

As an added bonus, the removal will speed up CI a fair amount, since
the Ruby integration test was very slow (due to it bundler plus the test
using a different builder image, so another docker pull).

Fixes #756.
Fixes #755.
Closes #398.
Closes #479.
Closes #746.
GUS-W-14739082.
GUS-W-14739086.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edmorley edmorley

Labels
bug Something isn't working examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix CI failures on main heroku/libcnb.rs
1 participant
@edmorley