Fix CI failures on main
#757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following CI failures on `main`: 1. Lint failures on the newly released Rust 1.75 (see #756) (plus preemptively fixes another for Rust 1.76 beta). 2. Integration test failures due to the Ruby example having picked up newer bundler, which is not compatible with the Ruby 2.7 it uses. I've opted to delete the Ruby example entirely, since: 1. This is currently blocking libcnb.rs PRs/development. 2. It has multiple issues that really require a complete rewrite: - #398 - #479 - #746 - #755 3. IMO including a full language CNB example in this repo is not something we should do, since it's both never going to fully support the language in a best practice way, and also will be too complicated to demonstrate libcnb concepts in the simplified way that we should be using in an example. Instead, we should stick to simple examples of concepts, and then link out to our real-world CNB repos for users who want to do further reading. As an added bonus, the removal will speed up CI a fair amount, since the Ruby integration test was very slow (due to it bundler plus the test using a different builder image, so another docker pull). Fixes #756. Fixes #398. Fixes #479. Fixes #746. Fixes #755. GUS-W-14739082. GUS-W-14739086.
Malax
approved these changes
Jan 3, 2024
This was referenced Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following CI failures on
main:maindue to example Ruby CNB bundler error #755).I've opted to delete the Ruby example entirely, since:
ruby-sampleintegration test #479unwrap()in non-test code #746maindue to example Ruby CNB bundler error #755basicandexecdexamples, but add more of them), and then separately link out to our real-world CNB repos for users who want to do further reading.As an added bonus, the removal will speed up CI a fair amount, since the Ruby integration test was very slow (due to it bundler plus the test using a different builder image, so another docker pull).
Fixes #756.
Fixes #755.
Closes #398.
Closes #479.
Closes #746.
GUS-W-14739082.
GUS-W-14739086.