Example Ruby buildpack uses unwrap() in non-test code
#746
Comments
edmorley
added a commit
that referenced
this issue
Nov 17, 2023
As of the Cargo included in Rust 1.74, lints can now be configured in `Cargo.toml` across whole crates/workspaces: https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html https://doc.rust-lang.org/stable/cargo/reference/manifest.html#the-lints-section https://doc.rust-lang.org/stable/cargo/reference/workspaces.html#the-lints-table This reduces the boilerplate, and chance that we forget to enable lints in some targets. The only thing we need to remember is to add the `[lints] workspace = true` to any new crates in the future. Making this switch exposed a few places where lints weren't enabled and issues had been missed, eg: #746 Since this feature requires Rust 1.74, the MSRV has also been bumped. (Though we will have had to do so soon anyway to be able to start using `Result::inspect_err`, which is due in Rust 1.76, xref: #723 (comment)) GUS-W-14511805.
This was referenced Jan 2, 2024
Merged
|
Wontfix since the Ruby example has been removed in #757. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We should not be using
.unwrap()outside of tests.These were found by the
unwrap_usedlint (which is about to be enabled across the whole repo).libcnb.rs/examples/ruby-sample/src/layers/bundler.rs
Lines 55 to 57 in 335b351
libcnb.rs/examples/ruby-sample/src/layers/bundler.rs
Line 96 in 335b351
libcnb.rs/examples/ruby-sample/src/layers/bundler.rs
Line 108 in 335b351
The text was updated successfully, but these errors were encountered: