Add optional opentelemetry file export tracing #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshwlewis
commented
Nov 8, 2023
|
@joshwlewis It looks like there were new versions of the opentelemetry crates released in the last couple of days: Maybe worth picking those new versions up now? |
Malax
approved these changes
Nov 13, 2023
edmorley
requested changes
Nov 13, 2023
edmorley
added a commit
that referenced
this pull request
Nov 17, 2023
As of the Cargo included in Rust 1.74, lints can now be configured in `Cargo.toml` across whole crates/workspaces: https://blog.rust-lang.org/2023/11/16/Rust-1.74.0.html https://doc.rust-lang.org/stable/cargo/reference/manifest.html#the-lints-section https://doc.rust-lang.org/stable/cargo/reference/workspaces.html#the-lints-table This reduces the boilerplate, and chance that we forget to enable lints in some targets. The only thing we need to remember is to add the `[lints] workspace = true` to any new crates in the future. Making this switch exposed a few places where lints weren't enabled and issues had been missed, eg: #746 Since this feature requires Rust 1.74, the MSRV has also been bumped. (Though we will have had to do so soon anyway to be able to start using `Result::inspect_err`, which is due in Rust 1.76, xref: #723 (comment)) GUS-W-14511805.
joshwlewis
force-pushed
the
otel-tracing-2
branch
from
65e851e to
5b911db
Compare
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
edmorley
approved these changes
Dec 5, 2023
edmorley
added a commit
to heroku/buildpacks-procfile
that referenced
this pull request
Feb 23, 2024
This enables `libcnb`'s `trace` feature, which means traces, spans, and events are written to OpenTelemetry export files on disk in the ephemeral build container, which can then be read by the Heroku build system or when debugging locally with Pack (so long as a suitable `--volume` mount has been configured). See: heroku/libcnb.rs#723 GUS-W-15108954.
colincasey
added a commit
to heroku/buildpacks-nodejs
that referenced
this pull request
Oct 28, 2024
Removes the otel tracing added in [#652](#652) which was introduced before the `libcnb` tracing support in [heroku/libcnb.rs#723](heroku/libcnb.rs#723). This is also blocking the dependency updates in [#942](#942).
colincasey
added a commit
to heroku/buildpacks-nodejs
that referenced
this pull request
Nov 5, 2024
Removes the otel tracing added in [#652](#652) in favor of the `libcnb` tracing support added in [heroku/libcnb.rs#723](heroku/libcnb.rs#723).
colincasey
added a commit
to heroku/buildpacks-nodejs
that referenced
this pull request
Nov 6, 2024
* Use the tracing features provided by `libcnb` Removes the otel tracing added in [#652](#652) in favor of the `libcnb` tracing support added in [heroku/libcnb.rs#723](heroku/libcnb.rs#723). * Update CHANGELOG.md * Update buildpacks/nodejs-corepack/CHANGELOG.md Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com> --------- Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative implementation of #705.
This PR adds opt-in functionality (with the
tracefeature) that writes OpenTelemetry File Export tracing information during build and compile. The tracing data includes buildpack attributes (like buildpack id, name), spans for build and detect, events forbuild-success,detect-pass,detect-fail, and also sets errors and span status in the case of errors.GUS-W-14348835.