Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.8.4 patch db #3658

Closed
wants to merge 34 commits into from
Closed

1.8.4 patch db #3658

wants to merge 34 commits into from

Conversation

CoderZhi
Copy link
Collaborator

Create struct Patch to store patch data for staking protocol.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

saitofun and others added 30 commits July 18, 2022 17:36
* [consensus] remove config.EVMNetworkID()
Co-authored-by: dustinxie <dahuaxie@gmail.com>
Co-authored-by: dustinxie <dahuaxie@gmail.com>
Co-authored-by: Haaai <55118568+Liuhaai@users.noreply.github.com>
Co-authored-by: huofei <68298506@qq.com>
* fix variadic interface bug

* replace errorFormat with errorMessage
* delete config.Config in factory
* producerPrivKey load from vault

* add secret nil judge

* review changes

* add comment

* review change,  add unit test

* add comment

* add http close

* fix code smell

* test ci

* test ci

* upgeade vault version

* fix unit test, drop vault depends

* add more unit test

* fix code smell

* fix code review

* add privatekey method

* add private key method, change unit test

* use gomock

* use hashiCorpVault string in case
Co-authored-by: Raullen Chai <raullenchai@gmail.com>
Co-authored-by: Raullen Chai <raullenchai@gmail.com>
* tracer web3.js API

* fix test
@CoderZhi CoderZhi requested a review from a team as a code owner October 10, 2022 08:28
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

No Coverage information No Coverage information
5.0% 5.0% Duplication

@dustinxie
Copy link
Member

this code has been integrated into (#3661), so close it

@dustinxie dustinxie closed this Oct 14, 2022
@CoderZhi CoderZhi deleted the 1.8.4-patch-db branch January 27, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants