refactor(registry): use aqua:skaji/relocatable-perl for perl #3716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scop
commented
Dec 19, 2024
| @@ -1220,7 +1220,7 @@ pdm.backends = ["pipx:pdm", "asdf:1oglop1/asdf-pdm"] | |||
| pdm.test = ["pdm --version", "PDM, version {{version}}"] | |||
| peco.backends = ["aqua:peco/peco", "asdf:asdf-community/asdf-peco"] | |||
| periphery.backends = ["asdf:MontakOleg/asdf-periphery"] | |||
| perl.backends = ["asdf:ouest/asdf-perl"] | |||
| perl.backends = ["aqua:skaji/relocatable-perl", "asdf:ouest/asdf-perl"] | |||
There was a problem hiding this comment.
relocatable-perls are available for Linux and macOS only. I wonder if that's a problem re this entry?
There was a problem hiding this comment.
No because asdf plugins don't work on windows anyways
scop
commented
Dec 19, 2024
| @@ -1220,7 +1220,7 @@ pdm.backends = ["pipx:pdm", "asdf:1oglop1/asdf-pdm"] | |||
| pdm.test = ["pdm --version", "PDM, version {{version}}"] | |||
| peco.backends = ["aqua:peco/peco", "asdf:asdf-community/asdf-peco"] | |||
| periphery.backends = ["asdf:MontakOleg/asdf-periphery"] | |||
| perl.backends = ["asdf:ouest/asdf-perl"] | |||
| perl.backends = ["aqua:skaji/relocatable-perl", "asdf:ouest/asdf-perl"] | |||
There was a problem hiding this comment.
I did not add a perl.test, because I'm not sure how to match e.g. the perl --version output for those relocatable perls for their "package" versions, for example 5.40.0.1 contains
This is perl 5, version 40, subversion 0 (v5.40.0) built for x86_64-linux
(The .1 is missing from the output)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.