Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test training client get job pods #2174

Conversation

YosiElias
Copy link
Contributor

@YosiElias YosiElias commented Jul 18, 2024

What this PR does / why we need it:
New unit test for get_job_pods function

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #2161

Checklist:

  • Docs included if any changes are user facing

andreyvelich and others added 8 commits July 18, 2024 13:05
* Update release document

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Add twine command

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Explain image publishing

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Add link to the overlays

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Fix format

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

* Fix git push command

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>

---------

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: yelias <yossi.elias@nokia.com>
Signed-off-by: yelias <yossi.elias@nokia.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: yelias <yossi.elias@nokia.com>
Kubeflow Enhancement Proposal: Integrate JAX with Kubeflow Training Operator

Signed-off-by: Sandipan Panda <samparksandipan@gmail.com>
Signed-off-by: yelias <yossi.elias@nokia.com>
Signed-off-by: Sandipan Panda <samparksandipan@gmail.com>
Signed-off-by: yelias <yossi.elias@nokia.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: yelias <yossi.elias@nokia.com>
Signed-off-by: yelias <yossi.elias@nokia.com>
@YosiElias YosiElias force-pushed the unit-test-TrainingClient-get_job_pods branch from 6ee09cd to b826be5 Compare July 18, 2024 10:12
@google-oss-prow google-oss-prow bot added size/XL and removed size/L labels Jul 18, 2024
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jinchihe for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot added size/L and removed size/XL labels Jul 18, 2024
@YosiElias YosiElias closed this Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SDK] Add more unit tests for TrainingClient APIs
3 participants