Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃 this release v0.1.10 #307

Merged
merged 25 commits into from
Jan 24, 2019

Conversation

droot
Copy link
Contributor

@droot droot commented Jan 24, 2019

🏃 this release v0.1.10

Shawn Hurley and others added 25 commits December 6, 2018 08:52
* Allow the user to specify in the options how to create the client,
cache, and how to construct the delegating client.

fixes kubernetes-sigs#226
✨ Allow user to define how create managed objects
- Rename Builder functions
- Encourage providing the manager to the Builder factory
- Deprecate discouraged functions
- Add alias.go with short cuts for common functions to reduce import line bloat
- Fix issue with GetConfigOrDie not exiting
- Update examples
- Add example at package root
Signed-off-by: ichekrygin <illya.chekrygin@gmail.com>
…nnotator is required to implement both inject.Client and inject.Decoder interfaces
…ce-nil

🐛 fix `nil` error when using `BootstrapOptions.Host`
🐛 logging error when starting control plane failed
…ook-example

🐛 fix interface assertions in example/mutatingwebhook.go such that podA…
It's the general pattern to use ("%v", err) instead of ("%s",
err.Error()) when formatting errors.
This adds some logging to envtest, to make it easier to debug oddities
with a testing environment.
🐛 gen cert for the server even there are no webhooks
…test-err-style-tweak

✨ Fix up error reporting and logging in envtest
This exposes the client-go metrics (client, workqueue, reflector)
metrics in the controller-runtime registry.
This marks tests that have a "// TODO: write this" or similar as pending
tests, so that we can keep track of them.
The QueueLength metric is now a duplicate of the workqueue "depth"
metric, so it's no longer needed.
…ent-go-metrics

✨ Expose client-go metrics
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 24, 2019
@droot
Copy link
Contributor Author

droot commented Jan 24, 2019

/cc @shawn-hurley

@k8s-ci-robot
Copy link
Contributor

@droot: GitHub didn't allow me to request PR reviews from the following users: shawn-hurley.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @shawn-hurley

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mengqiy
Copy link
Member

mengqiy commented Jan 24, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2019
@mengqiy mengqiy added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2019
@mengqiy mengqiy added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 24, 2019
@mengqiy
Copy link
Member

mengqiy commented Jan 24, 2019

The bot seems not adding cncf-cla label automatically. All commit authors has signed the CNCF CLA when they committed to the master branch.
Manually add it.

@k8s-ci-robot k8s-ci-robot merged commit 12d9858 into kubernetes-sigs:release-0.1 Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants