🏃 fast forward release-0.2 branch #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Hoekstra <bhoekstra@google.com>
🐛 Remove unused disableWebhookConfigInstaller flag
🏃 fix various typos
Logging the whole CRD resource is incredibly verbose as it includes every description of every field in the OpenAPI schema.
While the concrete Options struct documents delegating behavior, and the main overview documents it as well, this adds a note to manager#GetClient that it may return a non-live client, just to avoid confusion.
…anager-client-docs 📖 Note on Manager#GetClient about delegating clients
- Currently validator interface supports create and update - Add support for delete as well, which could be a breaking change - Users need to implement ValidateDelete since interface is updated
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
When user tries to decode an object, it should always not be empty. This error gives people hints when they running into this kind of issues. e.g. kube-apiserver doesn't include the object in the admission review for deletion events.
✨ decoder now errors out when encountering an empty runtime.RawExtension
We now use https://golang.org/pkg/os/#TempDir to get the os specific temp dir. Otherwise, it won't work for Windows users.
⚠️ support delete validation in validator interface
These behave more-or-less like functional options, except that a given option can be applied to more than on option type, so we can deprecate the 3 different dryrunall variants. Things with arguments generally become type aliases, with the exception of MatchingField, which gets deprecated in favor of MatchFields (a type alias to fields.Set).
For field manager, update and create also support fieldmanager, so we allow using them there. For dryrun, it's also supported by delete, so we support setting it there.
🐛 stop using hardcoded temp dir
…tional-options-redux⚠️ Functional Options Redux
…ollerReference-error-message 🐛 fix grammer of error in SetControllerReference
🏃 Only log CRD name during installation
📖 Examples README
Fixes: kubernetes-sigs#317 - Currently there is no way to override MaxConcurrentReconciles using builder - Provide a method to override controller options - Another approach was to provide MaxConcurrentReconciles itself, but it isnt future proof incase additional options are added
implement `CollectionOptions` in `DeleteOptions` that allow to issue a `DeleteCollection` call under the hood add tests + examples Co-Authored-By: Aaron Clawson <Aaron.Clawson@gmail.com> Edited-By: Solly Ross (directxman12)
Signed-off-by: Vince Prignano <vincepri@vmware.com>
…llection ✨ Implement delete collection via delete options
🐛 Preserve GroupVersionKind during Update/Patch
Return controller from builder.Build to allow developers to use it after it's been created by the builder; e.g., to add watches dynamically from a reconciler. Remove deprecated SimpleController() and Builder.WithManager(). Signed-off-by: Andy Goldstein <goldsteina@vmware.com>
⚠️ Allow reconcilers to add watches dynamically
🐛 surface controller options when using builder
…ontext-to-admission-handler ✨ Pass HTTP request Context through to admission Webhook handlers
🏃 Properly check if binary exists
k8s-ci-robot
added
size/XXL
Replace SimpleController with ControllerManagedBy.
|
Need to pick #552 as well |
🐛 fix SimpleController in builder test
Done! PTAL |
droot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fast forward release-0.2 branch to HEAD.
Prepare for v0.2.0-beta.5 release.