Documentation for Ingress #6378

inercia · 2020-07-07T10:37:44Z

Documentation for Ingress

What type of PR is this?

/kind documentation

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

k8s-ci-robot · 2020-07-07T10:37:52Z

Hi @inercia. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

README.md

docs/ambassador.md

floryut · 2020-07-07T13:20:16Z

/ok-to-test

floryut · 2020-07-07T13:40:27Z

/lgtm

inercia · 2020-07-07T14:08:04Z

/assign ant31

README.md

LuckySB · 2020-07-07T15:25:02Z

@floryut sorry, but my link looks cooler ;)

floryut · 2020-07-07T19:08:42Z

/lgtm

inercia · 2020-07-10T08:34:02Z

These CI failures seem unrelated. Any way to retrigger CI @floryut ?

floryut · 2020-07-10T08:50:51Z

These CI failures seem unrelated. Any way to retrigger CI @floryut ?

Yes, done :)

inercia · 2020-07-10T16:24:38Z

@floryut @LuckySB it seems CI is green now 👍

README.md

Miouge1 · 2020-07-14T16:25:38Z

/approve

k8s-ci-robot · 2020-07-14T16:25:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inercia, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Miouge1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

oomichi

/cc @oomichi

oomichi · 2020-07-16T17:23:31Z

docs/ambassador.md

@@ -0,0 +1,32 @@
+


This file is the same as the existing README under ambassador as https://github.com/kubernetes-sigs/kubespray/blob/5e22574402d86a7087fb146fc6f7b32c8fa80088/roles/kubernetes-apps/ingress_controller/ambassador/README.md
Do we need to add this?

You are right, maybe I should improve this document with an example of how to use Ambassador...

oomichi · 2020-07-16T18:41:35Z

README.md

@@ -197,6 +198,12 @@ The choice is defined with the variable `kube_network_plugin`. There is also an
 option to leverage built-in cloud provider networking instead.
 See also [Network checker](docs/netcheck.md).

+## Ingress Plugins
+
+- [ambassador](docs/ambassador.md): the Ambassador Ingress Controller and API gateway.


I am wondering we can specify roles/kubernetes-apps/ingress_controller/ambassador/README.md instead of docs/ambassador.md

I think it would be better to either link to an improved documentation about Ambassador in the docs or the external docs in getambassador.io, but I don't think there are any links to READMEs in this file...

floryut · 2020-07-20T08:28:26Z

@inercia do you have any pending changes left to do ?

Signed-off-by: Alvaro Saurin <alvaro.saurin@gmail.com>

inercia · 2020-07-20T08:50:21Z

@inercia do you have any pending changes left to do ?

@floryut I'm done. I have included a very simple example of how to use an Ingress once AMbassador is installed in the documentation.

floryut · 2020-07-29T13:51:58Z

/lgtm

inercia · 2020-07-29T14:21:51Z

Thanks, @floryut @EppO @oomichi @Miouge1, for your time

* 'master' of https://github.com/kubernetes-sigs/kubespray: Documentation for Ingress (kubernetes-sigs#6378) Fix ansible-lint E301 for commands fetching data (kubernetes-sigs#6465) Fix shellcheck url (kubernetes-sigs#6462) Fix ansible-lint E305 (kubernetes-sigs#6459) Fix ansible-lint E404 (kubernetes-sigs#6417) Update README.md and openstack.md (kubernetes-sigs#6455) Add noqa and disable .ansible-lint global exclusions (kubernetes-sigs#6410) Move healthz check to secure ports (kubernetes-sigs#6446) Update multus version & crio conf (kubernetes-sigs#6444) Fix remove etcd broken with etcdctl_api 3 (kubernetes-sigs#6448) update cinder csi manifests (kubernetes-sigs#6434) Update docker package to 19.03.12 (kubernetes-sigs#6439) * add proxy_env definition to remove_node.yml resolving kubernetes-sigs#6430 (kubernetes-sigs#6431)

Signed-off-by: Alvaro Saurin <alvaro.saurin@gmail.com>

k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 7, 2020

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 7, 2020

k8s-ci-robot requested review from EppO and floryut July 7, 2020 10:37

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 7, 2020

floryut reviewed Jul 7, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

floryut reviewed Jul 7, 2020

View reviewed changes

docs/ambassador.md Outdated Show resolved Hide resolved

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 7, 2020

inercia force-pushed the inercia/ingress_docs branch 2 times, most recently from 1555dd8 to aa3622f Compare July 7, 2020 13:39

inercia requested a review from floryut July 7, 2020 13:40

k8s-ci-robot assigned floryut Jul 7, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2020

k8s-ci-robot assigned ant31 Jul 7, 2020

LuckySB reviewed Jul 7, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

LuckySB reviewed Jul 7, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

inercia force-pushed the inercia/ingress_docs branch from aa3622f to c2ed299 Compare July 7, 2020 15:31

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2020

inercia requested a review from LuckySB July 7, 2020 15:31

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2020

Miouge1 suggested changes Jul 13, 2020

View reviewed changes

README.md Outdated Show resolved Hide resolved

inercia force-pushed the inercia/ingress_docs branch from c2ed299 to 6322230 Compare July 14, 2020 08:20

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2020

inercia requested a review from Miouge1 July 14, 2020 08:21

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2020

oomichi reviewed Jul 16, 2020

View reviewed changes

k8s-ci-robot requested a review from oomichi July 16, 2020 17:23

oomichi reviewed Jul 16, 2020

View reviewed changes

EppO approved these changes Jul 16, 2020

View reviewed changes

inercia force-pushed the inercia/ingress_docs branch from 6322230 to bd92747 Compare July 17, 2020 16:22

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 17, 2020

Documentation for Ingress

45442f9

Signed-off-by: Alvaro Saurin <alvaro.saurin@gmail.com>

inercia force-pushed the inercia/ingress_docs branch from bd92747 to 45442f9 Compare July 20, 2020 08:48

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 20, 2020

inercia requested review from EppO and oomichi July 23, 2020 14:54

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2020

k8s-ci-robot merged commit 0fa5a25 into kubernetes-sigs:master Jul 29, 2020

inercia deleted the inercia/ingress_docs branch July 29, 2020 14:22

LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Sep 17, 2020

Documentation for Ingress (kubernetes-sigs#6378)

08bba2c

Signed-off-by: Alvaro Saurin <alvaro.saurin@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Documentation for Ingress #6378

Documentation for Ingress #6378

inercia commented Jul 7, 2020

k8s-ci-robot commented Jul 7, 2020

floryut commented Jul 7, 2020

floryut commented Jul 7, 2020

inercia commented Jul 7, 2020

LuckySB commented Jul 7, 2020

floryut commented Jul 7, 2020

inercia commented Jul 10, 2020

floryut commented Jul 10, 2020

inercia commented Jul 10, 2020

Miouge1 commented Jul 14, 2020

k8s-ci-robot commented Jul 14, 2020

oomichi left a comment

oomichi Jul 16, 2020

inercia Jul 16, 2020

oomichi Jul 16, 2020

inercia Jul 17, 2020

floryut commented Jul 20, 2020

inercia commented Jul 20, 2020

floryut commented Jul 29, 2020

inercia commented Jul 29, 2020

Documentation for Ingress #6378

Documentation for Ingress #6378

Conversation

inercia commented Jul 7, 2020

k8s-ci-robot commented Jul 7, 2020

floryut commented Jul 7, 2020

floryut commented Jul 7, 2020

inercia commented Jul 7, 2020

LuckySB commented Jul 7, 2020

floryut commented Jul 7, 2020

inercia commented Jul 10, 2020

floryut commented Jul 10, 2020

inercia commented Jul 10, 2020

Miouge1 commented Jul 14, 2020

k8s-ci-robot commented Jul 14, 2020

oomichi left a comment

Choose a reason for hiding this comment

oomichi Jul 16, 2020

Choose a reason for hiding this comment

inercia Jul 16, 2020

Choose a reason for hiding this comment

oomichi Jul 16, 2020

Choose a reason for hiding this comment

inercia Jul 17, 2020

Choose a reason for hiding this comment

floryut commented Jul 20, 2020

inercia commented Jul 20, 2020

floryut commented Jul 29, 2020

inercia commented Jul 29, 2020