Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix remove etcd broken with etcdctl_api 3 #6448

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Fix remove etcd broken with etcdctl_api 3 #6448

merged 1 commit into from
Jul 27, 2020

Conversation

floryut
Copy link
Member

@floryut floryut commented Jul 24, 2020 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
Remove etcd member doesn't work since etcd 3.4 update (etcdctl api 3)

Which issue(s) this PR fixes:
Fixes #6445

Special notes for your reviewer:
The etcdcl member list now output

35ee157a644a984s, started, etcd3, https://172.30.72.65.2380, https://172.30.72.65:2379, false
ae329sdx899sda580, started, etcd1, https://172.30.72.64.2380, https://172.30.72.64:2379, false
48679550c06ad4xw16, started, etcd2, https://172.30.72.63.2380, https://172.30.72.63:2379, false

The cut now needs to be on , (to get the member ID)

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 24, 2020
@k8s-ci-robot k8s-ci-robot requested review from bozzo and EppO July 24, 2020 08:06
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 24, 2020
@EppO
Copy link
Contributor

EppO commented Jul 24, 2020

surprising CI didn't catch that on the etcd APIv3 PR... don't we use that playbook on the quorum CI tests?

@EppO
Copy link
Contributor

EppO commented Jul 24, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2020
@floryut
Copy link
Member Author

floryut commented Jul 24, 2020

surprising CI didn't catch that on the etcd APIv3 PR... don't we use that playbook on the quorum CI tests?

No we are using the recover playbook that also remove etcd but in a different play.. :D

@Miouge1
Copy link
Contributor

Miouge1 commented Jul 27, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Jul 27, 2020

@EppO I don't think CI runs the remove node playbook?

@k8s-ci-robot k8s-ci-robot merged commit d8a197c into kubernetes-sigs:master Jul 27, 2020
@floryut
Copy link
Member Author

floryut commented Jul 27, 2020 •
edited
Loading

@EppO I don't think CI runs the remove node playbook?

Yes, the remove etcd member used is this one : https://github.com/kubernetes-sigs/kubespray/blob/master/roles/recover_control_plane/etcd/tasks/main.yml#L77

erulabs added a commit to kubesail/kubespray that referenced this pull request Jul 29, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
9a7dcdc 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  Documentation for Ingress (kubernetes-sigs#6378)
  Fix ansible-lint E301 for commands fetching data (kubernetes-sigs#6465)
  Fix shellcheck url (kubernetes-sigs#6462)
  Fix ansible-lint E305 (kubernetes-sigs#6459)
  Fix ansible-lint E404 (kubernetes-sigs#6417)
  Update README.md and openstack.md (kubernetes-sigs#6455)
  Add noqa and disable .ansible-lint global exclusions (kubernetes-sigs#6410)
  Move healthz check to secure ports (kubernetes-sigs#6446)
  Update multus version & crio conf (kubernetes-sigs#6444)
  Fix remove etcd broken with etcdctl_api 3 (kubernetes-sigs#6448)
  update cinder csi manifests (kubernetes-sigs#6434)
  Update docker package to 19.03.12 (kubernetes-sigs#6439)
  * add proxy_env definition to remove_node.yml resolving kubernetes-sigs#6430 (kubernetes-sigs#6431)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Sep 17, 2020
@floryut @LuckySB
Fix remove etcd broken with etcdctl_api 3 (kubernetes-sigs#6448)
5524bd8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bozzo bozzo Awaiting requested review from bozzo

@EppO EppO Awaiting requested review from EppO

Assignees

@EppO EppO

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove master-node(w/ etcd-cluster) not work w/ remove-node.yml
4 participants
@floryut @EppO @Miouge1 @k8s-ci-robot