Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shellcheck url #6462

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Fix shellcheck url #6462

merged 1 commit into from
Jul 28, 2020

Conversation

vrlo
Copy link
Contributor

@vrlo vrlo commented Jul 28, 2020

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
Updates shellcheck release download url. The old url doesn't work anymore.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 28, 2020
@k8s-ci-robot k8s-ci-robot requested review from floryut and holmsten July 28, 2020 07:53
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 28, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @vrlo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 28, 2020
@floryut
Copy link
Member

floryut commented Jul 28, 2020

Indeed I saw your pipeline failing because of that :/
/lgtm
/ok-to-test

This need to be fasttracked to master, @Miouge1

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 28, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2020
@Miouge1
Copy link
Contributor

Miouge1 commented Jul 28, 2020

/approve

We probably need to backport as well?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, vrlo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@vrlo
Copy link
Contributor Author

vrlo commented Jul 28, 2020

I can create PRs for releases. 2.12 and 2.13?

@floryut
Copy link
Member

floryut commented Jul 28, 2020

/approve

We probably need to backport as well?

Agreed

I can create PRs for releases. 2.12 and 2.13?

Please do if you can :)

This was referenced Jul 28, 2020
Merged
Merged
@vrlo
Copy link
Contributor Author

vrlo commented Jul 28, 2020

/retest

@vrlo
Copy link
Contributor Author

vrlo commented Jul 28, 2020

Could someone please restart the tests? There were some instance connection issues and it seems /retest doesn't work.

@floryut
Copy link
Member

floryut commented Jul 28, 2020

Could someone please restart the tests? There were some instance connection issues and it seems /retest doesn't work.

Yup don't worry I've done it, it's pending as lot of PR tests running.

And indeed /retest only work on prow jobs (only linting for now)

@k8s-ci-robot k8s-ci-robot merged commit 96a2b38 into kubernetes-sigs:master Jul 28, 2020
erulabs added a commit to kubesail/kubespray that referenced this pull request Jul 29, 2020
@erulabs
Merge branch 'master' of https://github.com/kubernetes-sigs/kubespray
9a7dcdc 
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  Documentation for Ingress (kubernetes-sigs#6378)
  Fix ansible-lint E301 for commands fetching data (kubernetes-sigs#6465)
  Fix shellcheck url (kubernetes-sigs#6462)
  Fix ansible-lint E305 (kubernetes-sigs#6459)
  Fix ansible-lint E404 (kubernetes-sigs#6417)
  Update README.md and openstack.md (kubernetes-sigs#6455)
  Add noqa and disable .ansible-lint global exclusions (kubernetes-sigs#6410)
  Move healthz check to secure ports (kubernetes-sigs#6446)
  Update multus version & crio conf (kubernetes-sigs#6444)
  Fix remove etcd broken with etcdctl_api 3 (kubernetes-sigs#6448)
  update cinder csi manifests (kubernetes-sigs#6434)
  Update docker package to 19.03.12 (kubernetes-sigs#6439)
  * add proxy_env definition to remove_node.yml resolving kubernetes-sigs#6430 (kubernetes-sigs#6431)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Sep 17, 2020
@vrlo @LuckySB
Fix shellcheck url (kubernetes-sigs#6462)
6824d23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut Awaiting requested review from floryut

@holmsten holmsten Awaiting requested review from holmsten

Assignees

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vrlo @k8s-ci-robot @floryut @Miouge1