-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 6430: add proxy_env definition to remove_node.yml #6431
Fix Issue 6430: add proxy_env definition to remove_node.yml #6431
Conversation
Welcome @nniehoff! |
Hi @nniehoff. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @ant31 |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miouge1, nniehoff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
* 'master' of https://github.com/kubernetes-sigs/kubespray: Documentation for Ingress (kubernetes-sigs#6378) Fix ansible-lint E301 for commands fetching data (kubernetes-sigs#6465) Fix shellcheck url (kubernetes-sigs#6462) Fix ansible-lint E305 (kubernetes-sigs#6459) Fix ansible-lint E404 (kubernetes-sigs#6417) Update README.md and openstack.md (kubernetes-sigs#6455) Add noqa and disable .ansible-lint global exclusions (kubernetes-sigs#6410) Move healthz check to secure ports (kubernetes-sigs#6446) Update multus version & crio conf (kubernetes-sigs#6444) Fix remove etcd broken with etcdctl_api 3 (kubernetes-sigs#6448) update cinder csi manifests (kubernetes-sigs#6434) Update docker package to 19.03.12 (kubernetes-sigs#6439) * add proxy_env definition to remove_node.yml resolving kubernetes-sigs#6430 (kubernetes-sigs#6431)
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes issue #6430 where proxy_env is missing from remove_node.yml
Which issue(s) this PR fixes:
Fixes #6430
Special notes for your reviewer:
Does this PR introduce a user-facing change?: