fix: patch additions honor source key style #5005
Conversation
When a patch appends a new node, it should honor the key style from the patch. Prior to this commit, no style was applied, leading to problems when the key value could be interpreted as a different type based on its content. For example, "9110" needs quoting to ensure it is seen as a string in yaml.
k8s-ci-robot
added
cncf-cla: yes
|
Hi @ephesused. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/L
…al-releases Warn against partial releases
* Localize HelmChartInflationGenerator * Add explicit inline generators test
…ze-dst Expose path to `localize` destination
* Remove go module ci job * Add script that runs go mod tidy with replace statements * Invoke one script from the makefile and pass in the command to run in the pinned context --------- Co-authored-by: Anna Song <annasong@google.com>
make TestResourcesRepoNotFile even less specific
* Add localize command handle * Align to kustomize command conventions * Print success msg
* support for more helm template args * move templateArgs and unit tests to api/types * undo package name change * use our own simple helm chart instead of forking one * add argument to AsHelmArgs * code review * lint errors
* Update Versioning to Improve Output * Always get commit from build info, always get date and version from ldflag * Just replace broken main output with semver and deprecate short flag as is --------- Co-authored-by: Katrina Verey <katrina.verey@shopify.com>
Allow authenticated Github use in changelog script and improve error messages
…authed Don't have empty string when no auth info
Update kyaml to v0.14.0
Apologies; I have not. I'll make a concerted effort to get back to it in the next week. |
…anup release cleanup
* fix examples?springboot with no kustomization.yaml * fix examples/loadHttp with legacy patch syntax
|
Apologies, I'm not going to get to it this week. We had a number of high priority issues come through, and I haven't had the time. I will try to address this one next week. |
…tomization_is_empty add check that kustomization is empty
Update gnostic dependency with gnostic-models
kubernetes-sigs#5170) * change: components apply after all generator and transformer applied * fix name for a test case * add comment about when the components will be executed * components are applied before transformer
|
Hi @ephesused, thank you for your work 🙏 |
|
After a very busy few weeks, things are clearing up. I will make progress on this PR tomorrow. |
…_path_match be error when no path matching
Bump to go 1.20
…ainers add Anna to maintainers
When a patch appends a new node, it should honor the key style from the patch. Prior to this commit, no style was applied, leading to problems when the key value could be interpreted as a different type based on its content. For example, "9110" needs quoting to ensure it is seen as a string in yaml.
…omize into issue4928-2
|
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ephesused The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XXL
|
Whoops - I mistakenly mismanaged my branch. Apologies. If it's simpler, I can abandon this PR and open a clean one. Edited to add: Yes, I think that's what I'm going to do. Sorry for the hassle. |
|
This PR is superseded by #5196. Sorry for the trouble. |
When a patch appends a new node, it should honor the key style from the patch. Prior to this commit, no style was applied, leading to problems when the key value could be interpreted as a different type based on its content. For example, "9110" needs quoting to ensure it is seen as a string in yaml.
Fixes #4928