Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add within group clause support for aggregate function builder #1024

Merged
merged 12 commits into from
Jan 9, 2025
Merged

Add within group clause support for aggregate function builder #1024

merged 12 commits into from
Jan 9, 2025

Conversation

ivashog
Copy link
Contributor

@ivashog ivashog commented Jun 5, 2024 •
edited by igalklebanov
Loading

closes #781

@vercel Vercel
Copy link

vercel bot commented Jun 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2025 10:19am

@ivashog ivashog changed the title Add within group clause support for aggregate functions Add within group clause support for aggregate function builder Jun 5, 2024
@ivashog
Copy link
Contributor Author

ivashog commented Jun 5, 2024

@igalklebanov, I want to consult about the API of the future within group () functionality.
I see the following possible varaints:

  1. Extended - fn.agg('mode').withinGroup(wg => wg.orderBy('field')):
    + : looks like SQL
    - : too verbose; need to create separate WithingGroupBuilder
  2. Simplified - fn.agg('mode').withinGroup('field'), because within group () use only order by expression
  3. Also I can try to implement both variants in one method

@igalklebanov igalklebanov added enhancement New feature or request postgres Related to PostgreSQL api Related to library's API mssql Related to MS SQL Server (MSSQL) oracle Related to Oracle labels Jun 10, 2024
@igalklebanov
Copy link
Member

igalklebanov commented Jun 10, 2024 •
edited
Loading

@igalklebanov, I want to consult about the API of the future within group () functionality. I see the following possible varaints:

  1. Extended - fn.agg('mode').withinGroup(wg => wg.orderBy('field')):
    + : looks like SQL
    - : too verbose; need to create separate WithingGroupBuilder
  2. Simplified - fn.agg('mode').withinGroup('field'), because within group () use only order by expression
  3. Also I can try to implement both variants in one method

Hey 👋

We had a similar situation with filter (where ...). All current SQL specs only support where clause there, so we decided, for simplicity, to just go with filterWhere(...).

So I'd go with withinGroupOrderBy(...) for now. WDYT?

@ivashog
Copy link
Contributor Author

ivashog commented Jun 10, 2024

Hey 👋

We had a similar situation with filter (where ...). All current SQL specs only support where clause there, so we decided, for simplicity, to just go with filterWhere(...).

So I'd go with withinGroupOrderBy(...) for now. WDYT?

OK! We think in the same direction)

c81d766#diff-0e4fd806a08c99c93c0331a3d0e75d4c726e4face483d2e21a9febe03e944593R167

@igalklebanov igalklebanov changed the base branch from master to v0.28 January 9, 2025 09:01
Dev K0te added 9 commits January 9, 2025 11:10
@igalklebanov
test(node): add aggregate function orderBy clause node platform test
7a27692 
kysely-org#780
@igalklebanov
test(typings): add aggregate function orderBy clause typings test
395b8a0 
kysely-org#780
@igalklebanov
test(node): add separate test for order-sensitive aggregate functions…
1c51617 
… including mysql and sqlite

kysely-org#780
@igalklebanov
test(typings): removed unnecessary typings test
d310d17 
kysely-org#780
@igalklebanov
feat(operation-node): add within group to aggregate function node
2089707 
kysely-org#781
@igalklebanov
feat(query-builder): add withinGroupOrderBy method to aggregate funct…
69e5110 
…ion builder

kysely-org#781
@igalklebanov
feat(query-compiler): add within group processing to default query co…
1d39756 
…mpiler

kysely-org#781
@igalklebanov
fix(operation-node): fix operation node transformer for withinGroup c…
ce4275f 
…lause

kysely-org#781
@igalklebanov
test(node): add separate order-sensitive aggregate functions test cas…
251241c 
…e for withinGroup clause

kysely-org#781
@igalklebanov igalklebanov force-pushed the 781-add-within-group-support-to-aggregate branch from f749602 to 251241c Compare January 9, 2025 09:18
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 9, 2025 •
edited
Loading

Open in Stackblitz • kysely_koa_example

npm i https://pkg.pr.new/kysely-org/kysely@1024

commit: 680df4f

@igalklebanov @ivashog
fix jsdocs.
8f83aee 
Co-authored-by: Ivashkin Olexiy <32811685+ivashog@users.noreply.github.com>
@igalklebanov @ivashog
remove excessive cloneWith.
db975c9 
Co-authored-by: Ivashkin Olexiy <32811685+ivashog@users.noreply.github.com>
@igalklebanov @ivashog
simplify unit test.
680df4f 
Co-authored-by: Ivashkin Olexiy <32811685+ivashog@users.noreply.github.com>
@igalklebanov igalklebanov merged commit 4b73283 into kysely-org:v0.28 Jan 9, 2025
24 checks passed
@igalklebanov
Copy link
Member

Hey 👋

Pushed this through the finish line. It was very good so not a lot of changes - just some minor simplifications. 💪

@igalklebanov igalklebanov self-assigned this Jan 9, 2025
igalklebanov added a commit that referenced this pull request Jan 9, 2025
@ivashog @igalklebanov
Add within group clause support for aggregate function builder (#1024)
a619971 
Co-authored-by: Ivashkin Olexiy <32811685+ivashog@users.noreply.github.com>
Co-authored-by: Dev K0te <dev.k0te42@gmail.com>
Co-authored-by: igalklebanov <igalklebanov@gmail.com>
igalklebanov added a commit that referenced this pull request Jan 11, 2025
@ivashog @igalklebanov
Add within group clause support for aggregate function builder (#1024)
abb7e08 
Co-authored-by: Ivashkin Olexiy <32811685+ivashog@users.noreply.github.com>
Co-authored-by: Dev K0te <dev.k0te42@gmail.com>
Co-authored-by: igalklebanov <igalklebanov@gmail.com>
igalklebanov added a commit that referenced this pull request Jan 12, 2025
@ivashog @igalklebanov
Add within group clause support for aggregate function builder (#1024)
2fd8b72 
Co-authored-by: Ivashkin Olexiy <32811685+ivashog@users.noreply.github.com>
Co-authored-by: Dev K0te <dev.k0te42@gmail.com>
Co-authored-by: igalklebanov <igalklebanov@gmail.com>
igalklebanov added a commit that referenced this pull request Jan 17, 2025
@ivashog @igalklebanov
Add within group clause support for aggregate function builder (#1024)
6a2df83 
Co-authored-by: Ivashkin Olexiy <32811685+ivashog@users.noreply.github.com>
Co-authored-by: Dev K0te <dev.k0te42@gmail.com>
Co-authored-by: igalklebanov <igalklebanov@gmail.com>
igalklebanov added a commit that referenced this pull request Jan 19, 2025
@ivashog @igalklebanov
Add within group clause support for aggregate function builder (#1024)
2f7d7d1 
Co-authored-by: Ivashkin Olexiy <32811685+ivashog@users.noreply.github.com>
Co-authored-by: Dev K0te <dev.k0te42@gmail.com>
Co-authored-by: igalklebanov <igalklebanov@gmail.com>
@igalklebanov igalklebanov mentioned this pull request Feb 2, 2025
Open
igalklebanov added a commit that referenced this pull request Feb 8, 2025
@ivashog @igalklebanov
Add within group clause support for aggregate function builder (#1024)
8a72624 
Co-authored-by: Ivashkin Olexiy <32811685+ivashog@users.noreply.github.com>
Co-authored-by: Dev K0te <dev.k0te42@gmail.com>
Co-authored-by: igalklebanov <igalklebanov@gmail.com>
igalklebanov added a commit that referenced this pull request Feb 9, 2025
@ivashog @igalklebanov
Add within group clause support for aggregate function builder (#1024)
6e94c15 
Co-authored-by: Ivashkin Olexiy <32811685+ivashog@users.noreply.github.com>
Co-authored-by: Dev K0te <dev.k0te42@gmail.com>
Co-authored-by: igalklebanov <igalklebanov@gmail.com>
igalklebanov added a commit that referenced this pull request Feb 18, 2025
@ivashog @igalklebanov
Add within group clause support for aggregate function builder (#1024)
8f8e83c 
Co-authored-by: Ivashkin Olexiy <32811685+ivashog@users.noreply.github.com>
Co-authored-by: Dev K0te <dev.k0te42@gmail.com>
Co-authored-by: igalklebanov <igalklebanov@gmail.com>
lucianolix added a commit to lucianolix/kysely that referenced this pull request Feb 21, 2025
@lucianolix
Squashed commit of the following:
c7ac34f 
commit 04040e3
Author: lucianolix <lucianopinedo@gmail.com>
Date:   Fri Feb 21 02:15:50 2025 -0400

    whitespace diff trigger

commit af9718d
Author: lucianolix <lucianopinedo@gmail.com>
Date:   Fri Feb 21 02:14:58 2025 -0400

    remove unnecessary file change

commit 883a0c2
Merge: 36f8a1d 45b71e2
Author: lucianolix <lucianopinedo@gmail.com>
Date:   Fri Feb 21 02:10:34 2025 -0400

    XMerge branch 'v0.28' into alter-type-builder

commit 45b71e2
Merge: 107076a 0497525
Author: lucianolix <33232807+lucianolix@users.noreply.github.com>
Date:   Fri Feb 21 02:09:24 2025 -0400

    Merge branch 'kysely-org:v0.28' into v0.28

commit 36f8a1d
Author: lucianolix <lucianopinedo@gmail.com>
Date:   Thu Feb 20 20:41:07 2025 -0400

    run prettier

commit ae5ddc2
Author: lucianolix <lucianopinedo@gmail.com>
Date:   Thu Feb 20 20:37:01 2025 -0400

    remove ;

commit 31eea41
Author: lucianolix <lucianopinedo@gmail.com>
Date:   Thu Feb 20 18:53:28 2025 -0400

    change remaining wrong identifierNodes to valueNodes, test fixes

commit f007de7
Author: lucianolix <lucianopinedo@gmail.com>
Date:   Thu Feb 20 18:33:22 2025 -0400

    Swap IdentifierNodes for ValueNodes

commit e658a82
Author: lucianolix <lucianopinedo@gmail.com>
Date:   Thu Feb 20 17:13:14 2025 -0400

    remove unused import, typing tests

commit 2cb3935
Author: lucianolix <lucianopinedo@gmail.com>
Date:   Thu Feb 20 03:03:10 2025 -0400

    missing space on query compiler

commit b054013
Author: lucianolix <lucianopinedo@gmail.com>
Date:   Thu Feb 20 03:01:27 2025 -0400

    enforce mutual exclusivity between before and after

commit 933e2d0
Author: lucianolix <lucianopinedo@gmail.com>
Date:   Thu Feb 20 02:52:03 2025 -0400

    query compiler impl of add value

commit dedb9c2
Author: lucianolix <lucianopinedo@gmail.com>
Date:   Thu Feb 20 02:50:07 2025 -0400

    Docs, better examples, swapped addValue to callback pattern

commit e6826b4
Author: lucianolix <lucianopinedo@gmail.com>
Date:   Thu Feb 20 01:59:52 2025 -0400

    add docs to alter type builder

commit 62aa655
Author: lucianolix <lucianopinedo@gmail.com>
Date:   Thu Feb 20 01:48:59 2025 -0400

    add documentation for alterType func inside schema.ts

commit ccb5a9f
Author: lucianolix <lucianopinedo@gmail.com>
Date:   Wed Feb 19 03:31:00 2025 -0400

    WIP full api spec!

commit 0497525
Author: Martin Adámek <banan23@gmail.com>
Date:   Sun Feb 9 13:27:47 2025 +0100

    refactor: separate isolation level and access mode with a comma in MySQL (kysely-org#1350)

commit f32c231
Author: Martin Adámek <banan23@gmail.com>
Date:   Sun Feb 9 12:48:17 2025 +0100

    feat: Allow read-only transactions in Postgres and MySQL (kysely-org#1342)

    * feat: Allow read-only transactions in Postgres and MySQL

    Closes kysely-org#1341

    * use `accessMode` instead

    * add tests

    * access mode type and validation, rearranging stuff a bit.

    Co-authored-by: Martin Adámek <615580+B4nan@users.noreply.github.com>

    * rearranging stuff a bit.

    Co-authored-by: Martin Adámek <615580+B4nan@users.noreply.github.com>

    * align/simplify tests a bit

    Co-authored-by: Martin Adámek <615580+B4nan@users.noreply.github.com>

    ---------

    Co-authored-by: igalklebanov <igalklebanov@gmail.com>
    Co-authored-by: Martin Adámek <615580+B4nan@users.noreply.github.com>

commit 6467b77
Author: Alessio Napolitano <121714208+alenap93@users.noreply.github.com>
Date:   Sat Feb 8 23:59:59 2025 +0100

    feat: expands limit in select accepting null value (kysely-org#1347)

    * feat: expands limit in select accepting null value

    * explain in jsdocs, move test case.

    Co-authored-by: Alessio Napolitano <121714208+alenap93@users.noreply.github.com>

    ---------

    Co-authored-by: igalklebanov <igalklebanov@gmail.com>

commit 989bac2
Author: Reid Swan <reidswan@outlook.com>
Date:   Sat Feb 1 16:02:34 2025 +0200

    feat: Add disableTransactions option to Migrator (kysely-org#1335)

    Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>

commit 9918cc8
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Mon Jan 27 01:20:10 2025 +0200

    add `queryId` to `CompiledQuery` to allow async communication between more components. (kysely-org#176)

commit 8e1dc8e
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Sat Jan 25 23:36:48 2025 +0200

    revisiting `orderBy`. (kysely-org#1326)

commit bc0e2dd
Author: igalklebanov <igalklebanov@gmail.com>
Date:   Sat Jan 18 21:17:30 2025 +0200

    minor ci tweaks.

    ..

commit c1963b7
Author: igalklebanov <igalklebanov@gmail.com>
Date:   Sat Jan 18 20:43:31 2025 +0200

    improve join tests dialect coverage.

commit 1623b48
Author: igalklebanov <igalklebanov@gmail.com>
Date:   Sat Jan 18 20:00:36 2025 +0200

    dry up joins.

commit 92c7e44
Author: Ersin Akinci <5427394+ersinakinci@users.noreply.github.com>
Date:   Sat Jan 18 10:31:07 2025 -0700

    Add support for cross join and cross join lateral (kysely-org#1325)

    Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>

commit b61300c
Author: Simon Schick <simonsimcity@gmail.com>
Date:   Fri Jan 17 17:45:41 2025 +0100

    Support json_agg(column_ref) (kysely-org#1316)

    Co-authored-by: Simon Schick <392589+SimonSimCity@users.noreply.github.com>
    Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>

commit 92bd46d
Author: Drew Marshall <31295028+drew-marsh@users.noreply.github.com>
Date:   Sun Jan 12 09:05:16 2025 -0800

    Add outer and cross apply (mssql) (kysely-org#1074)

    Co-authored-by: Drew Marshall <31295028+drew-marsh@users.noreply.github.com>
    Co-authored-by: Drew Marshall <thedrewguy@gmail.como>
    Co-authored-by: igalklebanov <igalklebanov@gmail.com>

commit e99655f
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Sat Jan 11 14:08:17 2025 +0200

    add TypeScript benchmarks. (kysely-org#1314)

commit 8f8e83c
Author: Ivashkin Olexiy <32811685+ivashog@users.noreply.github.com>
Date:   Thu Jan 9 12:23:43 2025 +0200

    Add `within group` clause support for aggregate function builder (kysely-org#1024)

    Co-authored-by: Ivashkin Olexiy <32811685+ivashog@users.noreply.github.com>
    Co-authored-by: Dev K0te <dev.k0te42@gmail.com>
    Co-authored-by: igalklebanov <igalklebanov@gmail.com>

commit 37038c9
Author: vincentiusvin <54709710+vincentiusvin@users.noreply.github.com>
Date:   Mon Jan 6 09:08:36 2025 +0700

    SQLite's OR CONFLICT clause for inserts (kysely-org#976)

    Co-authored-by: vincentiusvin <54709710+vincentiusvin@users.noreply.github.com>
    Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>

commit 859ec4b
Author: Sam Clearman <sam@samclearman.com>
Date:   Sun Jan 5 14:55:18 2025 -0800

    Add `Date` as a valid return type for `max` and `min` (kysely-org#1062)

commit 5ee89a6
Author: igalklebanov <igalklebanov@gmail.com>
Date:   Sun Jan 5 13:58:29 2025 +0200

    feat: add HandleEmtpyInListsPlugin. (kysely-org#925)

    * feat: empty where in plugin

    * test: add new tests

    * chore: remove unneccesary typeguards

    * fix: change to binary operator node

    * test: update tests to do both in and not in

    * test: for having

    * chore: rm test

    * test: nullable tests

    * chore: nit

    * chore: condense suite

    * chore: db config override

    * chore: extra console log

    * chore: empty arr plugin docs

    * HandleEmptyInListsPlugin initial commit.

    Co-authored-by: Austin Woon Quan <43132101+austinwoon@users.noreply.github.com>

    ---------

    Co-authored-by: Austin Woon <austin@open.gov.sg>
    Co-authored-by: igalklebanov <igalklebanov@gmail.com>
    remove only.

commit 3978530
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Sun Dec 1 15:26:53 2024 +0100

    add `returning` support in `MERGE` queries. (kysely-org#1171)

commit 605307c
Author: igalklebanov <igalklebanov@gmail.com>
Date:   Sun Dec 1 09:57:21 2024 +0200

    fix jsdocs.

commit f8f3194
Author: igalklebanov <igalklebanov@gmail.com>
Date:   Sun Nov 24 02:41:15 2024 +0200

    fix package-lock.

commit a83b722
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Tue Nov 5 00:27:58 2024 +0200

    chore: enforce min TS version (kysely-org#1194)

commit 3ddfc1b
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Thu Oct 24 17:28:12 2024 +0300

    fix TS backwards compat following `ControlledTransaction`. (kysely-org#1193)

commit f83eb25
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Sat Oct 19 16:32:22 2024 +0300

    `await using kysely = new Kysely()` support. (kysely-org#1167)

commit 5a9d1bc
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Sat Oct 5 20:12:23 2024 +0300

    add `ControlledTransaction`. (kysely-org#962)

    Co-authored-by: Igal Klebanov <igal@grainfinance.co>

commit eacdc2e
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Sat Oct 5 18:55:29 2024 +0300

    ci: run 22.x

commit 7c81a39
Author: wirekang <wirekang@gmail.com>
Date:   Sun Sep 29 22:41:57 2024 +0900

    Remove preventAwait (kysely-org#1160)

    Related kysely-org#748

commit 8b8ccf7
Author: Dapper Mink <quentinjanuelkij@gmail.com>
Date:   Fri Aug 2 19:55:48 2024 +0900

    feat: support refresh materialized view (kysely-org#990)

    * feat: add postgres range types (kysely-org#1086)

    * feat: support refresh naterialized view

    * fix tests by adding .materialized() to remove the matview

    * fix failing test

    * fix: References typo (kysely-org#1092)

    * chore: refresh-view-node.ts => refresh-materialized-view-node.ts

    * chore: export node in index.ts

    ---------

    Co-authored-by: Isak <16906089+kansson@users.noreply.github.com>
    Co-authored-by: Jonathan Wu <jonathanwu70@gmail.com>

commit 5291044
Author: Sami Koskimäki <koskomi@gmail.com>
Date:   Mon Jul 22 15:18:49 2024 +0300

    add reusable helpers recipe and implement missing expression features (kysely-org#1085)

    * add reusable helpers recipe and implement missing expression features

    * force node 22.4.1 in CI because of an npm bug

commit 39978d1
Author: Sami Koskimäki <koskomi@gmail.com>
Date:   Fri Jul 19 12:34:50 2024 +0300

    Speedup types with huge databases. Fixes kysely-org#867 (kysely-org#1080)

commit d8f9401
Author: Sami Koskimäki <koskomi@gmail.com>
Date:   Sun Jul 14 14:59:58 2024 +0300

    Support update table1, table2, ... query support. Closes kysely-org#192 (kysely-org#1079)

commit 2854cac
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Sun Jul 7 23:02:15 2024 +0300

    `InferResult` should output plural. (kysely-org#1064)

commit 7738533
Author: lucianolix <lucianopinedo@gmail.com>
Date:   Tue Feb 18 01:47:15 2025 -0400

    WIP: boilerplate for alter type

commit ffc4058
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Sun Feb 16 22:43:26 2025 +0200

    docs: add Marvin's (Deno) quote. (kysely-org#1360)

    * Update quotes.ts

    * add avatar.

    * reddit icon.

commit 107076a
Author: Martin Adámek <banan23@gmail.com>
Date:   Sun Feb 9 13:27:47 2025 +0100

    refactor: separate isolation level and access mode with a comma in MySQL (kysely-org#1350)

commit f7b3d90
Author: Martin Adámek <banan23@gmail.com>
Date:   Sun Feb 9 12:48:17 2025 +0100

    feat: Allow read-only transactions in Postgres and MySQL (kysely-org#1342)

    * feat: Allow read-only transactions in Postgres and MySQL

    Closes kysely-org#1341

    * use `accessMode` instead

    * add tests

    * access mode type and validation, rearranging stuff a bit.

    Co-authored-by: Martin Adámek <615580+B4nan@users.noreply.github.com>

    * rearranging stuff a bit.

    Co-authored-by: Martin Adámek <615580+B4nan@users.noreply.github.com>

    * align/simplify tests a bit

    Co-authored-by: Martin Adámek <615580+B4nan@users.noreply.github.com>

    ---------

    Co-authored-by: igalklebanov <igalklebanov@gmail.com>
    Co-authored-by: Martin Adámek <615580+B4nan@users.noreply.github.com>

commit 5bfd7a9
Author: Alessio Napolitano <121714208+alenap93@users.noreply.github.com>
Date:   Sat Feb 8 23:59:59 2025 +0100

    feat: expands limit in select accepting null value (kysely-org#1347)

    * feat: expands limit in select accepting null value

    * explain in jsdocs, move test case.

    Co-authored-by: Alessio Napolitano <121714208+alenap93@users.noreply.github.com>

    ---------

    Co-authored-by: igalklebanov <igalklebanov@gmail.com>

commit fdbc74a
Author: Reid Swan <reidswan@outlook.com>
Date:   Sat Feb 1 16:02:34 2025 +0200

    feat: Add disableTransactions option to Migrator (kysely-org#1335)

    Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>

commit 1bd4e26
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Mon Jan 27 01:20:10 2025 +0200

    add `queryId` to `CompiledQuery` to allow async communication between more components. (kysely-org#176)

commit 25fe2d0
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Sat Jan 25 23:36:48 2025 +0200

    revisiting `orderBy`. (kysely-org#1326)

commit 22895c1
Author: igalklebanov <igalklebanov@gmail.com>
Date:   Sat Jan 18 21:17:30 2025 +0200

    minor ci tweaks.

    ..

commit 8b252b2
Author: igalklebanov <igalklebanov@gmail.com>
Date:   Sat Jan 18 20:43:31 2025 +0200

    improve join tests dialect coverage.

commit d306db7
Author: igalklebanov <igalklebanov@gmail.com>
Date:   Sat Jan 18 20:00:36 2025 +0200

    dry up joins.

commit 8bbbc69
Author: Ersin Akinci <5427394+ersinakinci@users.noreply.github.com>
Date:   Sat Jan 18 10:31:07 2025 -0700

    Add support for cross join and cross join lateral (kysely-org#1325)

    Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>

commit ac6934a
Author: Simon Schick <simonsimcity@gmail.com>
Date:   Fri Jan 17 17:45:41 2025 +0100

    Support json_agg(column_ref) (kysely-org#1316)

    Co-authored-by: Simon Schick <392589+SimonSimCity@users.noreply.github.com>
    Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>

commit b6a7dab
Author: Drew Marshall <31295028+drew-marsh@users.noreply.github.com>
Date:   Sun Jan 12 09:05:16 2025 -0800

    Add outer and cross apply (mssql) (kysely-org#1074)

    Co-authored-by: Drew Marshall <31295028+drew-marsh@users.noreply.github.com>
    Co-authored-by: Drew Marshall <thedrewguy@gmail.como>
    Co-authored-by: igalklebanov <igalklebanov@gmail.com>

commit a5686c6
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Sat Jan 11 14:08:17 2025 +0200

    add TypeScript benchmarks. (kysely-org#1314)

commit 6e94c15
Author: Ivashkin Olexiy <32811685+ivashog@users.noreply.github.com>
Date:   Thu Jan 9 12:23:43 2025 +0200

    Add `within group` clause support for aggregate function builder (kysely-org#1024)

    Co-authored-by: Ivashkin Olexiy <32811685+ivashog@users.noreply.github.com>
    Co-authored-by: Dev K0te <dev.k0te42@gmail.com>
    Co-authored-by: igalklebanov <igalklebanov@gmail.com>

commit 77be243
Author: vincentiusvin <54709710+vincentiusvin@users.noreply.github.com>
Date:   Mon Jan 6 09:08:36 2025 +0700

    SQLite's OR CONFLICT clause for inserts (kysely-org#976)

    Co-authored-by: vincentiusvin <54709710+vincentiusvin@users.noreply.github.com>
    Co-authored-by: Igal Klebanov <igalklebanov@gmail.com>

commit 5e4597c
Author: Sam Clearman <sam@samclearman.com>
Date:   Sun Jan 5 14:55:18 2025 -0800

    Add `Date` as a valid return type for `max` and `min` (kysely-org#1062)

commit 3b4d6e2
Author: igalklebanov <igalklebanov@gmail.com>
Date:   Sun Jan 5 13:58:29 2025 +0200

    feat: add HandleEmtpyInListsPlugin. (kysely-org#925)

    * feat: empty where in plugin

    * test: add new tests

    * chore: remove unneccesary typeguards

    * fix: change to binary operator node

    * test: update tests to do both in and not in

    * test: for having

    * chore: rm test

    * test: nullable tests

    * chore: nit

    * chore: condense suite

    * chore: db config override

    * chore: extra console log

    * chore: empty arr plugin docs

    * HandleEmptyInListsPlugin initial commit.

    Co-authored-by: Austin Woon Quan <43132101+austinwoon@users.noreply.github.com>

    ---------

    Co-authored-by: Austin Woon <austin@open.gov.sg>
    Co-authored-by: igalklebanov <igalklebanov@gmail.com>
    remove only.

commit c75bb45
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Sun Dec 1 15:26:53 2024 +0100

    add `returning` support in `MERGE` queries. (kysely-org#1171)

commit d53328e
Author: igalklebanov <igalklebanov@gmail.com>
Date:   Sun Dec 1 09:57:21 2024 +0200

    fix jsdocs.

commit e3e30e1
Author: igalklebanov <igalklebanov@gmail.com>
Date:   Sun Nov 24 02:41:15 2024 +0200

    fix package-lock.

commit 575b3f4
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Tue Nov 5 00:27:58 2024 +0200

    chore: enforce min TS version (kysely-org#1194)

commit ddc275f
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Thu Oct 24 17:28:12 2024 +0300

    fix TS backwards compat following `ControlledTransaction`. (kysely-org#1193)

commit cf7ddb9
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Sat Oct 19 16:32:22 2024 +0300

    `await using kysely = new Kysely()` support. (kysely-org#1167)

commit 0a28f87
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Sat Oct 5 20:12:23 2024 +0300

    add `ControlledTransaction`. (kysely-org#962)

    Co-authored-by: Igal Klebanov <igal@grainfinance.co>

commit ab11ce3
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Sat Oct 5 18:55:29 2024 +0300

    ci: run 22.x

commit 5b18e30
Author: wirekang <wirekang@gmail.com>
Date:   Sun Sep 29 22:41:57 2024 +0900

    Remove preventAwait (kysely-org#1160)

    Related kysely-org#748

commit b026a45
Author: Dapper Mink <quentinjanuelkij@gmail.com>
Date:   Fri Aug 2 19:55:48 2024 +0900

    feat: support refresh materialized view (kysely-org#990)

    * feat: add postgres range types (kysely-org#1086)

    * feat: support refresh naterialized view

    * fix tests by adding .materialized() to remove the matview

    * fix failing test

    * fix: References typo (kysely-org#1092)

    * chore: refresh-view-node.ts => refresh-materialized-view-node.ts

    * chore: export node in index.ts

    ---------

    Co-authored-by: Isak <16906089+kansson@users.noreply.github.com>
    Co-authored-by: Jonathan Wu <jonathanwu70@gmail.com>

commit a4671da
Author: Sami Koskimäki <koskomi@gmail.com>
Date:   Mon Jul 22 15:18:49 2024 +0300

    add reusable helpers recipe and implement missing expression features (kysely-org#1085)

    * add reusable helpers recipe and implement missing expression features

    * force node 22.4.1 in CI because of an npm bug

commit 56100e6
Author: Sami Koskimäki <koskomi@gmail.com>
Date:   Fri Jul 19 12:34:50 2024 +0300

    Speedup types with huge databases. Fixes kysely-org#867 (kysely-org#1080)

commit 73227d6
Author: Sami Koskimäki <koskomi@gmail.com>
Date:   Sun Jul 14 14:59:58 2024 +0300

    Support update table1, table2, ... query support. Closes kysely-org#192 (kysely-org#1079)

commit 6074e10
Author: Igal Klebanov <igalklebanov@gmail.com>
Date:   Sun Jul 7 23:02:15 2024 +0300

    `InferResult` should output plural. (kysely-org#1064)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalklebanov igalklebanov igalklebanov left review comments

Assignees

@igalklebanov igalklebanov

Labels
api Related to library's API enhancement New feature or request mssql Related to MS SQL Server (MSSQL) oracle Related to Oracle postgres Related to PostgreSQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add within group (order by ...) clause support for aggregate functions.
2 participants
@ivashog @igalklebanov