Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into lyft/master #42

Merged
merged 29 commits into from
Jun 19, 2019
Merged

Conversation

betodealmeida
Copy link

Merge latest Apache master into lyft-master to bring apache#7693.

dpgaspar and others added 29 commits June 6, 2019 22:15
* Add new escape characters to OnPasteSelect

* Add Unit Tests to onPasteSelect_spec

* Update new line to tab escape character

* Fix indentation in 2 cases
* Apply dashboardFilter to dashboards

* added missing comma
* Refactor db_engine_specs into package

* Rename bigquery class and add epoch funcs

* Fix flake8 errors

* Dynamically load all engine specs

* Fix linting errors and unit tests

* Implement Snowflake epoch time funcs

* Implement Teradata epoch time func

* Fix presto datasource query and remove unused import

* Fix broken datasource query

* Add mypy ignore for false positive

* Add missing license files

* Make create_time_grains_tuple public

* Fix flake8 quote

* Fix incorrect licence header
* Bump FAB to 2.1.0

* Bump FAB to 2.1.1

* Bump FAB to 2.1.2

* Test revert to 2.1.1

* again to 2.1.2

* Bump FAB to 2.1.4
Add Intercom in the list of organisations that use Superset.
* Use grid for wide tables

* WIP

* Fix CSS issues

* Add unit test

* Add constant

* Improve ref

* Remove wrong refs; no longer need extra height

* Revert number of columns
@betodealmeida betodealmeida requested a review from khtruong June 19, 2019 16:45
@codecov-io
Copy link

Codecov Report

Merging #42 into lyft-master will increase coverage by 0.22%.
The diff coverage is 70.68%.

Impacted file tree graph

@@              Coverage Diff               @@
##           lyft-master     #42      +/-   ##
==============================================
+ Coverage        64.58%   64.8%   +0.22%     
==============================================
  Files              444     468      +24     
  Lines            22261   22418     +157     
  Branches          2451    2467      +16     
==============================================
+ Hits             14378   14529     +151     
- Misses            7748    7754       +6     
  Partials           135     135
Impacted Files Coverage Δ
superset/models/sql_lab.py 94.73% <ø> (-0.2%) ⬇️
superset/data/tabbed_dashboard.py 34.37% <ø> (ø) ⬆️
...t/assets/src/dashboard/reducers/getInitialState.js 0% <ø> (ø) ⬆️
.../src/dashboard/components/gridComponents/Chart.jsx 70.88% <ø> (ø) ⬆️
...rset/assets/src/SqlLab/reducers/getInitialState.js 0% <ø> (ø) ⬆️
superset/assets/src/chart/Chart.jsx 10.86% <ø> (ø) ⬆️
superset/assets/src/chart/ChartRenderer.jsx 7.57% <ø> (ø) ⬆️
superset/assets/src/components/OnPasteSelect.jsx 88.09% <ø> (ø) ⬆️
superset/assets/src/SqlLab/App.jsx 0% <0%> (ø) ⬆️
superset/connectors/druid/views.py 67.74% <100%> (+1.52%) ⬆️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc86bd...8bf8e69. Read the comment docs.

@DiggidyDave
Copy link

Oooff... big merge. I guess we need to flush our pipeline so that we can bring these in more incrementally. We can still try to address the degraded metrics stuff.

@DiggidyDave
Copy link

👍

@betodealmeida
Copy link
Author

🚀

@betodealmeida betodealmeida merged commit 278ec54 into lyft-master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.