Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] sort, topk, bottomk fixes for instant queries #2792

Merged
merged 21 commits into from
Nov 5, 2020
Merged

Commits on Oct 15, 2020

  1. Configuration menu
    Copy the full SHA
    e488a3b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    054833f View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2020

  1. Configuration menu
    Copy the full SHA
    f6ed6e1 View commit details
    Browse the repository at this point in the history
  2. Changes after review.

    Small optimization in appendValuesInstant.
    soundvibe committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    690dcd3 View commit details
    Browse the repository at this point in the history
  3. fixed imports.

    made valueAndMeta struct package private.
    soundvibe committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    5c7cf65 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2020

  1. Optimized instant queries - now only single block will be created.

    OrderedFlush() now sorts the results instead popping them one by one.
    FloatHeap won't be created if it's not used.
    soundvibe committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    66746ac View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2020

  1. Configuration menu
    Copy the full SHA
    3d12b53 View commit details
    Browse the repository at this point in the history
  2. removed unused method

    soundvibe committed Oct 20, 2020
    Configuration menu
    Copy the full SHA
    d8a5cc9 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2020

  1. initial implementation

    soundvibe committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    a7496e1 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2020

  1. Fixes NaN issues with m3 queries for sort and topk/bottomk.

    FloatHeap now supports adding NaN values.
    Uncommented topk, bottomk and sort compatibility tests (now they pass).
    soundvibe committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    39eb746 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4d2b567 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Changes after code review.

    soundvibe committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    2f72c61 View commit details
    Browse the repository at this point in the history
  2. Small cleanup.

    soundvibe committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    3ce9119 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cbddf70 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2020

  1. Added copyright header to sort_test.go.

    equalsPairs now checks individual struct elements instead of their printed values.
    soundvibe committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    bd3f326 View commit details
    Browse the repository at this point in the history
  2. better init

    soundvibe committed Oct 26, 2020
    Configuration menu
    Copy the full SHA
    7b0216c View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2020

  1. Removed Min() function in favour of using this logic inline.

    Used append in place when indices are not needed.
    Documented and extracted some comparison functions for better readability and clearness.
    soundvibe committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    795f181 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into sort

    * master:
      [query] Improve precision for variance and stddev of equal values (#2799)
      Support dynamic namespace resolution for embedded coordinators (#2815)
      [dbnode] Add index regexp DFA compilation cache to avoid allocating DFAs for same expressions (#2814)
      [dbnode] Set default cache on retrieve to false, prepare testing with cache none (#2813)
      [tools] Output annotations as base64 (#2743)
      Add Reset Transformation (#2794)
      [large-tiles] Fix for a reverse index when querying downsampled namespace (#2808)
      [dbnode] Evict info files cache before index bootstrap in peers bootstrapper (#2802)
      [dbnode] Bump default filesystem persist rate limit (#2806)
      [coordinator] Add metrics and configurability of downsample and ingest writer worker pool (#2797)
      [dbnode] Fix concurrency granularity of seekerManager.UpdateOpenLease (#2790)
      [dbnode] Use correct import path for atomic library (#2801)
      Regenerate carbon automapping rules on namespaces changes (#2793)
      Enforce matching retention and index block size (#2783)
      [query] Add ClusterNamespacesWatcher and use to generate downsample automapper rules (#2782)
      [query][dbnode] Wire up etcd-backed Clusters implementation in coordinator (#2758)
      [query] Fix quantile() argument not being passed through (#2780)
      [query] Add "median" aggregation to Graphite aggregate() function (#2774)
      [r2] Ensure KeepOriginal is propagated when adding/reviving rules (#2796)
      [dbnode] Update default db read limits  (#2784)
    soundvibe committed Oct 29, 2020
    Configuration menu
    Copy the full SHA
    c32d414 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2020

  1. Merge branch 'master' into sort

    * master:
      [query] count_values label naming fixes (#2805)
      [dbnode] Read only namespaces (#2803)
      Remove old code: m3nsch (#2822)
      Update issue templates
      Update issue templates
      [proto] Allow zero-alloc reuse of AggregatedMetric protobuf payloads (#2823)
      Remove old code: aggregator/handler/trafficcontrol (#2821)
      Remove old code: aggregation/quantile/tdigest (#2820)
      AddToReset config to change Add transforms to Reset transforms (#2817)
      [metrics/rules] Add test to assert that mixed-mode keepOriginal uses keepOriginal=true (#2819)
      [dbnode] Update return unfulfilled for corrupt commit log files default (#2807)
      [dbnode] Move eviction logic up before ns loop (#2812)
      [query] Add additional parser tests (#2811)
      [config] Remove deprecated configuration fields (#2771)
    soundvibe committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    131287b View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2020

  1. Merge branch 'master' into sort

    * master:
      [read_index_segments] Always validate index segment checksums before reading/validating contents (#2835)
      [query] Return additional warnings in /query{,_range} endpoints (#2836)
      Add a check for seriesIter.Err (#2834)
      [tools] Add concurrent read_index_segments validation option (#2833)
      [query] Add non-ready namespaces to Clusters interface and use in /namespace/ready endpoint (#2828)
      [query] Tests for when function argument is an expression (#2809)
      [large-tiles] Additional metrics added (#2720)
      [query] Refactor groupByNodes and implement `nodes` arg in asPercent (#2816)
      [read_index_segments] Add log that outlines which segment being processed (#2825)
      [aggregator] Handle follower canLead() for not yet flushed windows (#2818)
    soundvibe committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    b176ad4 View commit details
    Browse the repository at this point in the history
  2. Updated doc comment

    soundvibe committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    30a7119 View commit details
    Browse the repository at this point in the history