Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Return the thread ID properly down sync. #14159

Merged
merged 2 commits into from
Oct 12, 2022

Conversation

clokep
Copy link
Member

@clokep clokep commented Oct 12, 2022

#13782 was missing a commit from #13202 (d35ee33) causing the receipts returned down sync to be missing information.

Builds on #14140.

Tests at matrix-org/complement#500.

@clokep clokep changed the base branch from develop to clokep/fix-main-timeline October 12, 2022 14:27
@clokep clokep marked this pull request as ready for review October 12, 2022 14:30
@clokep clokep requested a review from a team as a code owner October 12, 2022 14:30
@clokep clokep self-assigned this Oct 12, 2022
@clokep clokep merged commit 4a7cd9d into clokep/fix-main-timeline Oct 12, 2022
@clokep clokep deleted the clokep/receipt-fix-sync branch October 12, 2022 16:11
@clokep
Copy link
Member Author

clokep commented Oct 12, 2022

Oops, I merged this into a branch (as 4a7cd9d) instead of into develop. I'm going to revert that on #14140, then cherry-pick it back to develop.

clokep added a commit that referenced this pull request Oct 12, 2022
A receipt's thread ID, if one exists, should be added to the
body of a receipt.
@clokep
Copy link
Member Author

clokep commented Oct 12, 2022

Done as e6e876b.

clokep added a commit that referenced this pull request Oct 13, 2022
Fix a broken conflict in e6e876b,
by not stomping over a field right after creating it.
@clokep
Copy link
Member Author

clokep commented Oct 13, 2022

Done as e6e876b.

And turns out I did this poorly, I fixed it in 7d59a51.

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Oct 29, 2022
Upstream changes:

Synapse 1.70.1 (2022-10-28)
===========================

(bugfixes)


Synapse 1.70.0 (2022-10-26)
===========================

Features
--------

- Support for
  [MSC3856](matrix-org/matrix-spec-proposals#3856):
  threads list
  API. ([\#13394](matrix-org/synapse#13394),
  [\#14171](matrix-org/synapse#14171),
  [\#14175](matrix-org/synapse#14175))

- Support for thread-specific notifications & receipts
  ([MSC3771](matrix-org/matrix-spec-proposals#3771)
  and
  [MSC3773](matrix-org/matrix-spec-proposals#3773)). ([\#13776](matrix-org/synapse#13776),
  [\#13824](matrix-org/synapse#13824),
  [\#13877](matrix-org/synapse#13877),
  [\#13878](matrix-org/synapse#13878),
  [\#14050](matrix-org/synapse#14050),
  [\#14140](matrix-org/synapse#14140),
  [\#14159](matrix-org/synapse#14159),
  [\#14163](matrix-org/synapse#14163),
  [\#14174](matrix-org/synapse#14174),
  [\#14222](matrix-org/synapse#14222))

- Stop fetching missing `prev_events` after we already know their
  signature is
  invalid. ([\#13816](matrix-org/synapse#13816))

- Send application service access tokens as a header (and query
  parameter). Implements
  [MSC2832](matrix-org/matrix-spec-proposals#2832). ([\#13996](matrix-org/synapse#13996))

- Ignore server ACL changes when generating pushes. Implements
  [MSC3786](matrix-org/matrix-spec-proposals#3786). ([\#13997](matrix-org/synapse#13997))

- Experimental support for redirecting to an implementation of a
  [MSC3886](matrix-org/matrix-spec-proposals#3886)
  HTTP rendezvous
  service. ([\#14018](matrix-org/synapse#14018))

- The `/relations` endpoint can now be used on
  workers. ([\#14028](matrix-org/synapse#14028))

- Advertise support for Matrix 1.3 and 1.4 on
  `/_matrix/client/versions`. ([\#14032](matrix-org/synapse#14032),
  [\#14184](matrix-org/synapse#14184))

- Improve validation of request bodies for the [Device
  Management](https://spec.matrix.org/v1.4/client-server-api/#device-management)
  and [MSC2697 Device
  Dehyrdation](matrix-org/matrix-spec-proposals#2697)
  client-server API
  endpoints. ([\#14054](matrix-org/synapse#14054))

- Experimental support for
  [MSC3874](matrix-org/matrix-spec-proposals#3874):
  Filtering threads from the `/messages`
  endpoint. ([\#14148](matrix-org/synapse#14148))

- Improve the validation of the following PUT endpoints:
  [`/directory/room/{roomAlias}`](https://spec.matrix.org/v1.4/client-server-api/#put_matrixclientv3directoryroomroomalias),
  [`/directory/list/room/{roomId}`](https://spec.matrix.org/v1.4/client-server-api/#put_matrixclientv3directorylistroomroomid)
  and
  [`/directory/list/appservice/{networkId}/{roomId}`](https://spec.matrix.org/v1.4/application-service-api/#put_matrixclientv3directorylistappservicenetworkidroomid). ([\#14179](matrix-org/synapse#14179))


Deprecations and Removals
-------------------------

- Remove the experimental implementation of
  [MSC3772](matrix-org/matrix-spec-proposals#3772). ([\#14094](matrix-org/synapse#14094))

- Remove the unstable identifier for
  [MSC3715](matrix-org/matrix-spec-proposals#3715). ([\#14106](matrix-org/synapse#14106),
  [\#14146](matrix-org/synapse#14146))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants