Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v5.0.0 alpha.1 #272

Merged
merged 13 commits into from
Apr 3, 2024
Merged

Release v5.0.0 alpha.1 #272

merged 13 commits into from
Apr 3, 2024

Conversation

michael-82
Copy link
Collaborator

No description provided.

#254 - Update github actions

- update several github actions to their latest version
- add codecov token
- Update to spring boot 3.2.3
…-update-to-spring-boot-323

#262 - Update to spring boot 3.2.3
…with activated Validation

- change query and template endpoints to include getting invalid terms by default
- this will most likely change when validation is extended to also include missing contexts or invalid filters
…-endpoint-modification-for-template-and-savedqueries-retrieval-with-activated-validation

#260 - Endpoint modification for template and savedqueries retrieval with activated validation
…#265)

* #258 - Add an endpoint that takes a structured query and validates it

- Return invalid criteria (termcode/context) instead of just termcode
- Replace old /validate endpoint with the new one
- add swagger documentation for the endpoint
- When no invalid terms are found, return an empty array instead of omitting the parameter
- Don't include the invalid terms list in the structured query itself but create a new object ValidatedStructuredQuery, containing the original query and the list of invalid terms
- Add a new endpoint that takes a structured query and sends back the same query with additional invalidTerms if present
- update blaze container in tests to 0.25
- update testcontainers to 1.19.7 and commons-compres to 1.26.1
…-update-testcontainers-dependency

#267 - Update testcontainers dependency
- Update to spring boot 3.2.4
…-update-spring-boot-to-324

#262 - Update spring boot to 3.2.4
* #266 - Change validation information

- add mutable criterion and structured query classes that can be easily annotated during validation. Provide converters to convert immutable to mutable and vice versa
- remove validatedstructuredquery
- add validation issues
- remove invalidCriteria from entities
- rename TermCodeValidation to StructuredQueryValidation
- rename getinvalidcriteria
- modify tests
- add skipValidation parameter to get query and get template
- modify swagger file
@michael-82 michael-82 added the Release For actual releases or release preparation label Mar 26, 2024
@michael-82 michael-82 added this to the Release 5.0.0-alpha.1 milestone Mar 26, 2024
@michael-82 michael-82 self-assigned this Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 77.01%. Comparing base (55170eb) to head (53ca54c).
Report is 1 commits behind head on master.

❗ Current head 53ca54c differs from pull request most recent head 21d9d3a. Consider uploading reports for the commit 21d9d3a to get more accurate results

Files Patch % Lines
...minology/validation/StructuredQueryValidation.java 92.30% 1 Missing and 3 partials ⚠️
..._gui_backend/query/api/MutableStructuredQuery.java 90.00% 1 Missing and 2 partials ⚠️
...query/api/validation/StructuredQueryValidator.java 60.00% 2 Missing ⚠️
...ility_gui_backend/common/api/MutableCriterion.java 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #272      +/-   ##
============================================
+ Coverage     75.66%   77.01%   +1.35%     
- Complexity      539      595      +56     
============================================
  Files           124      128       +4     
  Lines          2227     2367     +140     
  Branches        106      132      +26     
============================================
+ Hits           1685     1823     +138     
+ Misses          478      475       -3     
- Partials         64       69       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-82 michael-82 merged commit d96691a into master Apr 3, 2024
4 checks passed
@michael-82 michael-82 deleted the release/v5.0.0-alpha.1 branch April 3, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release For actual releases or release preparation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant