Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Performance improvements when calling newGuid multiple times (like 10,000) #1870

Closed
MSNev opened this issue Aug 1, 2022 · 1 comment
Assignees
Milestone

Comments

@MSNev
Copy link
Collaborator

MSNev commented Aug 1, 2022

On performing some additional performance validation it was found that when generating 10,000 newGuid locally this would take in the order of 430ms, while using the generateW3CId could perform the same task in around 80ms.

As the only different between the 2 results is that newGuid includes dashes - between the segments, we should update newGuid to also operate in the 80ms range.

@MSNev MSNev self-assigned this Aug 1, 2022
MSNev added a commit to MSNev/ApplicationInsights-JS that referenced this issue Aug 1, 2022
@MSNev MSNev added this to the 2.8.6 milestone Aug 1, 2022
MSNev added a commit to MSNev/ApplicationInsights-JS that referenced this issue Aug 1, 2022
MSNev added a commit to MSNev/ApplicationInsights-JS that referenced this issue Aug 1, 2022
@MSNev MSNev added fixed - waiting release PR Committed and waiting deployment released - NPM waiting - CDN deployment and removed fixed - waiting release PR Committed and waiting deployment waiting - CDN deployment labels Aug 2, 2022
@MSNev MSNev closed this as completed Aug 9, 2022
MSNev added a commit to MSNev/ApplicationInsights-JS that referenced this issue Oct 3, 2022
* [BUG] Snippet initialization with IE8/9 fails with minified code (works with un-minified code) microsoft#1852 (microsoft#1854)

* [BUG] CDN Packaging is not exposing the internal tools (CoreUtils / Telemetry / etc) microsoft#1857 (microsoft#1858)

* fix stopTrackEvents (microsoft#1859)

Co-authored-by: Nev <54870357+MSNev@users.noreply.github.com>

* Refactor code to provide better tree shaking and minification of generated code microsoft#1076 (microsoft#1811)

- Add Automatic Name replacing / Crunching

* Address Component Governance issues (microsoft#1860)

- Update npm to 8.13.2
- Update rush to 5.75.0

* [Release] Increase version to 2.8.5 (microsoft#1861)

- Updates React Plugin to v3.3.5 (with v2.8.5 as dependency) -- using React 17
- Updates React Native Plugin to 2.5.5 (with v2.8.5 as dependency)
- Updates Chrome Debug Extension to 0.3.5

* Update and add legal compliance notices and license terms (microsoft#1865)

* Remove React-JS and React-Native code from this repo (microsoft#1866)

* [BUG] Remote Dependency requests don't "always" have the correct ai.operation.id tag (page view race condition) microsoft#1862 (microsoft#1869)

* [BUG] Performance improvements when calling newGuid multiple times (like 10,000) microsoft#1870 (microsoft#1871)

* [Release] Increase version to 2.8.6 (microsoft#1872)

* add click plugin url config back (microsoft#1874)

* fix(AISKULight): call getSKUDefaults after it's defined, change this.config references to _self (microsoft#1876)

Closes: microsoft#1875

* Merge master to beta @ 6ba2c0d

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>
Co-authored-by: Lindsay Evans <linz@linz.id.au>
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant