fix(AISKULight): call getSKUDefaults after it's defined, change this.… #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…config references to _self Closes: #1875
MSNev
approved these changes
Aug 5, 2022
MSNev
added a commit
to MSNev/ApplicationInsights-JS
that referenced
this pull request
Oct 3, 2022
* [BUG] Snippet initialization with IE8/9 fails with minified code (works with un-minified code) microsoft#1852 (microsoft#1854) * [BUG] CDN Packaging is not exposing the internal tools (CoreUtils / Telemetry / etc) microsoft#1857 (microsoft#1858) * fix stopTrackEvents (microsoft#1859) Co-authored-by: Nev <54870357+MSNev@users.noreply.github.com> * Refactor code to provide better tree shaking and minification of generated code microsoft#1076 (microsoft#1811) - Add Automatic Name replacing / Crunching * Address Component Governance issues (microsoft#1860) - Update npm to 8.13.2 - Update rush to 5.75.0 * [Release] Increase version to 2.8.5 (microsoft#1861) - Updates React Plugin to v3.3.5 (with v2.8.5 as dependency) -- using React 17 - Updates React Native Plugin to 2.5.5 (with v2.8.5 as dependency) - Updates Chrome Debug Extension to 0.3.5 * Update and add legal compliance notices and license terms (microsoft#1865) * Remove React-JS and React-Native code from this repo (microsoft#1866) * [BUG] Remote Dependency requests don't "always" have the correct ai.operation.id tag (page view race condition) microsoft#1862 (microsoft#1869) * [BUG] Performance improvements when calling newGuid multiple times (like 10,000) microsoft#1870 (microsoft#1871) * [Release] Increase version to 2.8.6 (microsoft#1872) * add click plugin url config back (microsoft#1874) * fix(AISKULight): call getSKUDefaults after it's defined, change this.config references to _self (microsoft#1876) Closes: microsoft#1875 * Merge master to beta @ 6ba2c0d Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com> Co-authored-by: Lindsay Evans <linz@linz.id.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix my particular issue (#1875), no idea if it would impact anything else though - am getting errors when running
npm testlocally that don't seem related to anything I've done here :(