Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Snippet initialization with IE8 fails with minified code (works with un-minified code) #1852 #1854

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

MSNev
Copy link
Collaborator

@MSNev MSNev commented Jun 14, 2022

No description provided.

@MSNev MSNev force-pushed the MSNev/IeMinifyIssue branch 2 times, most recently from 2bf1173 to c179b6e Compare June 14, 2022 20:18
@MSNev MSNev changed the title [BUG] Snippet initialization with IE8/9 fails with minified code (works with un-minified code) #1852 [BUG] Snippet initialization with IE8 fails with minified code (works with un-minified code) #1852 Jun 14, 2022
@@ -53,7 +53,7 @@
"ts-jest": "^27.0.7",
"typescript": "^4.3.4",
"tslib": "^2.0.0",
"uglify-js": "^3.11.0",
"uglify-js": "3.16.0",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning to the version of uglify-js that has been tested with this work-around, so that a future change doesn't introduce another issue.

This pinning will be removed for the beta, as we are dropping ES3 (IE8) support.

@MSNev MSNev added this to the 2.8.5 milestone Jun 14, 2022
@MSNev MSNev merged commit 7fc137d into master Jun 15, 2022
@MSNev MSNev deleted the MSNev/IeMinifyIssue branch July 26, 2022 21:39
MSNev added a commit that referenced this pull request Jul 28, 2022
* [BUG] Snippet initialization with IE8/9 fails with minified code (works with un-minified code) #1852 (#1854)

* [BUG] CDN Packaging is not exposing the internal tools (CoreUtils / Telemetry / etc) #1857 (#1858)

* fix stopTrackEvents (#1859)

Co-authored-by: Nev <54870357+MSNev@users.noreply.github.com>

* Refactor code to provide better tree shaking and minification of generated code #1076 (#1811)

- Add Automatic Name replacing / Crunching

* Address Component Governance issues (#1860)

- Update npm to 8.13.2
- Update rush to 5.75.0

* [Release] Increase version to 2.8.5 (#1861)

- Updates React Plugin to v3.3.5 (with v2.8.5 as dependency) -- using React 17
- Updates React Native Plugin to 2.5.5 (with v2.8.5 as dependency)
- Updates Chrome Debug Extension to 0.3.5

* Update and add legal compliance notices and license terms (#1865)

* Remove React-JS and React-Native code from this repo (#1866)

* Merge master to beta @ 200e0f1
- Update shrinkwrap and npm version for rush.json

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>
MSNev added a commit to MSNev/ApplicationInsights-JS that referenced this pull request Oct 3, 2022
* [BUG] Snippet initialization with IE8/9 fails with minified code (works with un-minified code) microsoft#1852 (microsoft#1854)

* [BUG] CDN Packaging is not exposing the internal tools (CoreUtils / Telemetry / etc) microsoft#1857 (microsoft#1858)

* fix stopTrackEvents (microsoft#1859)

Co-authored-by: Nev <54870357+MSNev@users.noreply.github.com>

* Refactor code to provide better tree shaking and minification of generated code microsoft#1076 (microsoft#1811)

- Add Automatic Name replacing / Crunching

* Address Component Governance issues (microsoft#1860)

- Update npm to 8.13.2
- Update rush to 5.75.0

* [Release] Increase version to 2.8.5 (microsoft#1861)

- Updates React Plugin to v3.3.5 (with v2.8.5 as dependency) -- using React 17
- Updates React Native Plugin to 2.5.5 (with v2.8.5 as dependency)
- Updates Chrome Debug Extension to 0.3.5

* Update and add legal compliance notices and license terms (microsoft#1865)

* Remove React-JS and React-Native code from this repo (microsoft#1866)

* [BUG] Remote Dependency requests don't "always" have the correct ai.operation.id tag (page view race condition) microsoft#1862 (microsoft#1869)

* [BUG] Performance improvements when calling newGuid multiple times (like 10,000) microsoft#1870 (microsoft#1871)

* [Release] Increase version to 2.8.6 (microsoft#1872)

* add click plugin url config back (microsoft#1874)

* fix(AISKULight): call getSKUDefaults after it's defined, change this.config references to _self (microsoft#1876)

Closes: microsoft#1875

* Merge master to beta @ 6ba2c0d

Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com>
Co-authored-by: Lindsay Evans <linz@linz.id.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants