-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Remote Dependency requests don't "always" have the correct ai.operation.id tag (page view race condition) #1862 #1869
Conversation
…peration.id tag (page view race condition) microsoft#1862
@@ -23,7 +23,6 @@ const AJAX_MONITOR_PREFIX = "ai.ajxmn."; | |||
const strDiagLog = "diagLog"; | |||
const strAjaxData = "ajaxData"; | |||
const strFetch = "fetch"; | |||
const strTrackDependencyDataInternal = "trackDependencyDataInternal"; // Using string to help with minification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing and letting the automatic dynamic name logic work
@@ -1010,7 +1010,7 @@ function findPossibleFileConstants(parsedFile, theNames, ignoreConst, ignoreName | |||
} | |||
|
|||
var dynamicIndex = 0; | |||
function createDynamicName(value) { | |||
function createDynamicName(value, isDupe) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was generating the same "name" for the same string with a different case
eg. traceId
and traceID
* [BUG] Snippet initialization with IE8/9 fails with minified code (works with un-minified code) microsoft#1852 (microsoft#1854) * [BUG] CDN Packaging is not exposing the internal tools (CoreUtils / Telemetry / etc) microsoft#1857 (microsoft#1858) * fix stopTrackEvents (microsoft#1859) Co-authored-by: Nev <54870357+MSNev@users.noreply.github.com> * Refactor code to provide better tree shaking and minification of generated code microsoft#1076 (microsoft#1811) - Add Automatic Name replacing / Crunching * Address Component Governance issues (microsoft#1860) - Update npm to 8.13.2 - Update rush to 5.75.0 * [Release] Increase version to 2.8.5 (microsoft#1861) - Updates React Plugin to v3.3.5 (with v2.8.5 as dependency) -- using React 17 - Updates React Native Plugin to 2.5.5 (with v2.8.5 as dependency) - Updates Chrome Debug Extension to 0.3.5 * Update and add legal compliance notices and license terms (microsoft#1865) * Remove React-JS and React-Native code from this repo (microsoft#1866) * [BUG] Remote Dependency requests don't "always" have the correct ai.operation.id tag (page view race condition) microsoft#1862 (microsoft#1869) * [BUG] Performance improvements when calling newGuid multiple times (like 10,000) microsoft#1870 (microsoft#1871) * [Release] Increase version to 2.8.6 (microsoft#1872) * add click plugin url config back (microsoft#1874) * fix(AISKULight): call getSKUDefaults after it's defined, change this.config references to _self (microsoft#1876) Closes: microsoft#1875 * Merge master to beta @ 6ba2c0d Co-authored-by: Karlie-777 <79606506+Karlie-777@users.noreply.github.com> Co-authored-by: Lindsay Evans <linz@linz.id.au>
No description provided.