feat(editor): Add new /templates/search endpoint
#8227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
RicardoE105
changed the title
/template/search endpoint
RicardoE105
changed the title
/template/search endpoint/template/search endpoint
RicardoE105
commented
Jan 8, 2024
| @@ -6,6 +6,7 @@ import type { | |||
| ITemplatesCollectionResponse, | |||
| ITemplatesWorkflowResponse, | |||
| IWorkflowTemplate, | |||
| TemplateSearchFacet, | |||
There was a problem hiding this comment.
Should we drop the endpoint to retrieve the categories since we are not using it anymore? @MiloradFilipovic
There was a problem hiding this comment.
I think we need it for backward compatibility
* master: ci: Validate docs urls for langchain nodes as well (no-changelog) (#8271) fix: Small ui fixes to workflow cred setup modal (no-changelog) (#8280) fix: Fix issue with API key being required for the Qdrant Node (#8237) feat(Coda Node): Add User-Agent for requests to Coda (no-changelog) (#7771) fix(FTP Node): FTP connection failed due to missing password credential in node (#8131) ci: Fix lint setup in `chat` package (no-changelog) (#8275) ci: Fix codecov reporting, and include all packages (no-changelog) (#8276) fix(core): Fix test webhook deregistration (#8247) docs: Update links in deprecated langchain nodes to avoid linting errors (no-changelog) (#8273) fix: Fix user reinvites on FE and BE (#8261) docs: Update primaryDocumentation urls for nodes updated in #7651 (no-changelog) (#8270) feat: Add Chat Trigger node (#7409) fix(Github Trigger Node): Enforce SSL validation by default (#8265) fix(editor): Tweaking button sizes in execution preview (#8206) fix(core): Avoid wrapping `ExecutionBaseError` to prevent misreporting to Sentry (no-changelog) (#8262)
mutdmour
reviewed
Jan 10, 2024
Comment on lines
56
to
57
| skip: query.skip, | ||
| rows: query.limit, |
There was a problem hiding this comment.
how does this map to the page parameter typesense expects? https://typesense.org/docs/0.24.0/api/search.html#pagination-parameters
There was a problem hiding this comment.
This is mapped on the backend:
per_page --> rows
page --> skip
mutdmour
reviewed
Jan 10, 2024
MiloradFilipovic
changed the title
/template/search endpoint/templates/search endpoint
* master: fix: Adjust cred setup telemetry (no-changelog) (#8294) fix(HTTP Request Node): Delete `response.request` only when it's a valid circular references (#8293) fix: Properly output saml validation errors (#8284) 🚀 Release 1.24.0 (#8290) feat(editor): Migrate deviceSupportHelpers mixin to useDeviceSupport composable (no-changelog) (#8289) fix: Store workflow settings when saving an execution (#8288) fix(MySQL Node): Only escape table names when needed (#8246) feat(Google Sheets Node): Add "By Name" option to selector for Sheets (#8241) feat(MongoDB Node): Add support for TLS (#8266) feat: Update @n8n/chat exports and add example images (no-changelog) (#8274) ci: Add support for optionally including ARM64 support in custom images (no-changelog) (#8286) ci: Update Cypress & increase amount of e2e containers (#8282) fix(Monday.com Node): Migrate to api 2023-10 (#8254)
mutdmour
previously approved these changes
Jan 11, 2024
|
|
1 flaky test on run #3762 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sharing > should work for admin role on credentials created by others (also can share it with themselves) |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #8227 ↗︎
|
@mutdmour can we get this one approved? |
mutdmour
approved these changes
Jan 15, 2024
|
|
|
✅ All Cypress E2E specs passed |
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating n8n front-end to use the new search endpoint powered by TypeSense.
Endpoint is deployed on staging API so, in order to test it, use this env var:
export N8N_TEMPLATES_HOST=https://api-staging.n8n.io/apiNOTE: This PR should not be merged until backend changes are merged and released.
Related tickets and issues
https://linear.app/n8n/issue/ADO-1555/update-in-app-search-to-work-with-the-new-back-end
Review / Merge checklist
(no-changelog)otherwise. (conventions)