fix(input): bdel term buf #4608
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4608 +/- ##
==========================================
- Coverage 98.75% 98.74% -0.02%
==========================================
Files 273 273
Lines 25920 25921 +1
Branches 5376 5376
==========================================
- Hits 25597 25595 -2
- Misses 188 190 +2
- Partials 135 136 +1
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| @@ -160,6 +160,7 @@ export default class InputBox implements Disposable { | |||
| if (this._disposed) return | |||
| this._disposed = true | |||
| this.nvim.call('coc#float#close', [this._winid ?? -1], true) | |||
| this.nvim.command(`silent! bd! ${this._bufnr}`, true) | |||
There was a problem hiding this comment.
Looks good! But I'm wondering that the buffer might get wiped again somewhere else. since #4606 only happens when you cancel the prompt, that means if it got confirmed, the buffer will get wiped properly.
There was a problem hiding this comment.
if it got confirmed, the buffer will get wiped properly
In my tests, after you confirm the rename prompt, the buffer didn't get wiped. Can you reproduce it?
There was a problem hiding this comment.
In my tests, after you confirm the rename prompt, the buffer didn't get wiped. Can you reproduce it?
Can't reproduce it. It's OK to me.
15c8946 Revert "chore(package): use yarn instead" dacd62f chore(package): use yarn instead 0e6be47 fix(package): use npm 0189ace chore(inlayHint): check nvim version d81fde9 feat(inlayHint): inline display for nvim (#4648) 1038082 Allow watching workspaces at /tmp/some-dir (#4632) 34f5d96 refactor(glob): use latest glob module b2ae10c fix(type): fix bad types 5385efd chore(package): require node 16.18.0 5ea8b52 chore(README): gitter url to matrix (#4520) fc260ab fix(input): delete buffer on vim only 02c2542 fix(native): get pathstr by cursor position (#4553) 1c9c72f fix(workspaceFolder): check directory of fsPath (#4566) b1e5d71 fix(util): check $XDG_CONFIG_HOME before use as data home (#4492) abdb129 fix(input): bdel term buf (#4608) c790182 chore(doc): target of diagnosticInfo 5571414 feat(diagnostic): add target to diagnosticInfo (#4642) e4ffae5 fix(list): scrolling float preview for vim (#4647) c5a7123 feat(data): allow languageserver.env (#4658) 44898ec fix(format): formatOnSaveTimeout config with scope (#4689) d432de2 feat(links): only fetch links on documeng changed (#4690) ed89997 fix: clean unused code (#4710) 4f3b4d9 feat(handler): hasProvider can accept bufnr (#4714) 18152f2 chore(package): update dependencies bacbe49 refactor(highlighter): highligher.ts to highlighter.ts (#4730) 5423ee0 feat(completion): stop completion when navigate 29065d9 chore(doc): escape coc_status 1d36382 chore(doc): add refactor buffer section 0a2c8b8 fix: ls provider's score is equal to the default one (#4722) fab97c7 perf: return early in around and buffer source (#4721) eba04ac fix: autoActiavte to autoActivate, keeped to kept (#4716) f7545f2 docs: update outdated url (#4717)
close #4606