feat(inlayHint): inline display for nvim #4648
Conversation
|
Finally, Today is a great day! |
fannheyward
force-pushed
the
feat/nvim-inline-inlayHint
branch
from
ba4b9b0
to
9446e1c
Compare
|
Hi @fannheyward
I agree with this, the All the checkboxes are ticked, but the current CI configuration picks last nvim stable, which is 0.9.1. Do you assume it's OK to merge now despite one test suite failing on CI? Or is it better to wait nvim 0.10 first? |
|
Just pulled nvim-nightly-bin from AUR and tested the branch on my machine, working nicely. Had to rebase over master due to new node 20 support after upgraded dev-deps. The Vim/NeoVim feature is far from perfect though, I'm spotting problems on first usage, e.g., it affects word movements, refresh doesn't seem great after undo... |
fannheyward
force-pushed
the
feat/nvim-inline-inlayHint
branch
from
9446e1c
to
4ba9fd2
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4648 +/- ##
==========================================
- Coverage 98.75% 98.74% -0.01%
==========================================
Files 273 273
Lines 25920 25908 -12
Branches 5376 5371 -5
==========================================
- Hits 25597 25584 -13
Misses 188 188
- Partials 135 136 +1
☔ View full report in Codecov by Sentry. |
|
Hi @fannheyward. After last rebase do you expect review for merge? I gave a review last time but I think my questions still stand and are still unanswered. |
|
@oblitum I prefer to wait for 0.10.0 stable. |
|
@fannheyward ok. This is pending, not sure whether you wish to leave that for later too. |
|
Works as expected for me. |
15c8946 Revert "chore(package): use yarn instead" dacd62f chore(package): use yarn instead 0e6be47 fix(package): use npm 0189ace chore(inlayHint): check nvim version d81fde9 feat(inlayHint): inline display for nvim (#4648) 1038082 Allow watching workspaces at /tmp/some-dir (#4632) 34f5d96 refactor(glob): use latest glob module b2ae10c fix(type): fix bad types 5385efd chore(package): require node 16.18.0 5ea8b52 chore(README): gitter url to matrix (#4520) fc260ab fix(input): delete buffer on vim only 02c2542 fix(native): get pathstr by cursor position (#4553) 1c9c72f fix(workspaceFolder): check directory of fsPath (#4566) b1e5d71 fix(util): check $XDG_CONFIG_HOME before use as data home (#4492) abdb129 fix(input): bdel term buf (#4608) c790182 chore(doc): target of diagnosticInfo 5571414 feat(diagnostic): add target to diagnosticInfo (#4642) e4ffae5 fix(list): scrolling float preview for vim (#4647) c5a7123 feat(data): allow languageserver.env (#4658) 44898ec fix(format): formatOnSaveTimeout config with scope (#4689) d432de2 feat(links): only fetch links on documeng changed (#4690) ed89997 fix: clean unused code (#4710) 4f3b4d9 feat(handler): hasProvider can accept bufnr (#4714) 18152f2 chore(package): update dependencies bacbe49 refactor(highlighter): highligher.ts to highlighter.ts (#4730) 5423ee0 feat(completion): stop completion when navigate 29065d9 chore(doc): escape coc_status 1d36382 chore(doc): add refactor buffer section 0a2c8b8 fix: ls provider's score is equal to the default one (#4722) fab97c7 perf: return early in around and buffer source (#4721) eba04ac fix: autoActiavte to autoActivate, keeped to kept (#4716) f7545f2 docs: update outdated url (#4717)
needs neovim/neovim#20130
Next:
Do we need to support both
inlinefor nvim 0.10.0+ andeolfor nvim 0.9.0-? I do like onlyinline, for nvim 0.9.0 and before, no inlayHint