fix: ls provider's score is equal to the default one #4722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, ls provider's score will be equal to the default one if ls
provider's documentSelector has pattern. For example, a ls registers
capability `textDocument/documentHighlight` with documentSelector
`{'language': 'cs', 'scheme': 'file', 'pattern': '**/*.cs'}`, it will
get score 5, which is equal to the default one with documentSelector
'*', even if the language id has matched. Since the capability is
registered later than the default one, DocumentHighlightManager will
only use the default one to provide highlight, which is not expected.
If all of language, scheme, and pattern match, we should return the
highest score of them, instead of the last score.
Signed-off-by: Adam Tao <tcx4c70@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4722 +/- ##
==========================================
+ Coverage 98.75% 98.76% +0.01%
==========================================
Files 273 273
Lines 25920 25923 +3
Branches 5376 5379 +3
==========================================
+ Hits 25596 25604 +8
+ Misses 188 186 -2
+ Partials 136 133 -3
☔ View full report in Codecov by Sentry. |
|
in testing, sorry for the delay review. |
|
The fix is OK, please test for this case:
to |
Signed-off-by: Adam Tao <tcx4c70@gmail.com>
fannheyward
approved these changes
Aug 22, 2023
chemzqm
added a commit
that referenced
this pull request
Aug 31, 2023
15c8946 Revert "chore(package): use yarn instead" dacd62f chore(package): use yarn instead 0e6be47 fix(package): use npm 0189ace chore(inlayHint): check nvim version d81fde9 feat(inlayHint): inline display for nvim (#4648) 1038082 Allow watching workspaces at /tmp/some-dir (#4632) 34f5d96 refactor(glob): use latest glob module b2ae10c fix(type): fix bad types 5385efd chore(package): require node 16.18.0 5ea8b52 chore(README): gitter url to matrix (#4520) fc260ab fix(input): delete buffer on vim only 02c2542 fix(native): get pathstr by cursor position (#4553) 1c9c72f fix(workspaceFolder): check directory of fsPath (#4566) b1e5d71 fix(util): check $XDG_CONFIG_HOME before use as data home (#4492) abdb129 fix(input): bdel term buf (#4608) c790182 chore(doc): target of diagnosticInfo 5571414 feat(diagnostic): add target to diagnosticInfo (#4642) e4ffae5 fix(list): scrolling float preview for vim (#4647) c5a7123 feat(data): allow languageserver.env (#4658) 44898ec fix(format): formatOnSaveTimeout config with scope (#4689) d432de2 feat(links): only fetch links on documeng changed (#4690) ed89997 fix: clean unused code (#4710) 4f3b4d9 feat(handler): hasProvider can accept bufnr (#4714) 18152f2 chore(package): update dependencies bacbe49 refactor(highlighter): highligher.ts to highlighter.ts (#4730) 5423ee0 feat(completion): stop completion when navigate 29065d9 chore(doc): escape coc_status 1d36382 chore(doc): add refactor buffer section 0a2c8b8 fix: ls provider's score is equal to the default one (#4722) fab97c7 perf: return early in around and buffer source (#4721) eba04ac fix: autoActiavte to autoActivate, keeped to kept (#4716) f7545f2 docs: update outdated url (#4717)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, ls provider's score will be equal to the default one if ls provider's documentSelector has pattern. For example, a ls registers capability
textDocument/documentHighlightwith documentSelector{'language': 'cs', 'scheme': 'file', 'pattern': '**/*.cs'}, it will get score 5, which is equal to the default one with documentSelector '*', even if the language id has matched. Since the capability is registered later than the default one, DocumentHighlightManager will only use the default one to provide highlight, which is not expected.If all of language, scheme, and pattern match, we should return the highest score of them, instead of the last score.