Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow watching workspaces at /tmp/some-dir #4632

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Allow watching workspaces at /tmp/some-dir #4632

merged 2 commits into from
Aug 31, 2023

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented May 7, 2023

@oxalica oxalica force-pushed the fix/allow-tmp-subdir branch from 20d944b to 90919db Compare May 8, 2023 15:42
@oxalica
Copy link
Contributor Author

oxalica commented May 8, 2023

After fixed isValidWatchRoot tests, this error still occur. I have no idea what's going wrong here.


  ● fileSystemWatcher › should watch for file create

    excess data found after input buffer, use BunserBuf instead

      75 |     client = c
      76 |     c.on('data', data => {
    > 77 |       let obj = bser.loadFromBuffer(data)
         |                      ^
      78 |       if (obj[0] == 'watch-project') {
      79 |         sendResponse(watchResponse || { watch: obj[1], warning: 'warning' })
      80 |       } else if (obj[0] == 'unsubscribe') {

      at Object.Error [as loadFromBuffer] (node_modules/bser/index.js:439:11)
      at Socket.loadFromBuffer (src/__tests__/core/fileSystemWatcher.test.ts:77:22)

@fannheyward
Copy link
Member

Will check the failed tests ASAP.

@fannheyward
Copy link
Member

fannheyward commented May 16, 2023 •
edited
Loading

The failed test is related with should use relative pattern #3, after this test, should watch for file create is broken.

@chemzqm chemzqm merged commit 1038082 into neoclide:master Aug 31, 2023
chemzqm added a commit that referenced this pull request Aug 31, 2023
@chemzqm
commit 15c8946
05fcd1a 
15c8946 Revert "chore(package): use yarn instead"
dacd62f chore(package): use yarn instead
0e6be47 fix(package): use npm
0189ace chore(inlayHint): check nvim version
d81fde9 feat(inlayHint): inline display for nvim (#4648)
1038082 Allow watching workspaces at /tmp/some-dir (#4632)
34f5d96 refactor(glob): use latest glob module
b2ae10c fix(type): fix bad types
5385efd chore(package): require node 16.18.0
5ea8b52 chore(README): gitter url to matrix (#4520)
fc260ab fix(input): delete buffer on vim only
02c2542 fix(native): get pathstr by cursor position (#4553)
1c9c72f fix(workspaceFolder): check directory of fsPath (#4566)
b1e5d71 fix(util): check $XDG_CONFIG_HOME before use as data home (#4492)
abdb129 fix(input): bdel term buf (#4608)
c790182 chore(doc): target of diagnosticInfo
5571414 feat(diagnostic): add target to diagnosticInfo (#4642)
e4ffae5 fix(list): scrolling float preview for vim (#4647)
c5a7123 feat(data): allow languageserver.env (#4658)
44898ec fix(format): formatOnSaveTimeout config with scope (#4689)
d432de2 feat(links): only fetch links on documeng changed (#4690)
ed89997 fix: clean unused code (#4710)
4f3b4d9 feat(handler): hasProvider can accept bufnr (#4714)
18152f2 chore(package): update dependencies
bacbe49 refactor(highlighter): highligher.ts to highlighter.ts (#4730)
5423ee0 feat(completion): stop completion when navigate
29065d9 chore(doc): escape coc_status
1d36382 chore(doc): add refactor buffer section
0a2c8b8 fix: ls provider's score is equal to the default one (#4722)
fab97c7 perf: return early in around and buffer source (#4721)
eba04ac fix: autoActiavte to autoActivate, keeped to kept (#4716)
f7545f2 docs: update outdated url (#4717)
@oxalica oxalica deleted the fix/allow-tmp-subdir branch August 31, 2023 19:23
@fannheyward
Copy link
Member

@all-contributors please add @oxalica for code.

@allcontributors allcontributors bot mentioned this pull request Nov 1, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@fannheyward

I've put up a pull request to add @oxalica! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oxalica @fannheyward @chemzqm