Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare 1.6.1 #711

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Prepare 1.6.1 #711

merged 4 commits into from
Jul 16, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Jul 15, 2024 •
edited by openshift-ci bot

@jotak
NETOBSERV-1705: do not send zone/cluster labels config... (netobserv#677
d493280 
)

do not send zone/cluster labels config to the console plugin when the
related features are disabled. Else, the console plugin assumes that
they are available, regardless of the features knobs
@jotak
NETOBSERV-1731: hide metrics enable setting from form (netobserv#692)
9b07a3c 
This is to avoid confusion, since nillable bools are not managed properly in OLM forms
They can be access from YAML

A longer-term solution will be to replace all our nillable bools with
enums in a next API version
@jotak
NETOBSERV-1649: add drop cause & state labels to metrics (netobserv#676)
c28b290
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak
NETOBSERV-1734: change subnets order priority (netobserv#693)
7430e41 
Make sure auto-detected openshift labels are appended at the end of the
subnets list, so that they have lower priority. It makes it possible to
override in-cluster subnets.
@codecov Codecov
Copy link

codecov bot commented Jul 15, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.15%. Comparing base (4316b01) to head (7430e41).

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-1.6     #711      +/-   ##
===============================================
+ Coverage        66.77%   67.15%   +0.38%     
===============================================
  Files               69       70       +1     
  Lines             8088     8115      +27     
===============================================
+ Hits              5401     5450      +49     
+ Misses            2293     2273      -20     
+ Partials           394      392       -2
Flag Coverage Δ
unittests 67.15% <100.00%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controllers/consoleplugin/consoleplugin_objects.go 87.22% <100.00%> (-0.04%) ⬇️
controllers/flp/flp_pipeline_builder.go 93.12% <100.00%> (+5.76%) ⬆️
pkg/metrics/predefined_metrics.go 100.00% <100.00%> (ø)
pkg/test/util/utils.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@openshift-ci openshift-ci bot added the lgtm label Jul 15, 2024
@jotak jotak merged commit 64f0a1c into netobserv:release-1.6 Jul 16, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierCazade OlivierCazade OlivierCazade approved these changes

@msherif1234 msherif1234 Awaiting requested review from msherif1234

@Amoghrd Amoghrd Awaiting requested review from Amoghrd

@memodi memodi Awaiting requested review from memodi

Assignees

@OlivierCazade OlivierCazade

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jotak @OlivierCazade