Add SDFormat importer hooks #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemonade-dm
reviewed
Aug 8, 2023
Gems/ROS2/Code/Source/RobotImporter/SDFormat/ROS2SensorHooks.cpp
Outdated
Show resolved
Hide resolved
lemonade-dm
approved these changes
Aug 9, 2023
adamdbrw
reviewed
Aug 21, 2023
Gems/ROS2/Code/Source/RobotImporter/SDFormat/Hooks/ROS2CameraSensorHook.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/RobotImporter/SDFormat/Hooks/ROS2CameraSensorHook.cpp
Show resolved
Hide resolved
Gems/ROS2/Code/Source/RobotImporter/SDFormat/Hooks/ROS2CameraSensorHook.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/RobotImporter/SDFormat/Hooks/ROS2ImuSensorHook.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/RobotImporter/SDFormat/Hooks/ROS2GNSSSensorHook.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/RobotImporter/SDFormat/Hooks/ROS2CameraSensorHook.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/RobotImporter/SDFormat/Hooks/ROS2ImuSensorHook.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/RobotImporter/SDFormat/Hooks/ROS2LidarSensorHook.cpp
Outdated
Show resolved
Hide resolved
Gems/ROS2/Code/Source/RobotImporter/SDFormat/ROS2SensorHooks.cpp
Outdated
Show resolved
Hide resolved
lemonade-dm
reviewed
Aug 21, 2023
Gems/ROS2/Code/Source/Camera/ROS2CameraSensorEditorComponent.cpp
Outdated
Show resolved
Hide resolved
lemonade-dm
approved these changes
Aug 21, 2023
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
jhanca-robotecai
force-pushed
the
jh/sdformat_hooks
branch
from
f9ccf43 to
0a85c2e
Compare
|
This PR was rebased after #460 and #471 were merged. An additional check to ensure all required components are created in the entity was added. Moreover, the components are not duplicated anymore. This PR was tested using the implementation in https://github.com/jhanca-robotecai/o3de-extras/tree/test/jh/sdformat_hooks branch and attached UR10 model (SDFormat model with camera sensor added). ur10.zip |
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
adamdbrw
reviewed
Aug 30, 2023
Gems/ROS2/Code/Source/RobotImporter/SDFormat/Hooks/ROS2CameraSensorHook.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
spham-amzn
reviewed
Aug 30, 2023
| cameraSensor->HorizontalFov().Degree() * (cameraConfiguration.m_height / cameraConfiguration.m_width); | ||
| if (cameraConfiguration.m_width != 0) | ||
| { | ||
| cameraConfiguration.m_verticalFieldOfViewDeg = |
There was a problem hiding this comment.
What should the value of m_verticalFieldOfViewDeg be if the cameraConfiguration.m_width is zero?
There was a problem hiding this comment.
Mathematically vertical FoV for image width equal to zero would be infinity. In the practical case camera with zero width (or height) makes no sense. The parameters (including FoV) are checked later in the pipeline - this test is added to avoid software crashes while importing robots with improper parameters.
adamdbrw
approved these changes
Aug 31, 2023
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
michalpelka
approved these changes
Sep 4, 2023
mbalfour-amzn
pushed a commit
to aws-lumberyard-dev/o3de-extras
that referenced
this pull request
Sep 7, 2023
Add sensors SDF importer hooks Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
mbalfour-amzn
added a commit
that referenced
this pull request
Sep 14, 2023
…remappings (#505) * First version of adding configurable prefix lookups and substitutions. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Tests/UrdfParserTest.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/SdfAssetBuilder/SdfAssetBuilderSettings.h Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Improved asset path resolution logic and unit tests. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Add SDFormat importer hooks (#453) Add sensors SDF importer hooks Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> * use PrimitiveAssets Gem to visualize primitives (#485) Use PrimitiveAssets Gem to visualize primitives --------- Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> * Warehouse automation gem (#440) Created the warehouse automation gem, adjusted to review --------- Signed-off-by: Antoni Puch <antoni.puch@robotec.ai> * Lidar component refactor (#463) Lidar Refactor --------- Signed-off-by: Antoni Puch <antoni.puch@robotec.ai> Signed-off-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> * Added presentation of SDF messages (#491) * Added presentation of SDF messages --------- Signed-off-by: Michał Pełka <michalpelka@gmail.com> Co-authored-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> * Fix missing include. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Fix resolution of file:// prefix. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Change string to Path. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Changed PathResolver to get read in wholesale from setreg file. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * PR feedback - changed file select dir to default to last-used file. Also changes file select dir to match anything typed into the text box. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.h Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * PR feedback Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * PR feedback Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Partial revert from path back to string. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Second half of path to string revert. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Added all Path Resolver options to setreg for visibility. Improved SetFindCallback to use the full set of path resolution options. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> --------- Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Antoni Puch <antoni.puch@robotec.ai> Signed-off-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com> Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Co-authored-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> Co-authored-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Co-authored-by: Michał Pełka <michal.pelka@robotec.ai>
michalpelka
pushed a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Sep 25, 2023
Add sensors SDF importer hooks Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
michalpelka
added a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Sep 25, 2023
…remappings (o3de#505) * First version of adding configurable prefix lookups and substitutions. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Tests/UrdfParserTest.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/SdfAssetBuilder/SdfAssetBuilderSettings.h Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Improved asset path resolution logic and unit tests. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Add SDFormat importer hooks (o3de#453) Add sensors SDF importer hooks Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> * use PrimitiveAssets Gem to visualize primitives (o3de#485) Use PrimitiveAssets Gem to visualize primitives --------- Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> * Warehouse automation gem (o3de#440) Created the warehouse automation gem, adjusted to review --------- Signed-off-by: Antoni Puch <antoni.puch@robotec.ai> * Lidar component refactor (o3de#463) Lidar Refactor --------- Signed-off-by: Antoni Puch <antoni.puch@robotec.ai> Signed-off-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> * Added presentation of SDF messages (o3de#491) * Added presentation of SDF messages --------- Signed-off-by: Michał Pełka <michalpelka@gmail.com> Co-authored-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> * Fix missing include. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Fix resolution of file:// prefix. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Change string to Path. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Changed PathResolver to get read in wholesale from setreg file. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * PR feedback - changed file select dir to default to last-used file. Also changes file select dir to match anything typed into the text box. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.h Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * PR feedback Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * PR feedback Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Partial revert from path back to string. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Second half of path to string revert. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Added all Path Resolver options to setreg for visibility. Improved SetFindCallback to use the full set of path resolution options. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> --------- Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Antoni Puch <antoni.puch@robotec.ai> Signed-off-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com> Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Co-authored-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> Co-authored-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Co-authored-by: Michał Pełka <michal.pelka@robotec.ai>
michalpelka
added a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Sep 25, 2023
…remappings (o3de#505) * First version of adding configurable prefix lookups and substitutions. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Tests/UrdfParserTest.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/SdfAssetBuilder/SdfAssetBuilderSettings.h Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Improved asset path resolution logic and unit tests. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Add SDFormat importer hooks (o3de#453) Add sensors SDF importer hooks Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> * use PrimitiveAssets Gem to visualize primitives (o3de#485) Use PrimitiveAssets Gem to visualize primitives --------- Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> * Warehouse automation gem (o3de#440) Created the warehouse automation gem, adjusted to review --------- Signed-off-by: Antoni Puch <antoni.puch@robotec.ai> * Lidar component refactor (o3de#463) Lidar Refactor --------- Signed-off-by: Antoni Puch <antoni.puch@robotec.ai> Signed-off-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> * Added presentation of SDF messages (o3de#491) * Added presentation of SDF messages --------- Signed-off-by: Michał Pełka <michalpelka@gmail.com> Co-authored-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> * Fix missing include. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Fix resolution of file:// prefix. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Change string to Path. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Changed PathResolver to get read in wholesale from setreg file. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * PR feedback - changed file select dir to default to last-used file. Also changes file select dir to match anything typed into the text box. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.h Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * PR feedback Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * PR feedback Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Partial revert from path back to string. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Second half of path to string revert. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Added all Path Resolver options to setreg for visibility. Improved SetFindCallback to use the full set of path resolution options. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> --------- Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Antoni Puch <antoni.puch@robotec.ai> Signed-off-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com> Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Co-authored-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> Co-authored-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Co-authored-by: Michał Pełka <michal.pelka@robotec.ai>
michalpelka
pushed a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Sep 25, 2023
Add sensors SDF importer hooks Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
michalpelka
added a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Sep 25, 2023
…remappings (o3de#505) * First version of adding configurable prefix lookups and substitutions. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Tests/UrdfParserTest.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/SdfAssetBuilder/SdfAssetBuilderSettings.h Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Improved asset path resolution logic and unit tests. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Add SDFormat importer hooks (o3de#453) Add sensors SDF importer hooks Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> * use PrimitiveAssets Gem to visualize primitives (o3de#485) Use PrimitiveAssets Gem to visualize primitives --------- Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> * Warehouse automation gem (o3de#440) Created the warehouse automation gem, adjusted to review --------- Signed-off-by: Antoni Puch <antoni.puch@robotec.ai> * Lidar component refactor (o3de#463) Lidar Refactor --------- Signed-off-by: Antoni Puch <antoni.puch@robotec.ai> Signed-off-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> * Added presentation of SDF messages (o3de#491) * Added presentation of SDF messages --------- Signed-off-by: Michał Pełka <michalpelka@gmail.com> Co-authored-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> * Fix missing include. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Fix resolution of file:// prefix. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Change string to Path. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Changed PathResolver to get read in wholesale from setreg file. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * PR feedback - changed file select dir to default to last-used file. Also changes file select dir to match anything typed into the text box. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.h Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * PR feedback Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * PR feedback Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Partial revert from path back to string. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Second half of path to string revert. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Added all Path Resolver options to setreg for visibility. Improved SetFindCallback to use the full set of path resolution options. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> --------- Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Antoni Puch <antoni.puch@robotec.ai> Signed-off-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com> Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Co-authored-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> Co-authored-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Co-authored-by: Michał Pełka <michal.pelka@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
michalpelka
pushed a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Oct 2, 2023
Add sensors SDF importer hooks Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
michalpelka
added a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Oct 2, 2023
…remappings (o3de#505) * First version of adding configurable prefix lookups and substitutions. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Tests/UrdfParserTest.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/SdfAssetBuilder/SdfAssetBuilderSettings.h Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Improved asset path resolution logic and unit tests. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Add SDFormat importer hooks (o3de#453) Add sensors SDF importer hooks Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> * use PrimitiveAssets Gem to visualize primitives (o3de#485) Use PrimitiveAssets Gem to visualize primitives --------- Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> * Warehouse automation gem (o3de#440) Created the warehouse automation gem, adjusted to review --------- Signed-off-by: Antoni Puch <antoni.puch@robotec.ai> * Lidar component refactor (o3de#463) Lidar Refactor --------- Signed-off-by: Antoni Puch <antoni.puch@robotec.ai> Signed-off-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> * Added presentation of SDF messages (o3de#491) * Added presentation of SDF messages --------- Signed-off-by: Michał Pełka <michalpelka@gmail.com> Co-authored-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> * Fix missing include. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Fix resolution of file:// prefix. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Change string to Path. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Changed PathResolver to get read in wholesale from setreg file. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * PR feedback - changed file select dir to default to last-used file. Also changes file select dir to match anything typed into the text box. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.h Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * PR feedback Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * PR feedback Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Partial revert from path back to string. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Second half of path to string revert. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Added all Path Resolver options to setreg for visibility. Improved SetFindCallback to use the full set of path resolution options. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> --------- Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Antoni Puch <antoni.puch@robotec.ai> Signed-off-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com> Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Co-authored-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> Co-authored-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Co-authored-by: Michał Pełka <michal.pelka@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
michalpelka
pushed a commit
that referenced
this pull request
Oct 3, 2023
Add sensors SDF importer hooks Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
michalpelka
added a commit
that referenced
this pull request
Oct 3, 2023
…remappings (#505) * First version of adding configurable prefix lookups and substitutions. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Tests/UrdfParserTest.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/SdfAssetBuilder/SdfAssetBuilderSettings.h Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Improved asset path resolution logic and unit tests. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Add SDFormat importer hooks (#453) Add sensors SDF importer hooks Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> * use PrimitiveAssets Gem to visualize primitives (#485) Use PrimitiveAssets Gem to visualize primitives --------- Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> * Warehouse automation gem (#440) Created the warehouse automation gem, adjusted to review --------- Signed-off-by: Antoni Puch <antoni.puch@robotec.ai> * Lidar component refactor (#463) Lidar Refactor --------- Signed-off-by: Antoni Puch <antoni.puch@robotec.ai> Signed-off-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> * Added presentation of SDF messages (#491) * Added presentation of SDF messages --------- Signed-off-by: Michał Pełka <michalpelka@gmail.com> Co-authored-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> * Fix missing include. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Fix resolution of file:// prefix. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Change string to Path. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Changed PathResolver to get read in wholesale from setreg file. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * PR feedback - changed file select dir to default to last-used file. Also changes file select dir to match anything typed into the text box. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.h Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Update Gems/ROS2/Code/Source/RobotImporter/Utils/RobotImporterUtils.cpp Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * PR feedback Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * PR feedback Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Partial revert from path back to string. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Second half of path to string revert. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> * Added all Path Resolver options to setreg for visibility. Improved SetFindCallback to use the full set of path resolution options. Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> --------- Signed-off-by: Mike Balfour <82224783+mbalfour-amzn@users.noreply.github.com> Signed-off-by: Jan Hanca <jan.hanca@robotec.ai> Signed-off-by: Antoni Puch <antoni.puch@robotec.ai> Signed-off-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com> Co-authored-by: lumberyard-employee-dm <56135373+lumberyard-employee-dm@users.noreply.github.com> Co-authored-by: Jan Hanca <134940295+jhanca-robotecai@users.noreply.github.com> Co-authored-by: Antoni-Robotec <138497503+Antoni-Robotec@users.noreply.github.com> Co-authored-by: Adam Dąbrowski <adam.dabrowski@robotec.ai> Co-authored-by: Michał Pełka <michal.pelka@robotec.ai> Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds SDFormat importer hooks for
imu: mapped toROS2ImuSensorComponentlidar: mapped toROS2LidarSensorComponentnavsat: mapped toROS2GNSSSensorSome modifications in tests to verify the change are included.
Finally, this change applies clang-format to
LidarTemplateUtils.cppfile, which was skipped previously.