add jvm daemon threads instrumentation #6561

tuhao1020 · 2022-09-08T15:11:06Z

Signed-off-by: HaoTu haotu@alauda.io

Signed-off-by: HaoTu <haotu@alauda.io>

trask · 2022-09-08T22:03:58Z

I wonder if this would make sense as a boolean daemon attribute (dimension) on process.runtime.jvm.threads.count?

cc @jack-berg @jonatan-ivanov

jack-berg · 2022-09-08T22:14:10Z

I think that makes a lot of sense @trask. Can compute daemon vs. non-daemon with:

daemon: ThreadMXBead#getDaemonThreadCount()
non-daemon: ThreadMXBead#getThreadCount() - ThreadMXBead#getDaemonThreadCount()

Signed-off-by: HaoTu <haotu@alauda.io>

jonatan-ivanov · 2022-09-10T01:02:04Z

I agree, especially because that way it is easy to aggregate the daemon + non-daemon threads.

tuhao1020 · 2022-09-13T02:16:56Z

@trask @jack-berg @jonatan-ivanov Expect the following？

process.runtime.jvm.threads.count{daemon=true} 2
process.runtime.jvm.threads.count{daemon=false} 5

Should consider adding ThreadMXBean.getPeakThreadCount?

jonatan-ivanov · 2022-09-13T06:24:36Z

Yes, if you have 7 threads, 2 of them are daemon and 5 of them are not.

…eads Signed-off-by: HaoTu <haotu@alauda.io>

Signed-off-by: HaoTu <haotu@alauda.io>

tuhao1020 · 2022-09-13T07:52:17Z

@trask

FILE: ./docs/supported-libraries.md
ERROR: 1 dead links found!
  [x] https://www.ibm.com/cloud/websphere-application-server → Status: 404

Signed-off-by: HaoTu <haotu@alauda.io>

tuhao1020 · 2022-09-15T16:15:40Z

@trask @jack-berg @jonatan-ivanov Can anyeone help to review the code?

* Use micrometer library instrumentation in agent * PR feedback

* Stabilize instrumentation-api and introduce jApiCmp checks * Update Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* Move extractFromRequest() to internal * Javadoc

* Rename ErrorCauseExtractor.jdk() to ErrorCauseExtractor.getDefault() * jApiCmp

* Encapsulate actual logging implementation better * Apply suggestions from code review Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> * code review comments * revert to the old slf4j package name * spotless Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* Fix instrumentation-api-semconv packages * Move test Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

….1 (#6596) Bumps com.gradle.common-custom-user-data-gradle-plugin from 1.8 to 1.8.1. --- updated-dependencies: - dependency-name: com.gradle.common-custom-user-data-gradle-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add kafka client metrics to the javaagent instrumentation * Don't override user-set metrics reporter * Add kafka metric reporter config property

…der (#6587) * Use ConditionalResourceProvider in the Spring Boot service name provider * make it a bit simpler * add order=100 * add comment * spellcheck

* Add experimental span attribute job.system * spring-batch

* Optimize ReactorNettyNetClientAttributesGetter * Update

* Add code attributes for Logback * Rename property * Add a note about performance * Add null check on file name * Add check on line number * Fix test following new behavior * spotless * Update instrumentation/logback/logback-appender-1.0/library/src/main/java/io/opentelemetry/instrumentation/logback/appender/v1_0/internal/LoggingEventMapper.java Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com> * Fix test * Adapt test for Java 18 * codenarc * Test fix Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>

* Reduce dependency on simpleName * Move ClassNames to internal * Javadoc * Updates * Fix * Spotless * Rename * Add test

* Fix latest dep builds * fix couchbase 3.2 too * codenarc * fix jedis 4.0 tests * fix restlet 2.0 tests * fix armeria tests * Update instrumentation/couchbase/couchbase-3.2/javaagent/src/test/groovy/CouchbaseClient32Test.groovy Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* Update version to 1.19.0-SNAPSHOT * Update CHANGELOG.md Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* Add resource providers * Use autoservice annotation

Signed-off-by: HaoTu <haotu@alauda.io> #6561 has closed Signed-off-by: HaoTu <haotu@alauda.io>

…etry#6635) Signed-off-by: HaoTu <haotu@alauda.io> open-telemetry#6561 has closed Signed-off-by: HaoTu <haotu@alauda.io>

add jvm daemon threads instrumentation

d61af21

Signed-off-by: HaoTu <haotu@alauda.io>

tuhao1020 requested a review from a team September 8, 2022 15:11

HaoTu added 3 commits September 9, 2022 00:39

reformat

8ac94a4

Signed-off-by: HaoTu <haotu@alauda.io>

update unit test

1577f76

Signed-off-by: HaoTu <haotu@alauda.io>

update unit test

c657677

Signed-off-by: HaoTu <haotu@alauda.io>

reformat

738e02c

Signed-off-by: HaoTu <haotu@alauda.io>

HaoTu added 4 commits September 13, 2022 15:01

Use daemon attribute to distinguish between daemon and non-daemon thr…

2b528fc

…eads Signed-off-by: HaoTu <haotu@alauda.io>

update unit test

f5fafcd

Signed-off-by: HaoTu <haotu@alauda.io>

import package

8972d74

Signed-off-by: HaoTu <haotu@alauda.io>

update example for process.runtime.jvm.threads.count

8008178

Signed-off-by: HaoTu <haotu@alauda.io>

update websphere link

8ffcaa2

Signed-off-by: HaoTu <haotu@alauda.io>

trask and others added 12 commits September 16, 2022 00:43

Add mongo sanitization configuration (#6541)

e10bb59

Use micrometer library instrumentation in agent (#6560)

27ffc6a

* Use micrometer library instrumentation in agent * PR feedback

Add gradle plugin for SDK extensions (#6558)

afe323f

Add release cadence (#6565)

f21aa70

Remove a method from instrumenter api (#6570)

ad44de9

Stabilize instrumentation-api and introduce jApiCmp checks (#6566)

a95f178

* Stabilize instrumentation-api and introduce jApiCmp checks * Update Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Update to otel 1.18.0 (#6575)

654cd5e

Introduce non-alpha bom (#6576)

e259a1d

Move extractFromRequest() to internal (#6585)

664ec82

* Move extractFromRequest() to internal * Javadoc

Rename ErrorCauseExtractor.jdk() to getDefault() (#6580)

ef2792f

* Rename ErrorCauseExtractor.jdk() to ErrorCauseExtractor.getDefault() * jApiCmp

Rename two package-private instrumenter-api classes (#6579)

29bd87e

Fix jApiCmp CI check (#6577)

24cc82d

Mateusz Rzeszutek and others added 23 commits September 16, 2022 00:43

Remove agent's Ordered interface and use the SDK one (#6589)

b3c938b

Fix instrumentation-api-semconv packages (#6590)

4b68c1b

* Fix instrumentation-api-semconv packages * Move test Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Add kafka client metrics to the javaagent instrumentation (#6533)

fb07c44

* Add kafka client metrics to the javaagent instrumentation * Don't override user-set metrics reporter * Add kafka metric reporter config property

Use ConditionalResourceProvider in the Spring Boot service name provi…

e04464c

…der (#6587) * Use ConditionalResourceProvider in the Spring Boot service name provider * make it a bit simpler * add order=100 * add comment * spellcheck

Add experimental span attribute job.system (#6586)

876a562

* Add experimental span attribute job.system * spring-batch

Optimize ReactorNettyNetClientAttributesGetter (#6600)

09511c9

* Optimize ReactorNettyNetClientAttributesGetter * Update

Remove external usages of ClassNames (and move it to internal) (#6584)

f84b933

* Reduce dependency on simpleName * Move ClassNames to internal * Javadoc * Updates * Fix * Spotless * Rename * Add test

Fix finatra latest deps test (#6616)

6e49edb

Add dependency from alpha bom to stable bom (#6611)

e9827ef

Some assertions refactoring (#6618)

68ef38b

Fix spring boot @WithSpan handling (#6619)

e1d2f42

Convert logback test to Java (#6613)

618846c

Reactor instrumentation: do not make root context current (#6593)

b7da40f

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Update change log for 1.18.0 release (#6564)

0b90409

Update version to 1.19.0-SNAPSHOT (#6623)

b58d43c

* Update version to 1.19.0-SNAPSHOT * Update CHANGELOG.md Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Fix examples in main branch (#6626)

fb92615

Add resource providers (#6574)

bc1e179

* Add resource providers * Use autoservice annotation

Fix operator pull request (#6629)

194af46

Fix at mention in operator pr (#6630)

169ffa1

tuhao1020 closed this by deleting the head repository Sep 15, 2022

tuhao1020 mentioned this pull request Sep 16, 2022

add daemon attribute to process.runtime.jvm.threads.count #6635

Merged

trask pushed a commit that referenced this pull request Sep 24, 2022

add daemon attribute to process.runtime.jvm.threads.count (#6635)

878dfc3

Signed-off-by: HaoTu <haotu@alauda.io> #6561 has closed Signed-off-by: HaoTu <haotu@alauda.io>

jonatan-ivanov mentioned this pull request Jun 15, 2023

REQUEST: New membership for jonatan-ivanov open-telemetry/community#1548

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add jvm daemon threads instrumentation #6561

add jvm daemon threads instrumentation #6561

tuhao1020 commented Sep 8, 2022

trask commented Sep 8, 2022

jack-berg commented Sep 8, 2022

jonatan-ivanov commented Sep 10, 2022

tuhao1020 commented Sep 13, 2022 •

edited

Loading

jonatan-ivanov commented Sep 13, 2022

tuhao1020 commented Sep 13, 2022

tuhao1020 commented Sep 15, 2022

add jvm daemon threads instrumentation #6561

add jvm daemon threads instrumentation #6561

Conversation

tuhao1020 commented Sep 8, 2022

trask commented Sep 8, 2022

jack-berg commented Sep 8, 2022

jonatan-ivanov commented Sep 10, 2022

tuhao1020 commented Sep 13, 2022 • edited Loading

jonatan-ivanov commented Sep 13, 2022

tuhao1020 commented Sep 13, 2022

tuhao1020 commented Sep 15, 2022

tuhao1020 commented Sep 13, 2022 •

edited

Loading