Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUTO] [2.x] Added bwc version 2.5.1. #5992

Closed
wants to merge 68 commits into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

I've noticed that a new tag 2.5.0 was pushed, and added a bwc version 2.5.1.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kotwanikunal
Copy link
Member

Gradle Check (Jenkins) Run Completed with:

AILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':distribution:bwc:bugfix:buildBwcLinuxTar'.
> Building 2.5.1 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/bugfix/build/bwc/checkout-2.5/distribution/archives/linux-tar/build/distributions/opensearch-min-2.5.1-SNAPSHOT-linux-x64.tar.gz

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.discovery.StableClusterManagerDisruptionIT.testStaleClusterManagerNotHijackingMajority
      1 org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testIndexCreateBlockWithAReadOnlyBlock
      1 org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testIndexCreateBlockIsRemovedWhenAnyNodesNotExceedHighWatermark

Signed-off-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
@kotwanikunal kotwanikunal force-pushed the create-pull-request/patch-2.x branch from 3c6ee5a to 739e362 Compare January 24, 2023 23:59
kotwanikunal and others added 23 commits January 24, 2023 16:28
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
…ts API (#5871)

* [Backport 2.x] Add throttling stats in nodes stats API

Signed-off-by: Dhwanil Patel <dhwanip@amazon.com>
…uploading translog files (#5868) (#5900)

* Use stream that supports mark and reset for translog upload

Signed-off-by: Sachin Kale <kalsac@amazon.com>
* Add builder for EngineConfig

Signed-off-by: Sachin Kale <kalsac@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Co-authored-by: Frank Lou <107960841+mloufra@users.noreply.github.com>
…5876) (#5878)

* Bump reactor-netty from 1.1.1 to 1.1.2 in /plugins/repository-azure

Bumps [reactor-netty](https://github.com/reactor/reactor-netty) from 1.1.1 to 1.1.2.
- [Release notes](https://github.com/reactor/reactor-netty/releases)
- [Commits](reactor/reactor-netty@v1.1.1...v1.1.2)

---
updated-dependencies:
- dependency-name: io.projectreactor.netty:reactor-netty
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Updating SHAs

Signed-off-by: dependabot[bot] <support@github.com>

* Update changelog

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
… from #5812 (#5922)

* Backporting unit tests for IndexMetadataGenerations from #5812

Signed-off-by: Kartik Ganesh <gkart@amazon.com>

* Fix javadoc for getExtendedCompatibilitySnapshotVersion

Signed-off-by: Kartik Ganesh <gkart@amazon.com>

Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Signed-off-by: Marc Handalian <handalm@amazon.com>

Signed-off-by: Marc Handalian <handalm@amazon.com>
(cherry picked from commit 2858bd9)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Marc Handalian <handalm@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Add artifacts from benchmarks to .gitignore

Signed-off-by: Peter Nied <petern@amazon.com>

* Update the section title

Signed-off-by: Peter Nied <petern@amazon.com>

Signed-off-by: Peter Nied <petern@amazon.com>
(cherry picked from commit 6f2c125)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Peter Nied <petern@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This change introduces a static store "settings"
in FeatureFlags.java file to enable isEnabled method to
fetch flag settings defined in opensearch.yml.

Signed-off-by: Nagaraj Tantri <nagarajtantri@gmail.com>

Signed-off-by: Nagaraj Tantri <nagarajtantri@gmail.com>

Signed-off-by: Nagaraj Tantri <nagarajtantri@gmail.com>
Co-authored-by: Nagaraj Tantri <nagarajtantri@gmail.com>
…5833) (#5911)

Signed-off-by: Mani <singh.mani1231@gmail.com>
(cherry picked from commit db30439)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Mani <singh.mani1231@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
….x. (#5945)

* [Segment Replication] Add snapshot and restore tests for segment replication feature (#3993)

* [Segment Replication] Add snapshots tests with segment replication enabled

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Fix spotless failures

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Add changelog entry, address review comments, add failover test

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Fix spotless failures

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Address review comments 2

Signed-off-by: Suraj Singh <surajrider@gmail.com>

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Remove changelog update.

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Mute flaky test testStartReplicaAfterPrimaryIndexesDocs. (#5714)

Signed-off-by: Marc Handalian <handalm@amazon.com>

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Fix flaky Segment Replication test testStartReplicaAfterPrimaryIndexesDocs. (#5722)

* Fix flaky SR test testStartReplicaAfterPrimaryIndexesDocs.

This test was failing because we are validating post recovery if a shard is able to perform segrep while also performing validation if a passed in checkopint.  In the post recovery test this checkpoint is always empty, yet the shard will be ahead of this checkpoint after docs are indexed.  This change differentiates shard validation from checkpoint validation.

Signed-off-by: Marc Handalian <handalm@amazon.com>

Fix spotless.

Signed-off-by: Marc Handalian <handalm@amazon.com>

Fix testIsSegmentReplicationAllowed_WrongEngineType.

Signed-off-by: Marc Handalian <handalm@amazon.com>

Update warn logs in isSegmentReplicationAllowed.

Signed-off-by: Marc Handalian <handalm@amazon.com>

* PR feedback.

Signed-off-by: Marc Handalian <handalm@amazon.com>

Signed-off-by: Marc Handalian <handalm@amazon.com>

* [Segment Replication] Mute flaky tests (#5739)

Signed-off-by: Suraj Singh <surajrider@gmail.com>

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* [Segment Replication] Mute flaky tests (#5742)

Signed-off-by: Suraj Singh <surajrider@gmail.com>

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Fix spotless.

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Muting flaky SegmentReplication ITs. (#5700)

Signed-off-by: Marc Handalian <handalm@amazon.com>

Signed-off-by: Marc Handalian <handalm@amazon.com>

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Marc Handalian <handalm@amazon.com>
Co-authored-by: Suraj Singh <surajrider@gmail.com>
Previously this test required the feature flag to be set as a system
property, otherwise the test did nothing. This change programmatically
sets the feature flag to allow the test to run during all builds.
I ran the following command overnight (probably at least a couple
thousand iterations) on a dev machine and saw no failures, so I have
confidence this test is not flaky:

```
run-one-until-failure ./gradlew ':server:internalClusterTest' --tests "org.opensearch.snapshots.SearchableSnapshotIT"
```

Signed-off-by: Andrew Ross <andrross@amazon.com>

Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit 901cd69)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…#5944)

This commit applies any feature flags specified by a child class
override of the featureFlagSettings() method by default. The result is
that test implementations do not have to manually specify the
featureFlagSettings when creating test nodes.

Signed-off-by: Andrew Ross <andrross@amazon.com>

Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit 7a511dd)
…5954)

Signed-off-by: Suraj Singh <surajrider@gmail.com>

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit 493eae8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…icationTarget (#5955)

* Use ReplicationFailedException instead of OpensearchException in Repl… (#4725)

* Use ReplicationFailedException instead of OpensearchException in ReplicationTarget

Signed-off-by: Ayush Kataria <ayushkataria97@gmail.com>

* CHANGELOG.md updated

Signed-off-by: Ayush Kataria <ayushkataria97@gmail.com>

* test fixes

Signed-off-by: Ayush Kataria <ayushkataria97@gmail.com>

* spotless fix

Signed-off-by: Ayush Kataria <ayushkataria97@gmail.com>

* spotless fix

Signed-off-by: Ayush Kataria <ayushkataria97@gmail.com>

* fixes for failing test as suggested in PR comments

Signed-off-by: Ayush Kataria <ayushkataria97@gmail.com>

Signed-off-by: Ayush Kataria <ayushkataria97@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update SegmentReplicationListener to use ReplicationFailedException

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Spotless fix

Signed-off-by: Suraj Singh <surajrider@gmail.com>

Signed-off-by: Ayush Kataria <ayushkataria97@gmail.com>
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Co-authored-by: Ayush Kataria <31301636+ayushKataria@users.noreply.github.com>
…ion (#5344) (#5959)

* [Segment Replication] Update peer recovery logic for segment replication

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Add integration test for indexing during relocation

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Address review comments

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Spotless check apply fixes & one failing unit test

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Delay force segment replication till relocation handoff

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Spotless fix

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Unit test fix

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Address review comment, move force segrep sync handler to SegRepTargetService

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Resolve conflicts and enabled tests

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Spotless fix

Signed-off-by: Suraj Singh <surajrider@gmail.com>

Signed-off-by: Suraj Singh <surajrider@gmail.com>

Signed-off-by: Suraj Singh <surajrider@gmail.com>
…ility class (#5947) (#5961)

This copies Apache Lucene's o.a.l.util.SetOnce to o.opensearch.common.SetOnce in
the opensearch-core library and refactors all opensearch classes from the lucene
implementation to the local opensearch implementation. This accomplishes three
objectives: 1. remove the dependency on lucene-core library for classes that
only import this one lucene utility class, 2. shield opensearch core dependency
on this class from any upstream breaking changes, 3. further decouples other
foundation classes from third party libraries so they can be refactored from the
server module into opensearch support libraries.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
I feel like I'm tilting at windmills here, but this brings the 2.x
CHANGELOG mostly in line with what is on main. There are a couple
changes on main that pending backports to 2.x, but those entries will go
here only when the changes are actually backported.

Signed-off-by: Andrew Ross <andrross@amazon.com>
* Add update settings allowlist for searchable snapshot

Allow search related settings to be updated for searchable snapshots.

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

* Update Changelog

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

* Add feature flag check

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

* Use set instead of string arrays for allowed list

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

* Update Changelog

Signed-off-by: Rabi Panda <adnapibar@gmail.com>

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
(cherry picked from commit 011ff63)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Rabi Panda <adnapibar@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
#5977)

Signed-off-by: Poojita Raj <poojiraj@amazon.com>

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
(cherry picked from commit 988284a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Kunal Kotwani <kkotwani@amazon.com>
@kotwanikunal kotwanikunal force-pushed the create-pull-request/patch-2.x branch from 9a27d2b to 1d97152 Compare January 25, 2023 00:29
@kotwanikunal kotwanikunal mentioned this pull request Jan 25, 2023
6 tasks
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@kotwanikunal kotwanikunal deleted the create-pull-request/patch-2.x branch January 25, 2023 00:38
@kotwanikunal kotwanikunal restored the create-pull-request/patch-2.x branch January 25, 2023 00:38
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.gradle.BuildPluginIT.testInsecureIvyRepository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.