fix: yurt-iot-dock cannot be dynamically deployed in platformadmin #1679
Conversation
|
@LavenderQAQ: GitHub didn't allow me to assign the following users: your_reviewer. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @Rui-Gan |
|
@LavenderQAQ: GitHub didn't allow me to assign the following users: Rui-Gan. Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LavenderQAQ
force-pushed
the
fix/framework-sync-iotdock
branch
from
d422b7e to
399392c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1679 +/- ##
=======================================
Coverage 52.79% 52.79%
=======================================
Files 160 160
Lines 18725 18725
=======================================
Hits 9886 9886
Misses 7928 7928
Partials 911 911
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: LavenderQAQ <lavenderqaq.cs@gmail.com>
LavenderQAQ
changed the title
LavenderQAQ
force-pushed
the
fix/framework-sync-iotdock
branch
from
399392c to
0ec4131
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
/lgtm |
|
@Rui-Gan: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LavenderQAQ, rambohe-ch, Rui-Gan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…fix_calico * 'master' of https://github.com/openyurtio/openyurt: Add status info to YurtAppSet/YurtAppDaemon (openyurtio#1702) fix: add the logic of removing the finalizer (openyurtio#1695) Fix work dir nested `yurthub/yurthub` (openyurtio#1693) Add yurtappoverrider (openyurtio#1684) modify the logic for judging static pods and combine the utils for pod and node (openyurtio#1689) chore: slice loop replace (openyurtio#1690) unified expression about DaemonSet (openyurtio#1698) improve controller names (openyurtio#1687) add gateway public service controller (openyurtio#1685) feat: add token format checking to yurtadm join process (openyurtio#1681) add gateway internal service controller (openyurtio#1677) fix: yurt-iot-dock cannot be dynamically deployed in platformadmin (openyurtio#1679) unserve v1alpha1 version of platformadmin crd (openyurtio#1659)
What type of PR is this?
/kind bug
/sig iot
What this PR does / why we need it:
Because the
yurt-iot-dockis an internal component ofopenyurtand is not in the standard configuration collected by theauto-collector, a separate decision for theyurt-iot-dockis added when calculating the required components.Special notes for your reviewer:
Does this PR introduce a user-facing change?
other Note