Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix work dir nested yurthub/yurthub #1693

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

luc99hen
Copy link
Member

@luc99hen luc99hen commented Sep 6, 2023

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

We expect Yurthub's workdir to be /var/lib/yurthub. Currently, it is set to /var/lib/yurthub/yurthub because options.RootDir=/var/lib/yurthub by default, which is misleading for end users.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@luc99hen: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

What this PR does / why we need it:

We expect Yurthub's workdir to be /var/lib/yurthub. Currently, it is set to /var/lib/yurthub/yurthub which is misleading for end users.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added the kind/bug kind/bug label Sep 6, 2023
@openyurt-bot openyurt-bot added the size/XS size/XS: 0-9 label Sep 6, 2023
@openyurt-bot openyurt-bot added size/S size/S 10-29 and removed size/XS size/XS: 0-9 labels Sep 11, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #1693 (5d8d39d) into master (2ed7f0f) will decrease coverage by 0.03%.
Report is 31 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1693      +/-   ##
==========================================
- Coverage   51.66%   51.64%   -0.03%     
==========================================
  Files         145      163      +18     
  Lines       17011    19748    +2737     
==========================================
+ Hits         8788    10198    +1410     
- Misses       7407     8595    +1188     
- Partials      816      955     +139     
Flag Coverage Δ
unittests 51.64% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/yurthub/certificate/manager/manager.go 79.10% <100.00%> (+0.64%) ⬆️

... and 125 files with indirect coverage changes

@luc99hen
Copy link
Member Author

@rambohe-ch fixed

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luc99hen, rambohe-ch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added the approved approved label Sep 14, 2023
@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot openyurt-bot added the lgtm lgtm label Sep 14, 2023
@openyurt-bot openyurt-bot merged commit 893f117 into openyurtio:master Sep 14, 2023
14 of 15 checks passed
luckymrwang added a commit to luckymrwang/openyurt that referenced this pull request Sep 20, 2023
…fix_calico

* 'master' of https://github.com/openyurtio/openyurt:
  Add status info to YurtAppSet/YurtAppDaemon (openyurtio#1702)
  fix: add the logic of removing the finalizer (openyurtio#1695)
  Fix work dir nested `yurthub/yurthub` (openyurtio#1693)
  Add yurtappoverrider (openyurtio#1684)
  modify the logic for judging static pods and combine the utils for pod and node (openyurtio#1689)
  chore: slice loop replace (openyurtio#1690)
  unified expression about DaemonSet (openyurtio#1698)
  improve controller names (openyurtio#1687)
  add gateway public service controller (openyurtio#1685)
  feat: add token format checking to yurtadm join process (openyurtio#1681)
  add gateway internal service controller (openyurtio#1677)
  fix: yurt-iot-dock cannot be dynamically deployed in platformadmin (openyurtio#1679)
  unserve v1alpha1 version of platformadmin crd (openyurtio#1659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/bug kind/bug lgtm lgtm size/S size/S 10-29
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants