Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve controller names #1687

Merged

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind enhancement

What this PR does / why we need it:

  1. improve controller names and move all controller names definition into cmd/yurt-manager/app/names
  2. add controller name alias
  3. remove IsControllerEnabled util funcs and import k8s.io/controller-manager
  4. add controllers parameter validate and applyTo

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@openyurt-bot
Copy link
Collaborator

@rambohe-ch: GitHub didn't allow me to assign the following users: your_reviewer.

Note that only openyurtio members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind enhancement

What this PR does / why we need it:

  1. improve controller names and move all controller names definition into cmd/yurt-manager/app/names
  2. add controller name alias
  3. remove IsControllerEnabled util funcs and import k8s.io/controller-manager
  4. add controllers parameter validate and applyTo

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openyurt-bot openyurt-bot added approved approved size/XL size/XL: 500-999 labels Sep 3, 2023
@codecov
Copy link

codecov bot commented Sep 3, 2023

Codecov Report

Merging #1687 (31befda) into master (1a5366b) will decrease coverage by 0.04%.
The diff coverage is 25.71%.

@@            Coverage Diff             @@
##           master    #1687      +/-   ##
==========================================
- Coverage   51.79%   51.75%   -0.04%     
==========================================
  Files         164      163       -1     
  Lines       19729    19716      -13     
==========================================
- Hits        10218    10204      -14     
  Misses       8542     8542              
- Partials      969      970       +1     
Flag Coverage Δ
unittests 51.75% <25.71%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...r/controller/csrapprover/csrapprover_controller.go 26.84% <0.00%> (ø)
...ntroller/yurtappdaemon/yurtappdaemon_controller.go 19.53% <0.00%> (+0.06%) ⬆️
...ger/controller/yurtappset/yurtappset_controller.go 47.08% <0.00%> (ø)
...rdinator/delegatelease/delegatelease_controller.go 22.48% <0.00%> (ø)
.../daemonpodupdater/daemon_pod_updater_controller.go 29.80% <33.33%> (ø)
...manager/controller/nodepool/nodepool_controller.go 46.73% <33.33%> (ø)
...yurtmanager/controller/raven/dns/dns_controller.go 30.06% <33.33%> (ø)
...rnalservice/gateway_internal_service_controller.go 48.14% <33.33%> (ø)
...r/raven/gatewaypickup/gateway_pickup_controller.go 24.89% <33.33%> (ø)
...publicservice/gateway_public_service_controller.go 39.14% <33.33%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

@rambohe-ch rambohe-ch force-pushed the improve-controller-names branch from d3773f6 to 31befda Compare September 3, 2023 14:49
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.5% 3.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot merged commit 8b8c6e1 into openyurtio:master Sep 4, 2023
luckymrwang added a commit to luckymrwang/openyurt that referenced this pull request Sep 20, 2023
…fix_calico

* 'master' of https://github.com/openyurtio/openyurt:
  Add status info to YurtAppSet/YurtAppDaemon (openyurtio#1702)
  fix: add the logic of removing the finalizer (openyurtio#1695)
  Fix work dir nested `yurthub/yurthub` (openyurtio#1693)
  Add yurtappoverrider (openyurtio#1684)
  modify the logic for judging static pods and combine the utils for pod and node (openyurtio#1689)
  chore: slice loop replace (openyurtio#1690)
  unified expression about DaemonSet (openyurtio#1698)
  improve controller names (openyurtio#1687)
  add gateway public service controller (openyurtio#1685)
  feat: add token format checking to yurtadm join process (openyurtio#1681)
  add gateway internal service controller (openyurtio#1677)
  fix: yurt-iot-dock cannot be dynamically deployed in platformadmin (openyurtio#1679)
  unserve v1alpha1 version of platformadmin crd (openyurtio#1659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm size/XL size/XL: 500-999
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants