Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add token format checking to yurtadm join process #1681

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

YTGhost
Copy link
Member

@YTGhost YTGhost commented Aug 27, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #1672

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?


other Note

Signed-off-by: Liang Deng <283304489@qq.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 27, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.7% 5.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Merging #1681 (d2d1a49) into master (68d4079) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1681      +/-   ##
==========================================
- Coverage   52.79%   52.78%   -0.01%     
==========================================
  Files         160      160              
  Lines       18725    18728       +3     
==========================================
  Hits         9886     9886              
- Misses       7928     7930       +2     
- Partials      911      912       +1     
Flag Coverage Δ
unittests 52.78% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/yurtadm/cmd/join/join.go 57.75% <0.00%> (-0.58%) ⬇️

@YTGhost
Copy link
Member Author

YTGhost commented Aug 29, 2023

@rambohe-ch PTAL

@rambohe-ch
Copy link
Member

/lgtm

@openyurt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rambohe-ch, YTGhost

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openyurt-bot openyurt-bot added lgtm lgtm approved approved labels Aug 31, 2023
@openyurt-bot openyurt-bot merged commit 16e3a34 into openyurtio:master Aug 31, 2023
12 of 15 checks passed
luckymrwang added a commit to luckymrwang/openyurt that referenced this pull request Sep 20, 2023
…fix_calico

* 'master' of https://github.com/openyurtio/openyurt:
  Add status info to YurtAppSet/YurtAppDaemon (openyurtio#1702)
  fix: add the logic of removing the finalizer (openyurtio#1695)
  Fix work dir nested `yurthub/yurthub` (openyurtio#1693)
  Add yurtappoverrider (openyurtio#1684)
  modify the logic for judging static pods and combine the utils for pod and node (openyurtio#1689)
  chore: slice loop replace (openyurtio#1690)
  unified expression about DaemonSet (openyurtio#1698)
  improve controller names (openyurtio#1687)
  add gateway public service controller (openyurtio#1685)
  feat: add token format checking to yurtadm join process (openyurtio#1681)
  add gateway internal service controller (openyurtio#1677)
  fix: yurt-iot-dock cannot be dynamically deployed in platformadmin (openyurtio#1679)
  unserve v1alpha1 version of platformadmin crd (openyurtio#1659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved kind/feature kind/feature lgtm lgtm size/S size/S 10-29
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Add token format checking to yurtadm join process
3 participants