Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(linter): add suggestion for no-console #4312

Merged
merged 1 commit into from
Nov 21, 2024
Merged

feat(linter): add suggestion for no-console #4312

merged 1 commit into from
Nov 21, 2024

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Jul 17, 2024 •
edited
Loading

Part of #4179

@graphite-app Graphite App
Copy link

graphite-app bot commented Jul 17, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic A-ast Area - AST labels Jul 17, 2024
This was referenced Jul 17, 2024
Merged
Merged
@DonIsaac Graphite App
Copy link
Contributor Author

DonIsaac commented Jul 17, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@DonIsaac DonIsaac marked this pull request as ready for review July 17, 2024 03:26
@DonIsaac DonIsaac requested a review from mysteryven July 17, 2024 03:28
@DonIsaac DonIsaac force-pushed the don/07-12-feat_linter_support_suggestions_and_dangerous_fixes branch from accf395 to e4ff8bd Compare July 17, 2024 03:29
@DonIsaac DonIsaac force-pushed the don/07-16-feat_linter_add_suggestion_for_no-console branch from 58401a5 to b08057e Compare July 17, 2024 03:29
@DonIsaac DonIsaac force-pushed the don/07-12-feat_linter_support_suggestions_and_dangerous_fixes branch from e4ff8bd to b2f6b65 Compare July 17, 2024 03:31
@DonIsaac DonIsaac force-pushed the don/07-16-feat_linter_add_suggestion_for_no-console branch from b08057e to a718e59 Compare July 17, 2024 03:31
@DonIsaac DonIsaac added the C-enhancement Category - New feature or request label Jul 17, 2024
@DonIsaac DonIsaac force-pushed the don/07-16-feat_linter_add_suggestion_for_no-console branch from a718e59 to cccc9d9 Compare July 17, 2024 03:38
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 17, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #4312 will not alter performance

Comparing don/07-16-feat_linter_add_suggestion_for_no-console (849489e) with main (3d66929)

Summary

✅ 30 untouched benchmarks

@DonIsaac DonIsaac force-pushed the don/07-16-feat_linter_add_suggestion_for_no-console branch from cccc9d9 to d3ffe0f Compare July 17, 2024 04:21
@DonIsaac DonIsaac force-pushed the don/07-12-feat_linter_support_suggestions_and_dangerous_fixes branch from b2f6b65 to a13ee6f Compare July 17, 2024 14:58
@DonIsaac DonIsaac force-pushed the don/07-16-feat_linter_add_suggestion_for_no-console branch 2 times, most recently from 0d709cb to c8680cc Compare July 17, 2024 15:03
@DonIsaac DonIsaac force-pushed the don/07-12-feat_linter_support_suggestions_and_dangerous_fixes branch from a13ee6f to e17aedc Compare July 17, 2024 15:20
@DonIsaac DonIsaac force-pushed the don/07-16-feat_linter_add_suggestion_for_no-console branch from c8680cc to 8e60009 Compare July 17, 2024 15:20
@DonIsaac DonIsaac force-pushed the don/07-12-feat_linter_support_suggestions_and_dangerous_fixes branch from e17aedc to bc75085 Compare July 17, 2024 17:49
@DonIsaac DonIsaac force-pushed the don/07-16-feat_linter_add_suggestion_for_no-console branch from 8e60009 to a5188b1 Compare July 17, 2024 17:49
@DonIsaac DonIsaac mentioned this pull request Jul 17, 2024
Merged
@DonIsaac DonIsaac force-pushed the don/07-12-feat_linter_support_suggestions_and_dangerous_fixes branch from 212fcbf to 7afa1f0 Compare July 18, 2024 02:20
@DonIsaac DonIsaac changed the base branch from don/07-12-feat_linter_support_suggestions_and_dangerous_fixes to main July 18, 2024 02:24
@DonIsaac DonIsaac force-pushed the don/07-16-feat_linter_add_suggestion_for_no-console branch from a5188b1 to 4b76383 Compare July 18, 2024 02:24
@DonIsaac DonIsaac mentioned this pull request Aug 13, 2024
Merged
@Boshen Boshen force-pushed the don/07-16-feat_linter_add_suggestion_for_no-console branch from 4b76383 to fab4026 Compare November 21, 2024 07:37
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 21, 2024
@Boshen Graphite App
Copy link
Member

Boshen commented Nov 21, 2024 •
edited by graphite-app bot
Loading

Merge activity

  • Nov 21, 2:38 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 21, 2:42 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 21, 2:52 AM EST: A user merged this pull request with the Graphite merge queue.

Boshen pushed a commit that referenced this pull request Nov 21, 2024
@DonIsaac
feat(linter): add suggestion for no-console (#4312)
63f2425 
Part of #4179
@Boshen Boshen force-pushed the don/07-16-feat_linter_add_suggestion_for_no-console branch from fab4026 to 63f2425 Compare November 21, 2024 07:42
@Boshen Boshen force-pushed the don/07-16-feat_linter_add_suggestion_for_no-console branch from 63f2425 to 849489e Compare November 21, 2024 07:46
@graphite-app graphite-app bot merged commit 849489e into main Nov 21, 2024
26 checks passed
@graphite-app graphite-app bot deleted the don/07-16-feat_linter_add_suggestion_for_no-console branch November 21, 2024 07:52
@oxc-bot oxc-bot mentioned this pull request Nov 21, 2024
Merged
Boshen added a commit that referenced this pull request Nov 21, 2024
@oxc-bot @Boshen
release(oxlint): v0.13.0 (#7398)
4b5a176 
## [0.13.0] - 2024-11-21

- 7bf970a linter: [**BREAKING**] Remove tree_shaking plugin (#7372)
(Boshen)
- 7f8747d linter: Implement `react/no-array-index-key` (#6960)
(BitterGourd)

### Features

- be152c0 linter: Add `typescript/no-require-imports` rule (#7315)
(Dmitry Zakharov)
- 849489e linter: Add suggestion for no-console (#4312) (DonIsaac)
- 8cebdc8 linter: Allow appending plugins in override (#7379)
(camchenry)
- 8cfea3c oxc_cfg: Add implicit return instruction (#5568)
(IWANABETHATGUY)
- e6922df parser: Fix incorrect AST for `x?.f<T>()` (#7387) (Boshen)

### Bug Fixes

- e91c287 linter: Fix panic in react/no-array-index-key (#7395) (Boshen)
- a32f5a7 linter/no-array-index-key: Compile error due to it uses a
renamed API (#7391) (Dunqing)
- 666b6c1 parser: Add missing `ChainExpression` in optional
`TSInstantiationExpression` (#7371) (Boshen)

### Documentation

- df143ca linter: Add docs for config settings (#4827) (DonIsaac)
- ad44cfa linter: Import/first options (#7381) (Zak)

### Refactor

- c34d649 linter: Use `scope_id` etc methods (#7394) (overlookmotel)
- 466f395 vscode: Split `ConfigService` and `Config` (#7376) (Alexander
S.)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mysteryven mysteryven mysteryven left review comments

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-linter Area - Linter A-semantic Area - Semantic C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DonIsaac @Boshen @mysteryven