Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): add typescript/no-require-imports rule #7315

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

pumano
Copy link
Contributor

@pumano pumano commented Nov 16, 2024

No description provided.

Copy link

graphite-app bot commented Nov 16, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Nov 16, 2024
@pumano pumano force-pushed the feat/linter-no-require-imports branch from ca876ba to fd7b0c7 Compare November 16, 2024 17:51
Copy link

codspeed-hq bot commented Nov 16, 2024

CodSpeed Performance Report

Merging #7315 will not alter performance

Comparing pumano:feat/linter-no-require-imports (144649f) with main (44fd962)

Summary

✅ 30 untouched benchmarks

@pumano pumano force-pushed the feat/linter-no-require-imports branch 5 times, most recently from 0d70709 to 7c089b0 Compare November 16, 2024 18:59
@pumano pumano force-pushed the feat/linter-no-require-imports branch from 7c089b0 to 144649f Compare November 17, 2024 15:54
@pumano
Copy link
Contributor Author

pumano commented Nov 17, 2024

add test case for covering require in function #7316 (comment) original rule has same behavior

@Boshen Boshen merged commit be152c0 into oxc-project:main Nov 21, 2024
27 checks passed
@pumano pumano deleted the feat/linter-no-require-imports branch November 21, 2024 13:07
Boshen added a commit that referenced this pull request Nov 21, 2024
## [0.13.0] - 2024-11-21

- 7bf970a linter: [**BREAKING**] Remove tree_shaking plugin (#7372)
(Boshen)
- 7f8747d linter: Implement `react/no-array-index-key` (#6960)
(BitterGourd)

### Features

- be152c0 linter: Add `typescript/no-require-imports` rule (#7315)
(Dmitry Zakharov)
- 849489e linter: Add suggestion for no-console (#4312) (DonIsaac)
- 8cebdc8 linter: Allow appending plugins in override (#7379)
(camchenry)
- 8cfea3c oxc_cfg: Add implicit return instruction (#5568)
(IWANABETHATGUY)
- e6922df parser: Fix incorrect AST for `x?.f<T>()` (#7387) (Boshen)

### Bug Fixes

- e91c287 linter: Fix panic in react/no-array-index-key (#7395) (Boshen)
- a32f5a7 linter/no-array-index-key: Compile error due to it uses a
renamed API (#7391) (Dunqing)
- 666b6c1 parser: Add missing `ChainExpression` in optional
`TSInstantiationExpression` (#7371) (Boshen)

### Documentation

- df143ca linter: Add docs for config settings (#4827) (DonIsaac)
- ad44cfa linter: Import/first options (#7381) (Zak)

### Refactor

- c34d649 linter: Use `scope_id` etc methods (#7394) (overlookmotel)
- 466f395 vscode: Split `ConfigService` and `Config` (#7376) (Alexander
S.)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants