Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(linter): use scope_id etc methods #7394

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Nov 21, 2024

Utilize the methods added in #7127 in oxc_linter.

Copy link

graphite-app bot commented Nov 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@overlookmotel overlookmotel marked this pull request as ready for review November 21, 2024 12:25
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Nov 21, 2024
@overlookmotel
Copy link
Contributor Author

I wrote this PR weeks ago, just forgot to submit it.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Nov 21, 2024
Copy link
Member

Boshen commented Nov 21, 2024

Merge activity

  • Nov 21, 7:29 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 21, 7:29 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 21, 7:34 AM EST: A user merged this pull request with the Graphite merge queue.

Utilize the methods added in #7127 in `oxc_linter`.
@Boshen Boshen force-pushed the 11-04-refactor_linter_use_scope_id_etc_methods branch from da7c352 to c34d649 Compare November 21, 2024 12:30
@graphite-app graphite-app bot merged commit c34d649 into main Nov 21, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 11-04-refactor_linter_use_scope_id_etc_methods branch November 21, 2024 12:34
Copy link

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #7394 will not alter performance

Comparing 11-04-refactor_linter_use_scope_id_etc_methods (c34d649) with main (224775c)

Summary

✅ 30 untouched benchmarks

Boshen added a commit that referenced this pull request Nov 21, 2024
## [0.13.0] - 2024-11-21

- 7bf970a linter: [**BREAKING**] Remove tree_shaking plugin (#7372)
(Boshen)
- 7f8747d linter: Implement `react/no-array-index-key` (#6960)
(BitterGourd)

### Features

- be152c0 linter: Add `typescript/no-require-imports` rule (#7315)
(Dmitry Zakharov)
- 849489e linter: Add suggestion for no-console (#4312) (DonIsaac)
- 8cebdc8 linter: Allow appending plugins in override (#7379)
(camchenry)
- 8cfea3c oxc_cfg: Add implicit return instruction (#5568)
(IWANABETHATGUY)
- e6922df parser: Fix incorrect AST for `x?.f<T>()` (#7387) (Boshen)

### Bug Fixes

- e91c287 linter: Fix panic in react/no-array-index-key (#7395) (Boshen)
- a32f5a7 linter/no-array-index-key: Compile error due to it uses a
renamed API (#7391) (Dunqing)
- 666b6c1 parser: Add missing `ChainExpression` in optional
`TSInstantiationExpression` (#7371) (Boshen)

### Documentation

- df143ca linter: Add docs for config settings (#4827) (DonIsaac)
- ad44cfa linter: Import/first options (#7381) (Zak)

### Refactor

- c34d649 linter: Use `scope_id` etc methods (#7394) (overlookmotel)
- 466f395 vscode: Split `ConfigService` and `Config` (#7376) (Alexander
S.)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants