Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(oxc_cfg): add implicit return instruction #5568

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Sep 7, 2024

  1. Adding a new InstructionKind ImplicitReturn
  2. Adding a new ImplicitReturn instruction for each function body, just like biome
    image

Copy link

graphite-app bot commented Sep 7, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@IWANABETHATGUY IWANABETHATGUY changed the title feat(oxc_cfg): 🎸 add implicit return inst feat(oxc_cfg): add implicit return inst Sep 7, 2024
@github-actions github-actions bot added A-linter Area - Linter A-semantic Area - Semantic A-cfg Area - Control Flow Graph labels Sep 7, 2024
Copy link

codspeed-hq bot commented Sep 7, 2024

CodSpeed Performance Report

Merging #5568 will not alter performance

Comparing feat/add-implicit-return-inst (3f5e1a2) with main (849489e)

Summary

✅ 30 untouched benchmarks

@IWANABETHATGUY IWANABETHATGUY changed the title feat(oxc_cfg): add implicit return inst feat(oxc_cfg): add implicit return instruction Sep 7, 2024
@IWANABETHATGUY IWANABETHATGUY requested a review from rzvxa September 7, 2024 09:08
rzvxa
rzvxa previously requested changes Sep 7, 2024
Copy link
Contributor

@rzvxa rzvxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also do the same thing for the visit_arrow_function_expression method.

crates/oxc_semantic/src/builder.rs Show resolved Hide resolved
crates/oxc_semantic/src/builder.rs Show resolved Hide resolved
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review September 8, 2024 04:04
@IWANABETHATGUY IWANABETHATGUY force-pushed the feat/add-implicit-return-inst branch from 5dc427b to aa0ba23 Compare September 8, 2024 04:04
@IWANABETHATGUY IWANABETHATGUY requested a review from rzvxa September 8, 2024 05:05
@IWANABETHATGUY IWANABETHATGUY force-pushed the feat/add-implicit-return-inst branch 3 times, most recently from 809ffae to c0d4117 Compare September 9, 2024 14:53
@Boshen
Copy link
Member

Boshen commented Sep 10, 2024

Waiting for @rzvxa to take a look.

@Boshen Boshen added the blocker label Sep 11, 2024
@Boshen Boshen force-pushed the feat/add-implicit-return-inst branch from c0d4117 to 3f5e1a2 Compare November 21, 2024 08:09
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Nov 21, 2024
@Boshen Boshen merged commit 8cfea3c into main Nov 21, 2024
25 checks passed
@Boshen Boshen deleted the feat/add-implicit-return-inst branch November 21, 2024 08:18
This was referenced Nov 21, 2024
Boshen added a commit that referenced this pull request Nov 21, 2024
## [0.13.0] - 2024-11-21

- 7bf970a linter: [**BREAKING**] Remove tree_shaking plugin (#7372)
(Boshen)
- 7f8747d linter: Implement `react/no-array-index-key` (#6960)
(BitterGourd)

### Features

- be152c0 linter: Add `typescript/no-require-imports` rule (#7315)
(Dmitry Zakharov)
- 849489e linter: Add suggestion for no-console (#4312) (DonIsaac)
- 8cebdc8 linter: Allow appending plugins in override (#7379)
(camchenry)
- 8cfea3c oxc_cfg: Add implicit return instruction (#5568)
(IWANABETHATGUY)
- e6922df parser: Fix incorrect AST for `x?.f<T>()` (#7387) (Boshen)

### Bug Fixes

- e91c287 linter: Fix panic in react/no-array-index-key (#7395) (Boshen)
- a32f5a7 linter/no-array-index-key: Compile error due to it uses a
renamed API (#7391) (Dunqing)
- 666b6c1 parser: Add missing `ChainExpression` in optional
`TSInstantiationExpression` (#7371) (Boshen)

### Documentation

- df143ca linter: Add docs for config settings (#4827) (DonIsaac)
- ad44cfa linter: Import/first options (#7381) (Zak)

### Refactor

- c34d649 linter: Use `scope_id` etc methods (#7394) (overlookmotel)
- 466f395 vscode: Split `ConfigService` and `Config` (#7376) (Alexander
S.)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cfg Area - Control Flow Graph A-linter Area - Linter A-semantic Area - Semantic blocker C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants