-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ast): re-order generated code #8863
Merged
Merged
+6,528
−6,528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2025
github-actions
bot
added
A-ast
Area - AST
A-ast-tools
Area - AST tools
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
labels
Feb 3, 2025
CodSpeed Performance ReportMerging #8863 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
02-02-refactor_ast_remove_unneeded_lint_attrs_from_generated_code
branch
from
February 3, 2025 18:51
a9b76af
to
14a3737
Compare
overlookmotel
force-pushed
the
02-02-refactor_ast_re-order_generated_code
branch
from
February 3, 2025 18:52
32bfaeb
to
12a7d4d
Compare
No substantive change, so merging without review. |
This was referenced Feb 3, 2025
overlookmotel
changed the base branch from
02-02-refactor_ast_remove_unneeded_lint_attrs_from_generated_code
to
graphite-base/8863
February 3, 2025 18:58
Contributor
Author
Merge activity
|
overlookmotel
force-pushed
the
02-02-refactor_ast_re-order_generated_code
branch
from
February 3, 2025 20:18
12a7d4d
to
bc2b9bb
Compare
This was referenced Feb 3, 2025
Change order in which source files are processed by `oxc_ast_tools`, so `oxc_ast/src/ast/js.rs` is first. This doesn't modify any code, just changes the order of generated methods. Notably `Program` appears first. This will be useful later, for simplifying generation of `Visit` trait.
graphite-app
bot
force-pushed
the
02-02-refactor_ast_re-order_generated_code
branch
from
February 3, 2025 20:29
bc2b9bb
to
f6f92db
Compare
graphite-app
bot
deleted the
02-02-refactor_ast_re-order_generated_code
branch
February 3, 2025 21:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0-merge
Merge with Graphite Merge Queue
A-ast
Area - AST
A-ast-tools
Area - AST tools
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change order in which source files are processed by
oxc_ast_tools
, sooxc_ast/src/ast/js.rs
is first. This doesn't modify any code, just changes the order of generated methods. NotablyProgram
appears first. This will be useful later, for simplifying generation ofVisit
trait.