Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast): re-order generated code #8863

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 3, 2025

Change order in which source files are processed by oxc_ast_tools, so oxc_ast/src/ast/js.rs is first. This doesn't modify any code, just changes the order of generated methods. Notably Program appears first. This will be useful later, for simplifying generation of Visit trait.

Copy link
Contributor Author

overlookmotel commented Feb 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #8863 will not alter performance

Comparing 02-02-refactor_ast_re-order_generated_code (f6f92db) with main (f69de07)

Summary

✅ 33 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 02-02-refactor_ast_remove_unneeded_lint_attrs_from_generated_code branch from a9b76af to 14a3737 Compare February 3, 2025 18:51
@overlookmotel overlookmotel force-pushed the 02-02-refactor_ast_re-order_generated_code branch from 32bfaeb to 12a7d4d Compare February 3, 2025 18:52
@overlookmotel
Copy link
Contributor Author

No substantive change, so merging without review.

Copy link
Contributor Author

overlookmotel commented Feb 3, 2025

Merge activity

  • Feb 3, 3:14 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 3, 3:16 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 3, 3:17 PM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Feb 3, 3:18 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 3, 3:18 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.
  • Feb 3, 8:19 PM UTC: The merge label '0-merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Feb 3, 3:26 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 3, 3:29 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 3, 8:49 PM UTC: The Graphite merge queue couldn't merge this PR because it timed out.
  • Feb 3, 4:50 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 3, 4:51 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 3, 4:51 PM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from graphite-base/8863 to main February 3, 2025 20:16
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 3, 2025
Change order in which source files are processed by `oxc_ast_tools`, so `oxc_ast/src/ast/js.rs` is first. This doesn't modify any code, just changes the order of generated methods. Notably `Program` appears first. This will be useful later, for simplifying generation of `Visit` trait.
@graphite-app graphite-app bot force-pushed the 02-02-refactor_ast_re-order_generated_code branch from bc2b9bb to f6f92db Compare February 3, 2025 20:29
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 3, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Feb 3, 2025
@graphite-app graphite-app bot merged commit f6f92db into main Feb 3, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 02-02-refactor_ast_re-order_generated_code branch February 3, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant