-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(syntax): add #[ast]
attr to semantic ID types
#8867
Merged
graphite-app
merged 1 commit into
main
from
02-03-refactor_syntax_add_ast_attr_to_semantic_id_types
Feb 4, 2025
Merged
refactor(syntax): add #[ast]
attr to semantic ID types
#8867
graphite-app
merged 1 commit into
main
from
02-03-refactor_syntax_add_ast_attr_to_semantic_id_types
Feb 4, 2025
+60
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2025
github-actions
bot
added
A-ast
Area - AST
A-ast-tools
Area - AST tools
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
labels
Feb 3, 2025
CodSpeed Performance ReportMerging #8867 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
02-03-feat_ast_tools_allow_defining_foreign_types_with_ast_foreign_._
branch
from
February 3, 2025 18:52
bd2f2e1
to
482836b
Compare
overlookmotel
force-pushed
the
02-03-refactor_syntax_add_ast_attr_to_semantic_id_types
branch
from
February 3, 2025 18:52
e219e3f
to
f0c7c6a
Compare
This was referenced Feb 3, 2025
overlookmotel
force-pushed
the
02-03-feat_ast_tools_allow_defining_foreign_types_with_ast_foreign_._
branch
from
February 3, 2025 20:22
482836b
to
dc0a998
Compare
overlookmotel
force-pushed
the
02-03-refactor_syntax_add_ast_attr_to_semantic_id_types
branch
from
February 3, 2025 20:22
f0c7c6a
to
eb373ac
Compare
This was referenced Feb 3, 2025
overlookmotel
force-pushed
the
02-03-feat_ast_tools_allow_defining_foreign_types_with_ast_foreign_._
branch
from
February 3, 2025 21:53
dc0a998
to
534c4f8
Compare
overlookmotel
force-pushed
the
02-03-refactor_syntax_add_ast_attr_to_semantic_id_types
branch
from
February 3, 2025 21:53
eb373ac
to
ec98843
Compare
Merge activity
|
Add `#[ast]` attr to `ScopeId`, `SymbolId` and `ReferenceId` types. This makes them an "official" part of the AST, and removes the hacky "special case" logic from `oxc_ast_tools` which was previously working around that they weren't registered as part of the AST. This uses the `#[ast(foreign = ...)]` feature introduced in #8866 to inform `oxc_ast_tools` about the foreign `NonMaxU32` type, enabling the ID types to be parsed and understood.
graphite-app
bot
force-pushed
the
02-03-feat_ast_tools_allow_defining_foreign_types_with_ast_foreign_._
branch
from
February 4, 2025 02:49
534c4f8
to
9072f4c
Compare
graphite-app
bot
force-pushed
the
02-03-refactor_syntax_add_ast_attr_to_semantic_id_types
branch
from
February 4, 2025 02:50
ec98843
to
768ad4f
Compare
Base automatically changed from
02-03-feat_ast_tools_allow_defining_foreign_types_with_ast_foreign_._
to
main
February 4, 2025 03:21
graphite-app
bot
deleted the
02-03-refactor_syntax_add_ast_attr_to_semantic_id_types
branch
February 4, 2025 03:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0-merge
Merge with Graphite Merge Queue
A-ast
Area - AST
A-ast-tools
Area - AST tools
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
#[ast]
attr toScopeId
,SymbolId
andReferenceId
types. This makes them an "official" part of the AST, and removes the hacky "special case" logic fromoxc_ast_tools
which was previously working around that they weren't registered as part of the AST.This uses the
#[ast(foreign = ...)]
feature introduced in #8866 to informoxc_ast_tools
about the foreignNonMaxU32
type, enabling the ID types to be parsed and understood.