-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ast_tools): allow attrs on types which do not derive the trait #8874
Merged
graphite-app
merged 1 commit into
main
from
02-03-feat_ast_tools_allow_attrs_on_types_which_do_not_derive_the_trait
Feb 4, 2025
Merged
feat(ast_tools): allow attrs on types which do not derive the trait #8874
graphite-app
merged 1 commit into
main
from
02-03-feat_ast_tools_allow_attrs_on_types_which_do_not_derive_the_trait
Feb 4, 2025
+52
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2025
This was referenced Feb 3, 2025
github-actions
bot
added
A-ast-tools
Area - AST tools
C-enhancement
Category - New feature or request
labels
Feb 3, 2025
overlookmotel
force-pushed
the
02-03-refactor_ast_rename_estree_always_flatten_attr_to_estree_flatten_
branch
from
February 3, 2025 20:22
5bf3d6e
to
0a8303d
Compare
overlookmotel
force-pushed
the
02-03-feat_ast_tools_allow_attrs_on_types_which_do_not_derive_the_trait
branch
from
February 3, 2025 20:22
c4e297d
to
7a74484
Compare
This was referenced Feb 3, 2025
overlookmotel
force-pushed
the
02-03-refactor_ast_rename_estree_always_flatten_attr_to_estree_flatten_
branch
from
February 3, 2025 21:56
0a8303d
to
8c6d877
Compare
overlookmotel
force-pushed
the
02-03-feat_ast_tools_allow_attrs_on_types_which_do_not_derive_the_trait
branch
from
February 3, 2025 21:56
7a74484
to
dd71d68
Compare
Merge activity
|
graphite-app
bot
force-pushed
the
02-03-refactor_ast_rename_estree_always_flatten_attr_to_estree_flatten_
branch
from
February 4, 2025 02:52
8c6d877
to
7ddd219
Compare
graphite-app
bot
force-pushed
the
02-03-feat_ast_tools_allow_attrs_on_types_which_do_not_derive_the_trait
branch
from
February 4, 2025 02:52
dd71d68
to
f40f494
Compare
Base automatically changed from
02-03-refactor_ast_rename_estree_always_flatten_attr_to_estree_flatten_
to
main
February 4, 2025 03:39
graphite-app
bot
deleted the
02-03-feat_ast_tools_allow_attrs_on_types_which_do_not_derive_the_trait
branch
February 4, 2025 03:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0-merge
Merge with Graphite Merge Queue
A-ast-tools
Area - AST tools
C-enhancement
Category - New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally, custom attributes relating to a trait e.g.
CloneIn
/#[clone_in]
are only legal if the trait is derived on the type. Allow aDerive
to choose to relax this restriction. This is necessary for #8875, #8876, and #8877.