Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ast_tools): allow attrs on types which do not derive the trait #8874

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 3, 2025

Generally, custom attributes relating to a trait e.g. CloneIn / #[clone_in] are only legal if the trait is derived on the type. Allow a Derive to choose to relax this restriction. This is necessary for #8875, #8876, and #8877.

Copy link
Contributor Author

overlookmotel commented Feb 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review February 3, 2025 19:02
@github-actions github-actions bot added A-ast-tools Area - AST tools C-enhancement Category - New feature or request labels Feb 3, 2025
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_rename_estree_always_flatten_attr_to_estree_flatten_ branch from 5bf3d6e to 0a8303d Compare February 3, 2025 20:22
@overlookmotel overlookmotel force-pushed the 02-03-feat_ast_tools_allow_attrs_on_types_which_do_not_derive_the_trait branch from c4e297d to 7a74484 Compare February 3, 2025 20:22
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_rename_estree_always_flatten_attr_to_estree_flatten_ branch from 0a8303d to 8c6d877 Compare February 3, 2025 21:56
@overlookmotel overlookmotel force-pushed the 02-03-feat_ast_tools_allow_attrs_on_types_which_do_not_derive_the_trait branch from 7a74484 to dd71d68 Compare February 3, 2025 21:56
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 4, 2025
Copy link

graphite-app bot commented Feb 4, 2025

Merge activity

…8874)

Generally, custom attributes relating to a trait e.g. `CloneIn` / `#[clone_in]` are only legal if the trait is derived on the type. Allow a `Derive` to choose to relax this restriction. This is necessary for #8875, #8876, and #8877.
@graphite-app graphite-app bot force-pushed the 02-03-refactor_ast_rename_estree_always_flatten_attr_to_estree_flatten_ branch from 8c6d877 to 7ddd219 Compare February 4, 2025 02:52
@graphite-app graphite-app bot force-pushed the 02-03-feat_ast_tools_allow_attrs_on_types_which_do_not_derive_the_trait branch from dd71d68 to f40f494 Compare February 4, 2025 02:52
Base automatically changed from 02-03-refactor_ast_rename_estree_always_flatten_attr_to_estree_flatten_ to main February 4, 2025 03:39
@graphite-app graphite-app bot merged commit f40f494 into main Feb 4, 2025
16 checks passed
@graphite-app graphite-app bot deleted the 02-03-feat_ast_tools_allow_attrs_on_types_which_do_not_derive_the_trait branch February 4, 2025 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant