-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ast): rename #[estree(always_flatten)]
attr to #[estree(flatten)]
#8871
Merged
graphite-app
merged 1 commit into
main
from
02-03-refactor_ast_rename_estree_always_flatten_attr_to_estree_flatten_
Feb 4, 2025
Merged
refactor(ast): rename #[estree(always_flatten)]
attr to #[estree(flatten)]
#8871
graphite-app
merged 1 commit into
main
from
02-03-refactor_ast_rename_estree_always_flatten_attr_to_estree_flatten_
Feb 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2025
CodSpeed Performance ReportMerging #8871 will not alter performanceComparing Summary
|
f0fb048
to
d11733c
Compare
7afad1f
to
5bf3d6e
Compare
This was referenced Feb 3, 2025
d11733c
to
2f55d91
Compare
5bf3d6e
to
0a8303d
Compare
This was referenced Feb 3, 2025
2f55d91
to
92fcb66
Compare
0a8303d
to
8c6d877
Compare
Merge activity
|
…latten)]` (#8871) Rename `#[estree(always_flatten)]` attr to `#[estree(flatten)]`. This follows our convention that attributes can appear on either struct fields (flatten this field) or on types (flatten *all* fields which contain this type) - and both attrs are called the same thing.
92fcb66
to
8f0b865
Compare
8c6d877
to
7ddd219
Compare
Base automatically changed from
02-03-feat_ast_tools_generate_mapping_of_trait_name_to_crate_in_oxc_ast_macros_
to
main
February 4, 2025 03:36
This was referenced Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0-merge
Merge with Graphite Merge Queue
A-ast-tools
Area - AST tools
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
#[estree(always_flatten)]
attr to#[estree(flatten)]
. This follows our convention that attributes can appear on either struct fields (flatten this field) or on types (flatten all fields which contain this type) - and both attrs are called the same thing.