Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast): rename #[estree(always_flatten)] attr to #[estree(flatten)] #8871

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 3, 2025

Rename #[estree(always_flatten)] attr to #[estree(flatten)]. This follows our convention that attributes can appear on either struct fields (flatten this field) or on types (flatten all fields which contain this type) - and both attrs are called the same thing.

Copy link
Contributor Author

overlookmotel commented Feb 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #8871 will not alter performance

Comparing 02-03-refactor_ast_rename_estree_always_flatten_attr_to_estree_flatten_ (7ddd219) with 02-03-feat_ast_tools_generate_mapping_of_trait_name_to_crate_in_oxc_ast_macros_ (8f0b865)

Summary

✅ 33 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 02-03-feat_ast_tools_generate_mapping_of_trait_name_to_crate_in_oxc_ast_macros_ branch from f0fb048 to d11733c Compare February 3, 2025 18:52
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_rename_estree_always_flatten_attr_to_estree_flatten_ branch from 7afad1f to 5bf3d6e Compare February 3, 2025 18:52
@overlookmotel overlookmotel force-pushed the 02-03-feat_ast_tools_generate_mapping_of_trait_name_to_crate_in_oxc_ast_macros_ branch from d11733c to 2f55d91 Compare February 3, 2025 20:22
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_rename_estree_always_flatten_attr_to_estree_flatten_ branch from 5bf3d6e to 0a8303d Compare February 3, 2025 20:22
@overlookmotel overlookmotel force-pushed the 02-03-feat_ast_tools_generate_mapping_of_trait_name_to_crate_in_oxc_ast_macros_ branch from 2f55d91 to 92fcb66 Compare February 3, 2025 21:55
@overlookmotel overlookmotel force-pushed the 02-03-refactor_ast_rename_estree_always_flatten_attr_to_estree_flatten_ branch from 0a8303d to 8c6d877 Compare February 3, 2025 21:56
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 4, 2025
Copy link

graphite-app bot commented Feb 4, 2025

Merge activity

…latten)]` (#8871)

Rename `#[estree(always_flatten)]` attr to `#[estree(flatten)]`. This follows our convention that attributes can appear on either struct fields (flatten this field) or on types (flatten *all* fields which contain this type) - and both attrs are called the same thing.
@graphite-app graphite-app bot force-pushed the 02-03-feat_ast_tools_generate_mapping_of_trait_name_to_crate_in_oxc_ast_macros_ branch from 92fcb66 to 8f0b865 Compare February 4, 2025 02:51
@graphite-app graphite-app bot force-pushed the 02-03-refactor_ast_rename_estree_always_flatten_attr_to_estree_flatten_ branch from 8c6d877 to 7ddd219 Compare February 4, 2025 02:52
Base automatically changed from 02-03-feat_ast_tools_generate_mapping_of_trait_name_to_crate_in_oxc_ast_macros_ to main February 4, 2025 03:36
@graphite-app graphite-app bot merged commit 7ddd219 into main Feb 4, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 02-03-refactor_ast_rename_estree_always_flatten_attr_to_estree_flatten_ branch February 4, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant