-
-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ast): record plural names in #[plural]
attr
#8889
Merged
graphite-app
merged 1 commit into
main
from
02-04-refactor_ast_record_plural_names_in_plural_attr
Feb 4, 2025
Merged
refactor(ast): record plural names in #[plural]
attr
#8889
graphite-app
merged 1 commit into
main
from
02-04-refactor_ast_record_plural_names_in_plural_attr
Feb 4, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2025
This was referenced Feb 4, 2025
CodSpeed Performance ReportMerging #8889 will not alter performanceComparing Summary
|
This was referenced Feb 4, 2025
6cd23a5
to
33ba1db
Compare
a6c5d22
to
90ab249
Compare
Merge activity
|
Instead of hard-coding pluralized type names in `Visit` generator, specify the special cases with a `#[plural]` attribute on the type. This makes them available for other generators e.g. codegen for AST transfer. Also pre-compute names of `visit_*` and `walk_*` methods and store them in the `Schema`, to avoid re-calculating them each time. This will also make it easier to add other code generators which produce `Visit` implementations.
33ba1db
to
4b14dc2
Compare
90ab249
to
893339d
Compare
Base automatically changed from
02-04-refactor_ast_tools_shorten_code
to
main
February 4, 2025 22:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0-merge
Merge with Graphite Merge Queue
A-ast
Area - AST
A-ast-tools
Area - AST tools
C-cleanup
Category - technical debt or refactoring. Solution not expected to change behavior
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hard-coding pluralized type names in
Visit
generator, specify the special cases with a#[plural]
attribute on the type. This makes them available for other generators e.g. codegen for AST transfer.Also pre-compute names of
visit_*
andwalk_*
methods and store them in theSchema
, to avoid re-calculating them each time. This will also make it easier to add other code generators which produceVisit
implementations.