Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ast_tools): shorten code #8888

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 4, 2025

Tiny refactor. Remove an unnecessary .as_ref().

@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 4, 2025
Copy link
Contributor Author

overlookmotel commented Feb 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 4, 2025
@overlookmotel overlookmotel force-pushed the 02-03-feat_ast_tools_get_extra_params_for_visitor_methods_from_visit_args_attr branch from c10786c to 4764a39 Compare February 4, 2025 21:56
@overlookmotel overlookmotel force-pushed the 02-04-refactor_ast_tools_shorten_code branch from 6cd23a5 to 33ba1db Compare February 4, 2025 21:56
Copy link

graphite-app bot commented Feb 4, 2025

Merge activity

@graphite-app graphite-app bot added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Feb 4, 2025
Tiny refactor. Remove an unnecessary `.as_ref()`.
@graphite-app graphite-app bot force-pushed the 02-03-feat_ast_tools_get_extra_params_for_visitor_methods_from_visit_args_attr branch from 4764a39 to c940826 Compare February 4, 2025 22:32
@graphite-app graphite-app bot force-pushed the 02-04-refactor_ast_tools_shorten_code branch from 33ba1db to 4b14dc2 Compare February 4, 2025 22:33
Base automatically changed from 02-03-feat_ast_tools_get_extra_params_for_visitor_methods_from_visit_args_attr to main February 4, 2025 22:48
@graphite-app graphite-app bot merged commit 4b14dc2 into main Feb 4, 2025
16 checks passed
@graphite-app graphite-app bot deleted the 02-04-refactor_ast_tools_shorten_code branch February 4, 2025 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant